On 8/26/05, Eric Dumazet <[EMAIL PROTECTED]> wrote: > David S. Miller a écrit : > > From: Eric Dumazet <[EMAIL PROTECTED]> > > Date: Fri, 26 Aug 2005 03:07:06 +0200 > > > > > >>On one of my production machine, tcp_statistics was sitting in a heavily > >>modified cache line, so *every* SNMP update had to force a reload. > > > > > > But I disagree that statistics belong in the __read_mostly. > > They are write mostly, in fact. :-) Some are incremented every > > single packet, and they are per-cpu objects as well. > > > > David I think you missed that statistics are per cpu, so I have to explain why > this patch is usefull.
Eric, without questioning the merit of the changes David oposed to, his request for splitting the patch is reasonable, could you please do that? Thanks, - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
