Re: [PATCH] add bridging support to nfnetlink_{log,queue}

2005-08-08 Thread Bart De Schuymer
Op ma, 08-08-2005 te 19:36 +0200, schreef Harald Welte: > > then the physindev should still be filled in if ebt_ulog is used. I'm > > afraid this will result in more ugly ifdef's. > > well, If you can send me a patch for those ugly ifdef's after you get > back from holidays, I'll apply it. Until

Re: [RFC] Net vm deadlock fix, version 5

2005-08-08 Thread Daniel Phillips
Hi, A couple of goofs. First, the sysctl interface to min_free_kbytes could stomp on any in-kernel adjustments. Now there are two variables, summed in setup_per_zone_pages_min: min_free_kbytes and var_free_kbytes. The adjust_memalloc_reserve operates only the latter, so the user can freely twid

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Mon, 08 Aug 2005 17:35:05 -0700 > I ACK all the other changes. Ok, please make the changes Michael and myself have noted and send the updated patch so I can add it to the net tree. Thanks. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread Michael Chan
On Tue, 2005-08-09 at 01:09 +0200, Peter Hagervall wrote: > This patch contains the following possible cleanups/fixes: > > - use C99 struct initializers > - make a few arrays and structs static > - remove a few uses of literal 0 as NULL pointer > - add __force attribute in cast to silence sparse >

Re: xfrm_user/per socket setsockopt(,,IP_XFRM_POLICY...) documentation

2005-08-08 Thread Herbert Xu
Jeremy Jackson <[EMAIL PROTECTED]> wrote: > > I'm looking for a way to set IPSEC policy per-socket; a quick trawl > throught the kernel source shows IP_IPSEC_POLICY (ie PF_KEY) isn't > implemented (per socket), but rather only the native Linux > IP_XFRM_POLICY sockopt. It certainly is impleme

SK98LIN jumbo frames performace issue

2005-08-08 Thread Michael Iatrou
Hi, I did several benchmarks using 3Com 3C940 Gigabit Ethernet adapter (SK98LIN card driver) and it seems there is a weird behavior when using jumbo frames (MTU 9000): The throughput for plain IP is 723 Mbits/sec, but when I enable IPSec (AH only, MD5) I can get up to 745 Mbits/sec! The fact th

[-mm patch] SIS190 must select MII

2005-08-08 Thread Adrian Bunk
On Tue, Aug 09, 2005 at 02:26:31AM +0200, Jiri Slaby wrote: > Hello, i find out this problem: > #make O=../bu allmodconfig > ... > #make O=../bu all > ... > LD .tmp_vmlinux1 > drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings': > /l/latest/xxx/drivers/net/sis190.c:1656: unde

Re: [PATCH] [IPV4] fib_trie cleanups

2005-08-08 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 15:38:00 +0200 > A fixed patch is below. Dave IMO it can be applied now. Applied to net-2.6.14, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [PATCH] ip_conntrack: fix handling of OOM

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 22:05:59 +0200 > [NETFILTER] return ENOMEM when ip_conntrack_alloc() fails. Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH] nf_log: check function arguments

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 19:04:31 +0200 > [NETFILTER] check nf_log function call arguments Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [PATCH] nf_{log,queue}: more verbose error reporting

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 19:03:05 +0200 > [NETFILTER] more verbose return codes from nf_{log,queue} Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [PATCH] add bridging support to nfnetlink_{log,queue}

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 15:24:13 +0200 > [NETFILTER] add correct bridging support to nfnetlink_{queue,log} Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread David S. Miller
From: Peter Hagervall <[EMAIL PROTECTED]> Date: Tue, 9 Aug 2005 01:09:40 +0200 > - { 0 }, > + { "" }, It wanst NULL, not an empty string. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

[PATCH] drivers/net/bnx2.c Possible sparse fixes

2005-08-08 Thread Peter Hagervall
This patch contains the following possible cleanups/fixes: - use C99 struct initializers - make a few arrays and structs static - remove a few uses of literal 0 as NULL pointer - add __force attribute in cast to silence sparse - remove casts to u8 * in calls to readl/writel I'm not sure about rem

Re: [patch 5/5] fib_trie: use RCU (EXPERIMENTAL)

2005-08-08 Thread Stephen Hemminger
On Thu, 4 Aug 2005 10:17:58 +0200 Robert Olsson <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger writes: > > Convert FIB Trie to use RCU for the normal lookup fast > > path. Use simple spin_lock for updates and dump access. > > Hello! > > Yes spent some days to get a complete RCU for the t

Re: [Bugme-new] [Bug 5025] New: Excessive time to connect to cable provider using dhcpcd

2005-08-08 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=5025 > >Summary: Excessive time to connect to cable provider using dhcpcd > Kernel Version: 2.6.13-rc6 > Status: NEW > Severity: low > Owner: [EMAIL PROTECTED] > Subm

Re: Netlink allocation for iSCSI and others

2005-08-08 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 08 Aug 2005 23:19:37 +0200 > David S. Miller wrote: > > So we can increase MAX_LINKS to 256 and that's what I think I will do > > for 2.6.14 unless there is a very serious objection. The tables sized > > by MAX_LINKS in af_netlink.c are dynamic

Re: Netlink allocation for iSCSI and others

2005-08-08 Thread Patrick McHardy
David S. Miller wrote: So we can increase MAX_LINKS to 256 and that's what I think I will do for 2.6.14 unless there is a very serious objection. The tables sized by MAX_LINKS in af_netlink.c are dynamically allocated, and the only linear iterations over MAX_LINKS are for the netlink socket proc

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-08 Thread Francois Romieu
Balazs Scheidler <[EMAIL PROTECTED]> : [...] > Is this tiny patchlet worth the trouble of changing > xfrm_init/xfrm_state_init to return int, and do error checking from > ip_rt_init() ? xfrm_policy_init() simply panics when the allocation fails. A sophisticated error checking can imho be the poin

request module protocol strings

2005-08-08 Thread David S. Miller
We have an icky situation in this area. Harald is right, I think. I'd suggest that Arnaldo fixes up his af_inet.c changes so that it uses "net-pf-*" like the rest of the tree does. Arnaldo, I pulled in your net-2.6.14 tree earlier today, so please send me a patch on-top of that. Thanks. - To u

Netlink allocation for iSCSI and others

2005-08-08 Thread David S. Miller
Ok, here is what I'm going to do for 2.6.13 and in the longer term. First, we can give the current NETLINK_ARPD value to iSCSI as it is unused since before I can even remember. Second, ROUTE6 and TAPBASE we can kill from the header file as both are unused as well. In the longer term, Patrick is

[PATCH] ip_conntrack: fix handling of OOM

2005-08-08 Thread Harald Welte
Hi Dave, please apply to net-2.6.14, [ok, now back to vdev] -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ "Fragmentation is like classful addressing -- an interesting early architectura

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Patrick McHardy
Harald Welte wrote: On Mon, Aug 08, 2005 at 08:25:39PM +0200, Patrick McHardy wrote: Thanks for the feedback. I guess I'll make it fail in netlink_create after failed module load then. sounds fine with me. However, we can then also remove NETLINK_USERSOCK, since IMHO it was intended for exac

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Harald Welte
On Mon, Aug 08, 2005 at 08:25:39PM +0200, Patrick McHardy wrote: > Thanks for the feedback. I guess I'll make it fail in netlink_create > after failed module load then. sounds fine with me. However, we can then also remove NETLINK_USERSOCK, since IMHO it was intended for exactly this mode of oper

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Patrick McHardy
Herbert Xu wrote: On Mon, Aug 08, 2005 at 12:46:30PM +0200, Patrick McHardy wrote: part on top of netlink). Right now there are none, so this won't cause any trouble, the question is if we want to retain the possibility or just don't care about this case. I'd say that as it is general use of

Re: [PATCH] add bridging support to nfnetlink_{log,queue}

2005-08-08 Thread Harald Welte
On Mon, Aug 08, 2005 at 05:43:29PM +, Bart De Schuymer wrote: > Op ma, 08-08-2005 te 15:24 +0200, schreef Harald Welte: > > > There is one case missing: the brouter case. If br0=eth0+eth1 and a > > > packet arrives at eth0 (not br0) in the IP code (not the bridge code), > > > then the indev mus

Re: [PATCH] add bridging support to nfnetlink_{log,queue}

2005-08-08 Thread Bart De Schuymer
Op ma, 08-08-2005 te 15:24 +0200, schreef Harald Welte: > > There is one case missing: the brouter case. If br0=eth0+eth1 and a > > packet arrives at eth0 (not br0) in the IP code (not the bridge code), > > then the indev must be eth0, not br0. How about something like this? > > Ok, I've implemen

[PATCH] nf_{log,queue}: more verbose error reporting

2005-08-08 Thread Harald Welte
Hi Dave! Please apply to your net-2.6.14, thanks -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ "Fragmentation is like classful addressing -- an interesting early architectural error th

[PATCH] nf_log: check function arguments

2005-08-08 Thread Harald Welte
Hi Dave! Please apply to your net-2.6.14, thanks Ok, this will be my last patch for some time, I promise. Guess you must be bored by now... -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 11:50:55 +0200 > DaveM is probably travelling back from UKUUG at the moment and therefore > wasn't able to push this fix to you. I'm actually back and operational as of this morning :-) I'll push this stuff to Linus later today. So Li

[PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-08 Thread Harald Welte
Hi Linus! DaveM is probably travelling back from UKUUG at the moment and therefore wasn't able to push this fix to you. The following trivial patch is confirmed to solve an ICMP corruption problem if NAT and the NOTRACK target are used together. Please apply before 2.6.13 is released. Thanks,

[PATCH] add bridging support to nfnetlink_{log,queue}

2005-08-08 Thread Harald Welte
> There is one case missing: the brouter case. If br0=eth0+eth1 and a > packet arrives at eth0 (not br0) in the IP code (not the bridge code), > then the indev must be eth0, not br0. How about something like this? Ok, I've implemented your suggested modifications now. Dave: Please apply to your

Re: QoS for web traffic

2005-08-08 Thread Anand SVR
Thomas, Yes, I see your point that it is efficient to do specific matching rather than a generic one. The idea what you have proposed through the steps is very clear. Would try your work on our campus once you are ready. Continuing the discussion further, may be performance impact for the text ba

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-08 Thread Balazs Scheidler
Sent to myself the first time. > > > > > > @@ -1097,6 +1097,8 @@ void __init xfrm_state_init(void) > > { > > int i; > > > > + xfrm_state_bydst = (struct list_head *) > > __get_free_pages(GFP_KERNEL, get_order(sizeof(struct list_head) * > > XFRM_DST_HSIZE * 2)); > > + xfr

[patch 3/5] fib_trie: Use const

2005-08-08 Thread Robert Olsson
Stephen Hemminger writes: > Use const where possible and get rid of EXTRACT() macro > that was never used. Thanks. Cheers. --ro Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> > Signed-off-by: Stephen Hemmigner <[EMAIL PROTECTED]> > >

[patch 2/5] fib_trie: Use ERR_PTR to handle errno return

2005-08-08 Thread Robert Olsson
Stephen Hemminger writes: > Change inflate/halve to use the ERR_PTR return value method to > avoid having to pass error code by reference. Thanks. A tested and fixed patch is below. I found two bugs > -if (!tn) { > -*err = -ENOMEM; > -return oldtnode; > -}

Re: [PATCH] move conntrack helper buffers out of BSS

2005-08-08 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Mon, 8 Aug 2005 00:39:34 +0200 > [NETFILTER] move conntrack helper buffers from BSS to kmalloc()ed memory Patch applied, thanks :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

[patch 1/5] fib_trie: use BUG_ON and pr_debug

2005-08-08 Thread Robert Olsson
Stephen Hemminger writes: > Change from using a custom debug hooks, to just using > pr_debug() and BUG_ON() in fib_trie. Stephen some this issues were addressed in Olof's patch just sent. Cheers. --ro - To unsubscribe from this list: send the line "un

Re: [PATCH] [IPV4] fib_trie cleanups

2005-08-08 Thread Robert Olsson
Olof Johansson writes: > Here's a new patch on top of that tree. Yet again, it builds, but I don't > have a setup to test it with just yet. I'll work on that later this week, > If someone else (Robert?) has a chance to give it a run before that, > let me know. > Some of the fib_trie stuff i

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Thomas Graf
* Herbert Xu <[EMAIL PROTECTED]> 2005-08-08 21:49 > On Mon, Aug 08, 2005 at 12:46:30PM +0200, Patrick McHardy wrote: > > > > part on top of netlink). Right now there are none, so this won't cause > > any trouble, the question is if we want to retain the possibility or > > just don't care about this

Re: QoS for web traffic

2005-08-08 Thread Thomas Graf
* Anand SVR <[EMAIL PROTECTED]> 2005-08-08 15:07 > I am happy to know that there is a way of achieving http level packet > classification once the connection tracking is also in place. We can > even think of other string combinations for url based classification, > not just what I mentioned in my

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Herbert Xu
On Mon, Aug 08, 2005 at 12:46:30PM +0200, Patrick McHardy wrote: > > part on top of netlink). Right now there are none, so this won't cause > any trouble, the question is if we want to retain the possibility or > just don't care about this case. I'd say that as it is general use of netlink between

Re: skge: ignoring bogus sensor interrups

2005-08-08 Thread Daniel Drake
Stephen, Stephen Hemminger wrote: A Gentoo user (on CC) has reported many of these messages appearing: skge ignoring bogus sensor interrups They appear so frequently that 3GB of logs are generated in 1 hour of usage. Try this: Index: skge-2.6/drivers/net/skge.c

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Patrick McHardy
Evgeniy Polyakov wrote: > On Mon, Aug 08, 2005 at 11:52:08AM +0200, Patrick McHardy ([EMAIL PROTECTED]) > wrote: > >>Yes, but this is not the problem. There is no user of netlink_broadcast >>which sends to multiple groups. The problem is that binding to groups >>is possible before a kernel socket

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Evgeniy Polyakov
On Mon, Aug 08, 2005 at 11:52:08AM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > > On Mon, Aug 08, 2005 at 01:03:44AM +0200, Patrick McHardy ([EMAIL > > PROTECTED]) wrote: > > > >>Yes, the patches are almost ready but I could use some ideas > >>for one remaining p

[RFC] Net vm deadlock fix, version 5

2005-08-08 Thread Daniel Phillips
Hi, This version introduces the idea of having a network driver adjust the global memalloc reserve when it brings an interface up or down. The interface is: int adjust_memalloc_reserve(int bytes) which is just a thin shell over the min_free_kbytes interface that already exists. The d

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Patrick McHardy
Evgeniy Polyakov wrote: > On Mon, Aug 08, 2005 at 01:03:44AM +0200, Patrick McHardy ([EMAIL PROTECTED]) > wrote: > >>Yes, the patches are almost ready but I could use some ideas >>for one remaining problem. The idea was that a subsystem which >>sends broadcast messages can specify how many groups

Re: QoS for web traffic

2005-08-08 Thread Anand SVR
Thomas, Thanks for the detailed response. Thought my mail was long forgotten :) I am happy to know that there is a way of achieving http level packet classification once the connection tracking is also in place. We can even think of other string combinations for url based classification, not ju

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-08 Thread [EMAIL PROTECTED]
(using webmail) >- Oorspronkelijk bericht - >Van: Harald Welte [mailto:[EMAIL PROTECTED] >Ok, so this is actually the opposite problem of the ipt_physdev.c >problem. Here we have the physical device, but not the bridge group. > >This means we have to handle two separate cases: > >1) when

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-08 Thread Harald Welte
[ Cleaning up Cc list ] On Mon, Aug 08, 2005 at 12:34:00AM +0200, Patrick McHardy wrote: > > Looking at the latest traces Vladimir sent me, there is another case, > > too. > > Yes, but nat_packet checks if manips have actually been set up before > touching the packet. This can never happen for t

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-08 Thread Harald Welte
[removing kaber and davem from cc list] On Mon, Aug 08, 2005 at 06:57:40AM +, Bart De Schuymer wrote: > > So I think it should reflect exactly what you currently do in ebt_ulog. > > The only diference is that you now get the ifindex and not the device > > name string. > > These two code fragm

[PATCH] move conntrack helper buffers out of BSS

2005-08-08 Thread Harald Welte
Hi Dave, I guess you will enjoy the following patch ;) Please apply to net-2.6.14, thanks. -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ "Fragmentation is like classful addressing -- an in

Re: [RFC] Netlink subscription/multicasting.

2005-08-08 Thread Evgeniy Polyakov
On Mon, Aug 08, 2005 at 01:03:44AM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: > Thomas Graf wrote: > >Anyways, your idea of having 32bit identifiers rather than a > >bitmask makes sense to me, however I think we should not lose > >the ability to do multicasting for event notifications so we

ip route flush: "OVERRUN: No buffer space available"

2005-08-08 Thread Christian Hammers
Hi When restarting the Quagga Routing Daemon on one of our routers I got the following message. The command that is used to remove the routes which Quagga/Zebra created is: ip route flush proto zebra > Stopping Quagga daemons (prio:0): (bgpd) (ospfd) (zebra) (ripd) (ripngd) > (ospf6d). > Remov