Sent to myself the first time.
> >
> >
> > @@ -1097,6 +1097,8 @@ void __init xfrm_state_init(void)
> > {
> > int i;
> >
> > + xfrm_state_bydst = (struct list_head *)
> > __get_free_pages(GFP_KERNEL, get_order(sizeof(struct list_head) *
> > XFRM_DST_HSIZE * 2));
> > + xfrm_state_byspi = &xfrm_state_bydst[XFRM_DST_HSIZE];
> > for (i=0; i<XFRM_DST_HSIZE; i++) {
> > INIT_LIST_HEAD(&xfrm_state_bydst[i]);
> > INIT_LIST_HEAD(&xfrm_state_byspi[i]);
> >
>
Embarassing, I could successfully add a bug in two lines of code :( I
was not checking whether get_free_pages was successful or not.
While checking if it'd be possible to propagate an error code back, I've
found that both xfrm_state_init and xfrm_init return void, thus no way
to return a suitable error code.
Is this tiny patchlet worth the trouble of changing
xfrm_init/xfrm_state_init to return int, and do error checking from
ip_rt_init() ?
--
Bazsi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
