So people don't think that I'm doing nothing but sleeping
today :-)
I gave a shot yesterday and today to kill this off, but it
really can't be done easily in one fell swoop, and there are
real issues to resolve.
So I'll work on this in stages. First I'll get rid of the
most trivial uses of skb-
From: Matt Mackall <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 19:36:37 -0700
> [sch added to cc: as I think he's the effective pktgen maintainer]
No, that would be Robert Olsson.
> Move in_aton from net/ipv4/utils.c to net/core/utils.c
Fair enough.
-
To unsubscribe from this list: send the line
[sch added to cc: as I think he's the effective pktgen maintainer]
On Tue, Jul 26, 2005 at 05:03:49PM -0700, David S. Miller wrote:
> From: Matt Mackall <[EMAIL PROTECTED]>
> Date: Tue, 26 Jul 2005 16:58:24 -0700
>
> > On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S. Miller wrote:
> > > More se
From: Harald Welte <[EMAIL PROTECTED]>
Date: Wed, 27 Jul 2005 01:52:23 +0200
> See attached file "12-queue-reroute.patch.2".
All patches applied to net-2.6.14, thanks Harald.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More maj
On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S. Miller wrote:
> From: Matt Mackall <[EMAIL PROTECTED]>
> Date: Tue, 26 Jul 2005 16:20:43 -0700
>
> > This problem also exists in PKTGEN. And this fix is incorrect as
> > neither is dependent on the IP part of the networking stack in any
> > substa
From: Matt Mackall <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 16:58:24 -0700
> On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S. Miller wrote:
> > More seriously, please submit a version of whatever you
> > believe to be the more correct fix so it can be reviewed
> > and integrated.
>
> Do you h
From: Harald Welte <[EMAIL PROTECTED]>
Date: Wed, 27 Jul 2005 01:52:23 +0200
> I'll also prepare a modified version of the nfnetlink module
> refcounting patch, but I'm not submitting it until you've applied ll
> of the other pending netfilter patches since they would conflict
> (re-attached the o
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 23 Jul 2005 16:15:52 -0400
> The attached patch adds support for refcounting of modules implementing
> netlink protocols. The idea is that you prevent the module from
> disappearing as long as someone in userspace has still a socket talking
> to y
From: Matt Mackall <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 16:20:43 -0700
> This problem also exists in PKTGEN. And this fix is incorrect as
> neither is dependent on the IP part of the networking stack in any
> substantive way. The right fix is to make inet_aton available outside
> of CONFIG_I
On Tue, Jul 19, 2005 at 02:01:04PM -0700, David S. Miller wrote:
> From: Adrian Bunk <[EMAIL PROTECTED]>
> Date: Tue, 19 Jul 2005 20:29:19 +0200
>
> > NETCONSOLE=y and INET=n results in the following compile error:
>
> Also applied, thanks Adrian.
I should have been cc:ed on this.
This problem
From: Harald Welte <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 18:45:05 +0200
> please apply. If you dislike the yet-another-NPROTO nature of it, I'll
> prepare one with kmalloc-at-startup.
Please do, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a mes
From: Harald Welte <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 17:20:53 +0200
> Rename skb_ip_make_writable() to skb_make_writable() since there is
> nothing IPv4-specific in it. In fact, it was already used by IPv6, too...
> Upcoming nfnetlink_queue code will use it for any kind of packet.
>
> S
From: Herbert Xu <[EMAIL PROTECTED]>
Subject: Re: [PATCH] possible overflow of sock->sk_policy
Date: Tue, 26 Jul 2005 13:07:14 +1000
> Balazs Scheidler <[EMAIL PROTECTED]> wrote:
> >
> > While reading through the xfrm code I've found a possible array overflow
> > in struct sock.
>
> Thanks for c
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 16:56:59 +0200
> The function is not inline.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied, thanks Adrian.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
M
Hi Dave,
please apply. If you dislike the yet-another-NPROTO nature of it, I'll
prepare one with kmalloc-at-startup.
--
- Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/
"Fragmentation is like
Hi Dave!
This patch fixes the pointer calculation made by the nf_info_reroute() macro.
Please apply on top of my other patches for net-2.6.14, thanks.
--
- Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/
Hi Dave!
This is the layer3 independent rewrite of ip[6]_queue on top of
nfnetlink. The patch is incremental to my latest 'move queue rerouting
to nf_queue level' and 'multiqueue' patches I sent earlier today.
Please apply to net-2.6.14,
Thanks.
--
- Harald Welte <[EMAIL PROTECTED]>
On Tue, Jul 26, 2005 at 10:09:19AM -0400, jamal wrote:
>
> > I think the answer is that it works by accident.
>
> But does it matter really? If say we close down the device,
> do we want to be stopped from closing it until all the packets have been
> transmitted? We purge the qdiscs iirc already
> > If you could, please try the latest driver off of sourceforge at
> > http://sf.net/projects/e1000, which will get us working off
> > of the same source base.
>
> I'm going to try the latest driver you mentioned and let you
> know what happens.
I checked out the latest driver as requested.
> Thanks for the patch, your problem is interesting, although why reseting
> the phy has anything to do with mtu > 1500 not working I don't know.
>
> Also, what adapter (lspci -n) what are steps to reproduce, etc.
lspci -n
:0f:07.0 Class 0200: 8086:1076 (rev 05)
:10:08.0 Class 0200: 8086:
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 10:09:19 -0400
> PS:- Dave, I think all this holding refcount thing on the input_dev is
> complicating things. Lets just use the ifindex and forget about
> refcounting; worst is we will end up failing some classification
> somewhere - which if
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 10:00:08 -0400
> As an example, if eth7 appeared again, greearb-snmp by looking at lspci
> can validate it is still the same device type, some serial number output
> etc; it can also determine it was exactly the same card as before even
That'
From: Harald Welte <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 04:39:36 -0400
> Ok, so the general rule should be to not have such statically BSS
> allocated arrays at all, but rather allocate them at runtime? I always
> thought it would be better to putt them in BSS. Netfilter has a number
> of
On Mon, 25 Jul 2005, Russell Johnson wrote:
I just upgraded my Dell 2800 from kernel 2.6.7 to 2.6.11 and noticed that
the e1000 driver doesn't work when I change the MTU from 1500 to something
larger. I traced the bug down to the following item in
e1000_main.c::e1000_up(). In a past life I reca
jamal wrote:
On Mon, 2005-25-07 at 16:25 -0700, Ben Greear wrote:
jamal wrote:
Why not easily? It should be pretty trivial to tell user space "the
ifindex you want is in use"; return -EEXIST
If you have to deal with finding a free ifindex, how does it help you?
If you are going to use
On Tue, Jul 26, 2005 at 04:24:02AM -0400, Harald Welte wrote:
> At the moment I'm mostly thinking about correcting those issues that I
> know off my head. Don't know whether I would find the time to
> systematically go through all of them..
Ok. Maybe someone else at netdev is interested.
>
> >
Hi Dave,
please apply to your net-2.6.14 tree:
--
- Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/
"Fragmentation is like classful addressing -- an interesting early
architectural error that
Hello!
> But how can this possibly work for skb->dst'less packets (such as IPV4
> ARP generated frames)?
Consider this as an implicit argument to functions passing skbs
(that's why skb->dev can be killed btw). Caller is obliged to hold
reference to the device, when doing dev_queue_xmit(). The way
The function is not inline.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.13-rc3-mm1-full/include/linux/netfilter_ipv4/ip_conntrack.h.old
2005-07-26 13:44:20.0 +0200
+++ linux-2.6.13-rc3-mm1-full/include/linux/netfilter_ipv4/ip_conntrack.h
2005-07-26 13:45:41.000
This patch gives the e1000 driver the ability to retreive the permanent
hardware address of its device, via the framework established in part 1
of this patch series. This patch fills in the new perm_addr field on
probing, and implements the get_perm_addr ethtool.
This patch has been tested in c
This patch addresses an issue in which hardware detection programs
cannot correctly identify network cards due to their mutable MAC
addresses stored in net_device struct. As an example, in a configuration
with NIC team/bond, the MAC addresses in the dev_addr in net_device
struct of the members of a
On Tue, 2005-26-07 at 21:54 +1000, Herbert Xu wrote:
> David S. Miller <[EMAIL PROTECTED]> wrote:
> >
> > But how can this possibly work for skb->dst'less packets (such as IPV4
> > ARP generated frames)?
>
> I think the answer is that it works by accident.
But does it matter really? If say we cl
On Mon, 2005-25-07 at 16:25 -0700, Ben Greear wrote:
> jamal wrote:
> I'm not suggesting to change current behaviour. I am suggesting that
> anyone who depends on ifindex for a primary key without checking the
> name is asking for trouble, since ifindex is transient with regard
> to device names.
On Mon, Jul 25, 2005 at 05:01:40PM -0700, John Ronciak wrote:
> At long last the software developers manual for the Intel PRO/1000
> Gigabit Ethernet controllers is now available on our Sourceforge web
> site. The URL is: http://sourceforge.net/projects/e1000
Incredible! I'm very happy to see at
David S. Miller <[EMAIL PROTECTED]> wrote:
>
> But how can this possibly work for skb->dst'less packets (such as IPV4
> ARP generated frames)?
I think the answer is that it works by accident.
Without preemption or weird netfilter targets that queue packets,
the packet will drop right through to
On Mon, Jul 25, 2005 at 11:33:51PM +0400, Evgeniy Polyakov wrote:
> Netlink is transport protocol - no need to add complexity into it,
> it must be as simple as possible and thus extensible.
yes. but when you run into a serious addressing shortage (like the
internet does with ipv4), you develop
On Sun, Jul 24, 2005 at 05:24:21PM +0200, Andi Kleen wrote:
> Basically somebody needs to go through the network code and make sure
> all the ioctls/socket options/cmsgs etc. are documented when they are
> stable enough. Also some of the manpages I originally never
> completely finished (like net
On Sun, Jul 24, 2005 at 10:23:21PM -0700, David S. Miller wrote:
> Hmmm, let me think about this.
Ok, I'm looking forward to your thoughts (which might already be in my
inbox, I just recovered from jetlag back to .de).
> > - nl_table statically allocated
>
> Please don't do that. Even though it
Jesse Brandeburg wrote:
On Thu, 21 Jul 2005, [EMAIL PROTECTED] wrote:
In 2.6.12 this changed to:
packets = gprc
dropped = mpc
fifo = mpc
missed = mpc
I think there still is a problem. Notice that /proc/net/dev
reports rx_dropped + rx_missed_errors for the drop column,
and so will be double co
39 matches
Mail list logo
