On Sun, Jul 24, 2005 at 10:23:21PM -0700, David S. Miller wrote:
> Hmmm, let me think about this.

Ok, I'm looking forward to your thoughts (which might already be in my
inbox, I just recovered from jetlag back to .de).

> > - nl_table statically allocated
> 
> Please don't do that.  Even though it's BSS space, it takes up
> critical kernel image area at run time, which is mapped using
> locked TLB entries on some platforms.  This is why I made it
> a pointer.

Ok, so the general rule should be to not have such statically BSS
allocated arrays at all, but rather allocate them at runtime?  I always
thought it would be better to putt them in BSS.  Netfilter has a number
of them sitting in kernel modules (such as the protocol helper array,
etc.)

-- 
- Harald Welte <[EMAIL PROTECTED]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Attachment: pgpCu2LD3VXO3.pgp
Description: PGP signature

Reply via email to