[INCOMPLETE PATCH]: killing skb->list

2005-07-07 Thread David S. Miller
I got inspired eariler today, and found that it seemed it might be easy to kill off the 'list' member of struct sk_buff without changing sk_buff_head at all. I got very far. Nearly every single piece of code was easy to change to pass in an explicit SKB list instead of skb->list to the SKB queue

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

2005-07-07 Thread Jeff Garzik
David S. Miller wrote: If you need a PIO to complete in a specific order, you have to read it back. If you need PIO operations to occur Correct. A PCI read is the only way to ensure that all the CPU/PCI bridge buffers are flushed to the device. Whenever Arjan and I complain about "PCI post

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

2005-07-07 Thread David S. Miller
From: "Raghavendra Koushik" <[EMAIL PROTECTED]> Date: Thu, 7 Jul 2005 18:06:19 -0700 > wmb() is to ensure ordered PIO writes. wmb() does no such thing. It only has influence on load and store instructions done by the local processor, it has no effect on what the PCI bus may do with PIO writes (i

RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

2005-07-07 Thread Raghavendra Koushik
> I thought that an mmiowb() was called for here (to order the PIO > writes above more cheaply than doing the readq()). I posted a > patch like this some time ago: > > http://marc.theaimsgroup.com/?l=linux-netdev&m=111508292028110&w=2 On an Altix machine I believe the readq was necessary to flu

Re: tg3 polling extension

2005-07-07 Thread David S. Miller
From: "Qinghua(Kevin) Ye" <[EMAIL PROTECTED]> Date: Thu, 7 Jul 2005 17:43:06 -0600 > So the tg3_tx() and tg3_start_xmit do not include any code of reprogramming > the hardware? Right, they just process the TX ring. > What kinds of code can be classifed to reprogramming the hardware? Should > the

Re: tg3 polling extension

2005-07-07 Thread Qinghua(Kevin) Ye
Thanks, David. Some questions are as following: > It depends, the locking changed significantly in the current > 2.6.13-rcX version of the driver. But before that: > > 1) ->hard_start_xmit() needs to hold the tx_lock with hard IRQs >disabled, as does tg3_tx(). It uses NETIF_F_LLTX locking,

Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

2005-07-07 Thread Arthur Kepner
On Thu, 7 Jul 2005 [EMAIL PROTECTED] wrote: > ... > 2. Removed unnecessary PIOs(read/write of tx_traffic_int and >rx_traffic_int) from interrupt handler and removed read of >general_int_status register from xmit routine. > .. > @@ -2891,6 +2869,8 @@ int s

Re: [patch 1/1] net: fix sparse warnings

2005-07-07 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 07 Jul 2005 23:30:26 +0200 > From: Victor Fusco <[EMAIL PROTECTED]> > > Fix the sparse warning "implicit cast to nocast type" > > Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsu

[PATCH 2/2] net: move config options out to individual protocols

2005-07-07 Thread Sam Ravnborg
Move the protocol specific config options out to the specific protocols. With this change net/Kconfig now starts to become readable and serve as a good basis for further re-structuring. The menu structure is left almost intact, except that indention is fixed in most cases. Most visible are the INE

[PATCH 1/2] net: add a top-level Networking menu to *config

2005-07-07 Thread Sam Ravnborg
Create a new top-level menu named "Networking" thus moving net related options and protocol selection way from the drivers menu and up on the top-level where they belong. To implement this all architectures has to source "net/Kconfig" before drivers/*/Kconfig in their Kconfig file. This change has

Re: [PATCH 0/2] Add Networking menu and clean up net/Kconfig

2005-07-07 Thread Sam Ravnborg
On Thu, Jul 07, 2005 at 02:10:50PM -0700, David S. Miller wrote: > From: Sam Ravnborg <[EMAIL PROTECTED]> > Date: Wed, 6 Jul 2005 23:06:53 +0200 > > > When (if) accepted I expect someone (Dave?) from netdev to push this > > onwards. > > I can't apply these patches because they will break several

Re: tg3 polling extension

2005-07-07 Thread David S. Miller
From: "Qinghua(Kevin) Ye" <[EMAIL PROTECTED]> Date: Thu, 7 Jul 2005 16:04:40 -0600 > I did some small test showing that polling can improve the packet processing > throughput a bit. I still need to do more tests. Could anyone give me some > information about the lock scheme of RX and TX precedure?

[patch 3/8] drivers/net/ne-h8300.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ne-h8300.c |5 +++

[patch 5/8] drivers/net/arm/etherh.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- etherh.c |3 ++-

[patch 4/8] net/ioc3-eth: Use the DMA_{32,64}BIT_MASK constants

2005-07-07 Thread domen
From: Tobias Klauser <[EMAIL PROTECTED]> Use the DMA_{32,64}BIT_MASK constants from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() This patch includes dma-mapping.h explicitly because patches caused errors on some architectures otherwise. See http://marc.theaimsgro

tg3 polling extension

2005-07-07 Thread Qinghua(Kevin) Ye
I did some small test showing that polling can improve the packet processing throughput a bit. I still need to do more tests. Could anyone give me some information about the lock scheme of RX and TX precedure? I would be very appreciate. Thanks. Qinghua - To unsubscribe from this list: send the

[patch 6/8] drivers/net/apne.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- apne.c |7 ---

[patch 7/8] drivers/net/ne.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ne.c |7 ---

[patch 8/8] drivers/net/zorro8390.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- zorro8390.c |7 ++

[patch 2/8] drivers/net/wireless/strip.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- strip.c |4 ++--

[patch 1/8] drivers/net/ne2.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. --- ne2.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) Index: quilt/drivers/net/ne2.c ==

[patch 1/1] net: fix sparse warnings

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 29 ++--- include/net/sock.h | 18 +

Re: [PATCH 0/2] Add Networking menu and clean up net/Kconfig

2005-07-07 Thread David S. Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Wed, 6 Jul 2005 23:06:53 +0200 > When (if) accepted I expect someone (Dave?) from netdev to push this > onwards. I can't apply these patches because they will break several platforms that don't use drivers/Kconfig, my workstation (sparc64) would be one

Re: [RFC/PATCH] "safer ipv4 reassembly" (fwd)

2005-07-07 Thread Arthur Kepner
Version 2 of the rfc/patch is attached. It has been changed as indicated in the commentary below. Diffstat: include/linux/sysctl.h |1 net/ipv4/ip_fragment.c | 195 + net/ipv4/sysctl_net_ipv4.c | 11 ++ Signed-off-by: Arthur Kepner <[EM

Re: [PATCH 1/2] LSM-IPSec Networking Hooks

2005-07-07 Thread Trent Jaeger
Yes, it looks like you are right. The easiest thing to do is authorize the socket's use of the flow_cache_entry's xfrm_policy object if it has a security context. Not really clean for following reasons: (1) The flow_cache_entry object is a void* -- although flow_cache_lookup only seems to b

Re: ieee80211 patches

2005-07-07 Thread Jiri Benc
On Thu, 7 Jul 2005 09:30:34 +1000, Mark Wallis wrote: > Should we be expecting to see these patches in the net-dev GIT repository > anytime soon ? We are basing our new Ralink driver off the ieee80211 common > stack but haven't seen any commits in there for awhile (even know patches > have been pos

Re: [PATCH 1/2] LSM-IPSec Networking Hooks

2005-07-07 Thread Herbert Xu
On Wed, Jul 06, 2005 at 04:24:53PM -0400, jaegert wrote: > > diff -puN net/core/flow.c~lsm-xfrm-nethooks net/core/flow.c > --- linux-2.6.12-git3-xfrm/net/core/flow.c~lsm-xfrm-nethooks 2005-06-21 > 15:56:40.0 -0400 > +++ linux-2.6.12-git3-xfrm-root/net/core/flow.c 2005-06-21 > 15:56

Re: [PATCH 1/2] LSM-IPSec Networking Hooks

2005-07-07 Thread Herbert Xu
On Thu, Jul 07, 2005 at 09:30:12AM +1000, herbert wrote: > > This might be a silly question as I probably don't understand this > fully. There seems to be an apparent asymmetry in the implementation. > The outbound packets are looked up with their originating socket, i.e., > for TCP packets it's