Re: Android checkstyle has landed

You can also install the checkstyle-idea plugin, which will highlight style errors, for local development. For an example and installation instructions, see: https://wiki.mozilla.org/Mobile/Fennec/Android/Static_analysis/checkstyle-idea - Mike On Wed, Apr 6, 2016 at 11:14 AM, Michael Comella < m

Re: Android checkstyle has landed

Checkstyle is slightly more useful: it'll now check for trailing whitespace! [1] If your reviewee has an any issues with this, ask them to run `./mach gradle checkstyle` locally rather than writing "nit:" on every instance. :) Slightly less useful: whitespace checks around Java generics operators

Re: Android checkstyle has landed

Important note regarding checkstyle in automation: to get the specific checkstyle failures, you have to click the failing test, click "Job Details", "Inspect task", and select the checkstyle artifact (e.g. [0]). Then you need to scroll through a large xml file to find your errors. Instead, if you

Re: Android checkstyle has landed

And now checkstyle is running in automation [1] – yay! It should run automatically when you change files that checkstyle looks at (e.g. *.java). - Mike (:mcomella) [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258787 On Mon, Apr 4, 2016 at 4:23 PM, Michael Comella wrote: > checkstyle appe

Re: Android checkstyle has landed

checkstyle appears to be sticking – happy style checking. - Mike (:mcomella) On Fri, Mar 25, 2016 at 1:55 PM, Michael Comella < michael.l.come...@gmail.com> wrote: > I forgot to include some dependencies so this had to be backed out. I'll > reply once it's landed *and* merged this time. :P > - Mi

Re: Android checkstyle has landed

Is there a bug to follow along with? - Mike On Mon, Mar 28, 2016 at 7:57 AM, Sylvestre Ledru wrote: > +Mark > > Having static analyzers, linters or coding style tools plugged in > mozreview is also a need identified by release management too. > Mark is aware of the need but I don't know what is

Re: Android checkstyle has landed

Can we work with the MozReview team to make this run automatically when you push a patch for review? The fewer manual steps that people need to remember to take, the better. Margaret On Fri, Mar 25, 2016 at 4:55 PM, Michael Comella < michael.l.come...@gmail.com> wrote: > I forgot to include some

Re: Android checkstyle has landed

I forgot to include some dependencies so this had to be backed out. I'll reply once it's landed *and* merged this time. :P - Mike On Fri, Mar 25, 2016 at 11:56 AM, Michael Comella < michael.l.come...@gmail.com> wrote: > Hey all. > > As you may have previewed from my static analysis email, I lande