checkstyle appears to be sticking – happy style checking. - Mike (:mcomella)
On Fri, Mar 25, 2016 at 1:55 PM, Michael Comella < michael.l.come...@gmail.com> wrote: > I forgot to include some dependencies so this had to be backed out. I'll > reply once it's landed *and* merged this time. :P > - Mike > > On Fri, Mar 25, 2016 at 11:56 AM, Michael Comella < > michael.l.come...@gmail.com> wrote: > >> Hey all. >> >> As you may have previewed from my static analysis email, I landed >> checkstyle in tree [1]. It catches various coding style issues. To run: >> >> ./mach gradle app:checkstyle >> >> My thinking here is that instead of typing `nit` for each style issue in >> review, we can just say `checkstyle` and ignore the remaining style issues. >> However, our current config [2] is minimal and won't help much: >> * Don't wrap `package .*` & `import .*` lines >> * Don't add tabs to files >> * Filename.java must contain a class Filename >> >> My highest priority checks to add are: >> * excess whitespace [3] >> * spacing around operators [4] (e.g. `1 + 1`) >> >> which I often find the need to nit for. >> >> For open issues, see the meta bug [5]. >> >> Note: this probably won't be really effective until we land in automation >> [6] and prevent regressions. >> - Mike (:mcomella) >> >> [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258769 >> [2]: Once this merges to m-c: >> http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/checkstyle.xml >> [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258794 >> [4]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258789 >> [5]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258786 >> [6]: https://bugzilla.mozilla.org/show_bug.cgi?id=1258787 >> > >
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
