Re: Proposal to drop custom logging framework on IOS

> > * Rolling file logger so the number of files on a disk don’t get huge and > the size of the logs stays small > * Separate files for different types of logs. Sync/Browser/Keychahin > Some additional context on this: Until now (or recently? perhaps someone fixed this) we only kept one browser l

Re: Proposal to drop custom logging framework on IOS

On Wed, Apr 13, 2016 at 8:31 AM, Farhan Patel wrote: > Here is what I was able to gather XCGLogger currently does > * Different log levels for different types of logs (errors/debug/warning) > * Rolling file logger so the number of files on a disk don’t get huge and > the size of the logs stays sm

Re: Proposal to drop custom logging framework on IOS

Here is what I was able to gather XCGLogger currently does * Different log levels for different types of logs (errors/debug/warning) * Rolling file logger so the number of files on a disk don’t get huge and the size of the logs stays small * Separate files for different types of logs. Sync/Browser/

Re: Proposal to drop custom logging framework on IOS

I can look into both the libraries and share my findings here. I dont think I have enough context yet to make the call on which one to switch to so I will leave that up to the rest of the team. On Tue, Apr 12, 2016 at 10:42 AM, Stefan Arentz wrote: > > > On Apr 12, 2016, at 10:35 AM, Farhan Pate

Re: Proposal to drop custom logging framework on IOS

> On Apr 12, 2016, at 10:35 AM, Farhan Patel wrote: > > I agree with Emily replacing our logging with a new framework might introduce > its own set of problems. But the underlying problems with XCGLogger are more difficult to fix: it uses NSFileHandle#write to write to its log files. And NSF

Re: Proposal to drop custom logging framework on IOS

I agree with Emily replacing our logging with a new framework might introduce its own set of problems. Maybe reducing the logging and moving the logging to a background thread (when in production) might help. It's really not directly fixing the problem but it could help. In the case of reducing th

Re: Proposal to drop custom logging framework on IOS

Cool now we have two choices for a better logging framework :-) Farhan, do you want to work on this? Lets decide which one is good for us and migrate to it? XCGLogger is currently in the top three of crashes, we would love to replace it with something that is better maintained and less buggy.

Re: Proposal to drop custom logging framework on IOS

I have also used, and recommend, CocoaLumberjack. I agree with Steph that losing the rolling file logger and log levels would be a bad thing. However, using any third party library is going to bring with it risk of things going wrong out of our control. My concern with the XCGLogger issues is tha

Re: Proposal to drop custom logging framework on IOS

There is also https://github.com/emaloney/CleanroomLogger which does a few optimizations to make sure performance in Production is good. It is also written in swift. We also still get different levels of logging. But it could also bring its own set of bugs. The thing with using nslog is that becaus

Re: Proposal to drop custom logging framework on IOS

> > What I am thinking now is this: we are having a lot of problems (crahses) > with XCGLogger. I’m thinkiing we should kill it completely. I agree. We seem to have crashes every release related to XCGLogger. Instead we will write logs with NSLog(), which is managed by the OS and can > be easily

Proposal to drop custom logging framework on IOS

I just found http://lemonjar.com/iosconsole/ which is a wonderful little tool that people can use to download both the console log and crash reports from their devices. What I am thinking now is this: we are having a lot of problems (crahses) with XCGLogger. I’