I can look into both the libraries and share my findings here. I dont think I have enough context yet to make the call on which one to switch to so I will leave that up to the rest of the team.
On Tue, Apr 12, 2016 at 10:42 AM, Stefan Arentz <sare...@mozilla.com> wrote: > > > On Apr 12, 2016, at 10:35 AM, Farhan Patel <fpa...@mozilla.com> wrote: > > > > I agree with Emily replacing our logging with a new framework might > introduce its own set of problems. > > But the underlying problems with XCGLogger are more difficult to fix: it > uses NSFileHandle#write to write to its log files. And NSFileHandle#write > has not been properly wrapped by Apple with Swift compatible exception > handling. On top of that, NSFileHandle is documented to raise exceptions if > the file handle goes bad. For whatever reason, and as a result we crash. > > XCGLogger is faulty by design. We crash when it cannot log. > > I think we should still swap it out with a logging framework that better > handles these failures. Or maybe better, does not depend on NSFileHandle at > all and instead for example uses iOS’ ASL library to do logging. > > I think it may be worth it to look at the code of the two suggested > alternatives and see if they are more robust. > > S. > >
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
