[android] PSA – please don't use double-curly brace initialization

2016-04-13 Thread Michael Comella
Hey android devs. Double-curly brace initialization has a couple of issues that particularly affect resource-constrained mobile devices: * Memory leaks: double-curly braces create an anonymous class that contains a reference to the containing class, which could prevent the potentially large cont

[android] Please read – checkstyle motivations and future

2016-04-13 Thread Michael Comella
Hey Android devs. I added checkstyle to save us time in review – no more typing `nit:` and no more added review passes to fix style. That being said, we can only save time if we use it! If you find yourself typing `nit:` in review, make sure the assignee has run checkstyle locally or checkstyle ha

Re: Proposal to drop custom logging framework on IOS

2016-04-13 Thread Richard Newman
> > * Rolling file logger so the number of files on a disk don’t get huge and > the size of the logs stays small > * Separate files for different types of logs. Sync/Browser/Keychahin > Some additional context on this: Until now (or recently? perhaps someone fixed this) we only kept one browser l

Re: Proposal to drop custom logging framework on IOS

2016-04-13 Thread Nicholas Alexander
On Wed, Apr 13, 2016 at 8:31 AM, Farhan Patel wrote: > Here is what I was able to gather XCGLogger currently does > * Different log levels for different types of logs (errors/debug/warning) > * Rolling file logger so the number of files on a disk don’t get huge and > the size of the logs stays sm

Re: Proposal to drop custom logging framework on IOS

2016-04-13 Thread Farhan Patel
Here is what I was able to gather XCGLogger currently does * Different log levels for different types of logs (errors/debug/warning) * Rolling file logger so the number of files on a disk don’t get huge and the size of the logs stays small * Separate files for different types of logs. Sync/Browser/

Re: Proposal to drop custom logging framework on IOS

2016-04-13 Thread Farhan Patel
I can look into both the libraries and share my findings here. I dont think I have enough context yet to make the call on which one to switch to so I will leave that up to the rest of the team. On Tue, Apr 12, 2016 at 10:42 AM, Stefan Arentz wrote: > > > On Apr 12, 2016, at 10:35 AM, Farhan Pate