Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Ozkan Sezer
On 9/12/12, Dongsheng Song wrote: > On Wed, Sep 12, 2012 at 9:57 PM, Ozkan Sezer wrote: >> >> I applied the v2.x patch at rev. 5396. Thanks. >> >> -- >> O.S. >> > > I saw you update revstamp.h too, which file generate revstamp.h ? > To my knowledge, absolutely nothing: only the auto-builds' scr

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Dongsheng Song
On Wed, Sep 12, 2012 at 9:57 PM, Ozkan Sezer wrote: > > I applied the v2.x patch at rev. 5396. Thanks. > > -- > O.S. > I saw you update revstamp.h too, which file generate revstamp.h ? I also saw jon_y applied to trunk at r5395 without update ChangeLog. Regards, Dongsheng

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Ozkan Sezer
On 9/12/12, Dongsheng Song wrote: > On Wed, Sep 12, 2012 at 8:50 PM, Dongsheng Song > wrote: >> On Wed, Sep 12, 2012 at 6:14 PM, Kai Tietz >> wrote: >>> Hello Dongsheng, >>> >>> patch looks ok. Just one nit I see. Within that patch also a change >>> to testsuite's make is made. For that a cha

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Earnie Boyd
On Wed, Sep 12, 2012 at 9:02 AM, Dongsheng Song wrote: > > Oh, My automake is 1.11.6, mingw-w64 use 1.12.2. please re-generate > Makefile.in yourself. > My preference is to not store the auto generated files in the repository and have the configuration set to ignore the generated files so the gene

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Dongsheng Song
On Wed, Sep 12, 2012 at 8:50 PM, Dongsheng Song wrote: > On Wed, Sep 12, 2012 at 6:14 PM, Kai Tietz wrote: >> Hello Dongsheng, >> >> patch looks ok. Just one nit I see. Within that patch also a change >> to testsuite's make is made. For that a changelog entry is missing. >> >> Regards, >> Kai

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Dongsheng Song
On Wed, Sep 12, 2012 at 6:14 PM, Kai Tietz wrote: > Hello Dongsheng, > > patch looks ok. Just one nit I see. Within that patch also a change > to testsuite's make is made. For that a changelog entry is missing. > > Regards, > Kai > I do not change testsuite, I only change Makefile.am, then run

Re: [Mingw-w64-public] Add VS2012 CRT support

2012-09-12 Thread Kai Tietz
Hello Dongsheng, patch looks ok. Just one nit I see. Within that patch also a change to testsuite's make is made. For that a changelog entry is missing. Regards, Kai 2012/9/12 Dongsheng Song : > On Wed, Sep 12, 2012 at 4:19 PM, Dongsheng Song > wrote: >> Hi all, >> >> These 2 attachments tr