Hello Dongsheng, patch looks ok. Just one nit I see. Within that patch also a change to testsuite's make is made. For that a changelog entry is missing.
Regards, Kai 2012/9/12 Dongsheng Song <dongsh...@users.sourceforge.net>: > On Wed, Sep 12, 2012 at 4:19 PM, Dongsheng Song > <dongsh...@users.sourceforge.net> wrote: >> Hi all, >> >> These 2 attachments try to add VS2012 CRT support to mingw-w64, >> all functions which implemented by mingw-w64 had been marked >> by data in msvcrt.def. Here is the summary: >> >> trunk stable/v2.x >> x86 88 53 >> x64 107 72 >> >> dongsheng@vc:~$ cat msvcr110_trunk.patch | diffstat >> ChangeLog | 5 >> Makefile.am | 2 >> Makefile.in | 1690 ++++++++++++++++++++++++++++++++++++++++++-- >> lib32/msvcr110.def | 2030 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> lib64/msvcr110.def | 1988 >> +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 5637 insertions(+), 78 deletions(-) >> >> dongsheng@vc:~$ cat msvcr110_v2.x.patch | diffstat >> ChangeLog | 5 >> Makefile.am | 2 >> Makefile.in | 431 ++++++----- >> lib32/msvcr110.def | 2030 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> lib64/msvcr110.def | 1988 >> +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 4269 insertions(+), 187 deletions(-) >> >> Regards, >> Dongsheng > >> Message body is too big: 608022 bytes with a limit of 120 KB > > re-send after compressed by gzip. > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Mingw-w64-public mailing list > Mingw-w64-public@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > -- | (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(") him gain world domination ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
