Hi André,
Patch is ok. please go ahead and apply.
Thanks,
Kai
2014-07-30 1:20 GMT+02:00 André Hentschel :
> Please review, i'll commit it, just need an OK.
> (Last time it was confirmed on IRC and is already pushed upstream)
>
> --
Please review, i'll commit it, just need an OK.
(Last time it was confirmed on IRC and is already pushed upstream)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 5d4e469..2c0d85e 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mingw-w64-crt/Makefile.am
@@ -224,7 +224,7 @@ src
Am 28.07.2014 um 03:44 schrieb JonY:
> On 7/27/2014 23:50, André Hentschel wrote:
>> Am 26.07.2014 um 01:54 schrieb JonY:
>>> On 7/26/2014 06:20, André Hentschel wrote:
+double log2(double x) +{ +return softmath_log(x) / softmath_log(2); +}
>>
>>> Any reason not to expand softmath_log(2) i
On 7/27/2014 23:50, André Hentschel wrote:
> Am 26.07.2014 um 01:54 schrieb JonY:
>> On 7/26/2014 06:20, André Hentschel wrote:
>>> +double log2(double x) +{ +return softmath_log(x) / softmath_log(2); +}
>
>> Any reason not to expand softmath_log(2) into a constant? Otherwise, it
>> looks OK.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 26.07.2014 um 01:54 schrieb JonY:
> On 7/26/2014 06:20, André Hentschel wrote:
>> +double log2(double x) +{ +return softmath_log(x) / softmath_log(2); +}
>
> Any reason not to expand softmath_log(2) into a constant? Otherwise, it looks
> OK.
>
On 7/26/2014 06:20, André Hentschel wrote:
> +double log2(double x)
> +{
> +return softmath_log(x) / softmath_log(2);
> +}
Any reason not to expand softmath_log(2) into a constant? Otherwise, it
looks OK.
signature.asc
Description: OpenPGP digital signature
Please review, i'll commit it, just need an OK.
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 175ecdd..5d4e469 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mingw-w64-crt/Makefile.am
@@ -220,18 +220,18 @@ src_libmingwex=\
gdtoa/strtopx.c gdtoa/sum.c gdtoa/ulp.c
