Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Christoph Reiter
On Mon, Dec 30, 2024 at 9:47 PM Jacek Caban wrote: > As I mentioned in the other thread, doxygen appears to tamper with the > register definition only for outdated flex versions. If that’s the case, > this might be an MSYS2 packaging issue. Are there other instances of > similar problems? Good ca

Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread LIU Hao
在 2024-12-31 04:46, Jacek Caban 写道: Assuming this is indeed a concern for mingw-w64, the patch seems fine to me. However, I’m not fully convinced it’s necessary, -Dregister= is a rather awful hack in general. As I mentioned in the other thread, doxygen appears to tamper with the register defini

Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Jacek Caban
On 30.12.2024 20:09, Jeremy Drake via Mingw-w64-public wrote: For example, doxygen defines `register` to shut up an error due to it being deprecated/removed in ISO C++ 17, but that causes issues with this construct, which is an extension and still supported. Fixes: f0044963d7ba ("headers: Use re

[Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Jeremy Drake via Mingw-w64-public
For example, doxygen defines `register` to shut up an error due to it being deprecated/removed in ISO C++ 17, but that causes issues with this construct, which is an extension and still supported. Fixes: f0044963d7ba ("headers: Use register variable for NtCurrentTeb implementation on aarch64.") -