On 30.12.2024 20:09, Jeremy Drake via Mingw-w64-public wrote:
For example, doxygen defines `register` to shut up an error due to it being deprecated/removed in ISO C++ 17, but that causes issues with this construct, which is an extension and still supported.Fixes: f0044963d7ba ("headers: Use register variable for NtCurrentTeb implementation on aarch64.") --- Is this OK, or does it need any other preprocessor checks before using push_macro/pop_macro? I grepped for other usages and it seems like this is how it's done...
Assuming this is indeed a concern for mingw-w64, the patch seems fine to me. However, I’m not fully convinced it’s necessary, -Dregister= is a rather awful hack in general.
As I mentioned in the other thread, doxygen appears to tamper with the register definition only for outdated flex versions. If that’s the case, this might be an MSYS2 packaging issue. Are there other instances of similar problems?
Thanks, Jacek _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
