Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix LTO compile warning for main and wmain functions

2025-07-19 Thread LIU Hao
ro or two parameters; `int main(int argc)` is not allowed. The `envp` parameter is an implementation-defined extension. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Ming

Re: [Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread LIU Hao
在 2025-7-19 21:54, Jacek Caban 写道: On 19.07.2025 15:47, LIU Hao wrote: +  struct _CRYPT_PROVIDER_DATA; +  struct _CRYPT_PROVIDER_SGNR; +  struct _CRYPT_PROVIDER_PRIVDATA; +  struct _CRYPT_PROVIDER_DEFUSAGE; We could also reorder declarations to define those structs earlier, but the patch

[Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread LIU Hao
ithout these forward declarations the typedefs declare new local types that are not the same type as those in file scope. Signed-off-by: LIU Hao --- mingw-w64-headers/include/wintrust.h | 5 + 1 file changed, 5 insertions(+) diff --git a/mingw-w64-headers/include/wintrust.h b/mingw-w64-headers/incl

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in wintrust.h

2025-07-19 Thread LIU Hao
/ce365d498794a5d19a5e4b959c4cc422e39f8257 Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/wintrust.h | 56 1 file changed, 56 insertions(+) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP

Re: [Mingw-w64-public] [PATCH] crt: Add link to _pei386_runtime_relocator GNU LD bug

2025-07-19 Thread LIU Hao
在 2025-7-19 05:30, Pali Rohár 写道: --- mingw-w64-crt/crt/pseudo-reloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] github: Stop running armv7 binaries

2025-07-16 Thread LIU Hao
quot; step, we just don't execute them any more. Signed-off-by: Martin Storsjö --- .github/workflows/build.yml | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) This change looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP di

Re: [Mingw-w64-public] no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-15 Thread LIU Hao
在 2025-7-16 04:39, Pali Rohár 写道: The change should be applied also to v11.x, v12.x and v13.x branches as it is fixing the already applied commit. It's done now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital sign

Re: [Mingw-w64-public] [PATCH] crt: Check for compiler support for `no_stack_protector`

2025-07-15 Thread LIU Hao
在 2025-7-15 17:00, Martin Storsjö 写道: On Tue, 15 Jul 2025, LIU Hao wrote: -- Thanks, this looks reasonable to me (although I haven't tested it myself). Thanks. Pushed now, with the message amended a little. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP di

Re: [Mingw-w64-public] [PATCH] crt/ssp: Fix typo in function name RtlGenRandom

2025-07-14 Thread LIU Hao
, and falls back on - // using RtlRandomGen if not available. + // using RtlGenRandom if not available. if (rand_s(&ui) == 0) { __stack_chk_guard = (void*)(intptr_t)ui; #if __SIZEOF_POINTER__ > 4 Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc

[Mingw-w64-public] [PATCH] crt: Check for compiler support for `no_stack_protector`

2025-07-14 Thread LIU Hao
-- Best regards, LIU Hao From bf179ba7bde94cfed5ade73757523a887a8e4c5b Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Tue, 15 Jul 2025 10:32:42 +0800 Subject: [PATCH] crt: Check for compiler support for `no_stack_protector` This commit contains two changes: 1. `no_stack_protector` is applied

Re: [Mingw-w64-public] New implementation for C95 conversion functions

2025-07-13 Thread LIU Hao
checking `__MSVCRT_VERSION__ >= 0x0800` is incorrect? It is not incorrect, and I don't see such an error: UCRT64 ~/Desktop $ gcc 'D:\lh_mouse\GitHub\mingw-w64\mingw-w64-crt\testcases\t_wcsrtombs.c' ; ./a.exe ; echo $? 77 -- Best regards, LIU Hao OpenPGP_signatu

Re: [Mingw-w64-public] no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-13 Thread LIU Hao
amp; __GNUC__ >= 11) || (defined __clang__ && __clang_major__ >= 7) +__attribute__((__no_stack_protector__)) +# else +# error This file can't be built with stack protector enabled. Remove \ + -fstack-protector* options from CFLAGS. +# endif +#endif +__attribute__((__constructor_

Re: [Mingw-w64-public] no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-13 Thread LIU Hao
z 在 2025-7-13 21:43, Pali Rohár 写道: On Sunday 13 July 2025 21:35:23 LIU Hao wrote: 在 2025-7-13 21:25, Pali Rohár 写道: And throws warning: ‘no_stack_protector’ attribute directive ignored [-Wattributes] If I understand correctly the code at 3d-4c is the stack protection check, which should

Re: [Mingw-w64-public] no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-13 Thread LIU Hao
GCC 8 and with `-fstack-protector` will still cause crashes. One possible workaround is to introduce a specific Makefile recipe for 'stack_chk_guard.c' which doesn't use `CFLAGS`. However as said above, just don't build the CRT with stack protector. -- Best regards, L

Re: [Mingw-w64-public] no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-13 Thread LIU Hao
are defined in 'C:\MSYS64\etc\makepkg_mingw.d\${MSYSTEM}.conf', and in CFLAGS there's `-fstack-protector-strong`. Those flags are disabled with `!buildflags` in PKGBUILD when building the CRT. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP di

[Mingw-w64-public] [SPAM] Re: no_stack_protector attribute directive is ignored in file stack_chk_guard.c

2025-07-13 Thread LIU Hao
build does nothing. The attribute is available in GCC 11+ and Clang 7+. GCC 8 doesn't support the attribute. The warning is harmless and can be ignored. It's only an issue if someone has `-fstack-protector` in their CFLAGS. -- Best regards, LIU Hao OpenPGP_signature.asc Descript

Re: [Mingw-w64-public] New implementation for C95 conversion functions

2025-07-13 Thread LIU Hao
CRT, maybe checking __MSVCRT_VERSION__ would be better? It doesn't matter; _mingw.h defines `_UCRT` if `__MSVCRT_VERSION__` is defined to 0xE00. The difference is that MSVC also defines `_UCRT`. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP di

Re: [Mingw-w64-public] R: Provide definition of math_errhandling

2025-07-12 Thread LIU Hao
在 2025-7-9 10:19, LIU Hao 写道: 在 2025-7-8 21:08, Luca Bacci 写道: Thanks for the fast response! I have now included the updated patch I think you dropped `MATH_ERRNO` and `MATH_ERREXCEPT` in this patch? I have pushed a combination of the two patches. -- Best regards, LIU Hao

Re: [Mingw-w64-public] New implementation for C95 conversion functions

2025-07-12 Thread LIU Hao
the default input charset of GCC is UTF-8, they are probably fine. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] R: Provide definition of math_errhandling

2025-07-08 Thread LIU Hao
在 2025-7-8 21:08, Luca Bacci 写道: Thanks for the fast response! I have now included the updated patch I think you dropped `MATH_ERRNO` and `MATH_ERREXCEPT` in this patch? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] Provide definition of math_errhandling

2025-07-07 Thread LIU Hao
nyway, thank goodness, they are. [1] https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#index-ffast-math [2] https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital sign

Re: [Mingw-w64-public] [PATCH] crt/ssp: disable premature stack protection at canary init

2025-07-06 Thread LIU Hao
在 2025-7-7 03:43, Igor Kostenko 写道: Hi LIU Hao, Is it worth backporting this patch to the prior versions? The file was introduced by the commit 10394c9a966f8e93e9e2f09677dab273a0f6c00c on Sep 13 2022, and since then appeared in branches: > git branch -r  --conta

Re: [Mingw-w64-public] New implementation for C95 conversion functions

2025-07-06 Thread LIU Hao
es in libcxx: https://github.com/lhmouse/mingw-w64/actions/runs/16097282035/job/45424615804#step:7:14008 -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-p

Re: [Mingw-w64-public] [PATCH] crt/ssp: disable premature stack protection at canary init

2025-07-05 Thread LIU Hao
the patch. Pushed to master now. Next time, please do attach a copy of the patch as plaintext. I had to copy this one from the mail, as it was in the middle of a message. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt/ssp: disable premature stack protection at canary init

2025-07-03 Thread LIU Hao
fine to leave out a check. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Return value of mbrtowc

2025-07-03 Thread LIU Hao
ide to provide replacements for broken Microsoft ones, which then nobody will use, there's probably little worth in doing that. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mi

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-06-28 Thread LIU Hao
a change either. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Return value of mbrtowc

2025-06-26 Thread LIU Hao
`ptrdiff_t`) is greater than n. [1] https://pubs.opengroup.org/onlinepubs/9799919799.2024edition/functions/mbrtowc.html -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.

Re: [Mingw-w64-public] [PATCH v2] crt: testcases: Avoid compiler optimization of the null pointer write

2025-06-25 Thread LIU Hao
file changed, 2 insertions(+), 2 deletions(-) This change Looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH 2/2] crt: testcases: Use stdlib.h for the declaration of _sys_errlist

2025-06-25 Thread LIU Hao
在 2025-6-25 04:31, Martin Storsjö 写道: From: Pali Rohár This fixes linking this test with UCRT. Signed-off-by: Martin Storsjö --- mingw-w64-crt/testcases/tstmain_sys_xxx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) These look good to me, too. -- Best regards, LIU Hao

Re: [Mingw-w64-public] [PATCH] crt: Read the right st_mode field for __mingw_fix_stat_finish

2025-06-25 Thread LIU Hao
dio/msvcr110pre_stat64i32.c | 2 +- mingw-w64-crt/stdio/msvcr110pre_wstat32.c| 2 +- mingw-w64-crt/stdio/msvcr110pre_wstat64i32.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) This patch looks good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digi

Re: [Mingw-w64-public] [PATCH 4/9] crt: Fix support for mingw_pformat %c and %s in wide wprintf

2025-06-25 Thread LIU Hao
st regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] github: Use gcc, not g++, for test building a C test program

2025-06-25 Thread LIU Hao
./crt-test.exe LGTM. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 3/3] crt: testcases: Waive issues with t_aligned_alloc on aarch64

2025-06-25 Thread LIU Hao
1 and Windows 11 rev 22000 and 22631. */ +#define BROKEN_REALLOC_SHRINK 1 +#else +#define BROKEN_REALLOC_SHRINK 0 +#endif +#endif + -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing l

Re: [Mingw-w64-public] [PATCH 2/3] crt: testcases: Use a volatile pointer for null pointer writes in t_nullptrexception

2025-06-25 Thread LIU Hao
uot; : "+m"(p)); // pretend `p` is being modified If we insist on use of `volatile` I'd expect the pointer itself is volatile: char * volatile p = NULL; -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH 2/2] crt: testcases: Remove a "throw (int)"

2025-06-24 Thread LIU Hao
) | ^~~ Signed-off-by: Martin Storsjö --- mingw-w64-crt/testcases/t_trycatch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) These look good to me, too. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] Missing Microsoft printf behavior in mingw_pformat.c and OutOfBound in emu__vscwprintf()

2025-06-23 Thread LIU Hao
receive a PR for? (I would not change the behavior if __BUILD_WIDEAPI_ISO is defined) Of course. Please attach a patch at your leisure. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public ma

Re: [Mingw-w64-public] winpthreads: fix compiling C++ modules

2025-06-22 Thread LIU Hao
在 2025-6-22 03:15, Kirill Makurin 写道: This should fix error when compiling C++ modules[1]. - Kirill Makurin [1] https://github.com/mingw-w64/mingw-w64/issues/99 Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH v2 00/13] Fix stat functions

2025-06-20 Thread LIU Hao
ARM64 it may be ARM64 or ARM64X. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH v2 00/13] Fix stat functions

2025-06-20 Thread LIU Hao
taken care of? - Kirill Makurin 32-bit MSVCRT does not support 64-bit `time_t`; the support was added in Visual Studio 2005 i.e. MSVCR80. 64-bit MSVCR* and UCRT do not support 32-bit `time_t`. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] headers: Add PF_MOVDIR64B_INSTRUCTION_AVAILABLE

2025-06-19 Thread LIU Hao
gards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] github: Use "check-runtimes" rather than individual "check-cxx" for test-libcxx

2025-06-19 Thread LIU Hao
-time-tests" ninja - ninja check-cxx check-cxxabi check-unwind + ninja check-runtimes linux-test-cross-build-ffmpeg: needs: [llvm-mingw] LGTM, too. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] Fix header paths

2025-06-19 Thread LIU Hao
the new lines seem to have been scrambled. I fixed it locally and pushed. Thanks for the patch. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-14 Thread LIU Hao
gument, so I think this if (cp == 0) return (unsigned) c <= 0xFF ? c : WEOF; is being skeptical. What if we blindly truncate `c`, just like the code beneath it: if (cp == 0) return (unsigned char) c; -- Best regards, LIU Hao OpenPGP_signature.

Re: [Mingw-w64-public] winpthreads: do not expose IN_WINPTHREAD in public header files

2025-06-11 Thread LIU Hao
ads'. There is also a problematic interaction between pthread_compat.h and autoconf's AC_TYPE_PID_T. With MSVC, this check will fail and it will It is an unfortunate mistake. If VC defines `pid_t` then the VC definition should be preferred. -- Best regards, LIU Hao OpenPGP_

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-07 Thread LIU Hao
nction doesn't fail for characters in [128,255]. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-07 Thread LIU Hao
be added to `src_msvcrt_common` and `src_ucrtbase`. Individual MSVCR* libraries may have them in sources, which is no longer necessary. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Min

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-06 Thread LIU Hao
c54d8f32b3f14c69074892e2718eac08e3b is a good reference. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-06 Thread LIU Hao
n 1; Western European (ISO) -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-04 Thread LIU Hao
/master <https://sourceware.org/git/? p=glibc.git;a=history;f=wcsmbs/btowc.c;h=7be040ff6688d31da585d9075bdee54d231550d1;hb=refs/heads/master> I think it should be ok for replacement's behavior to match CRT. I agree with that. -- Best regards, LIU Hao OpenPGP_signature.asc Descripti

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread LIU Hao
在 2025-6-3 23:46, Kirill Makurin 写道: You are right. `libtool --mode=execute` is no longer needed. I forgot that libtool creates wrapper executables which handle search path. I attached update patch. Thanks for the patch. Looks good to me. Pushed now. -- Best regards, LIU Hao

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread LIU Hao
will prevent libtool from linking against an installed winpthread library. I suggest you rephrase. `-l` is for linking against a preinstalled library. Libraries that are to be built should almost always be linked in LDADD. -- Best regards, LIU Hao OpenPGP_signature.asc Description

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread LIU Hao
the rationale about the glibc change, I think it's fine to adopt the POSIX behavior. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread LIU Hao
` with a custom implementation in 'mingw-w64-crt/misc/btowc.c'. I think you may try calling the genuine MSVCRT one, which is returned by `GetProcAddress()`. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-02 Thread LIU Hao
P_UTF8. If anyone can test on system where this is not the case, this would be helpful. This made me wonder how mingw-w64 implements replacement for msvcr*.dll which do not have it: It passes return value of ` ___lc_codepage_func()` directly to `MultiByteToWideChar`. Maybe it's necessary t

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-02 Thread LIU Hao
good reason to apply `*_LDADD = $(top_builddir)/libwinpthread.la` to every test program; however instead of doing that for each target, it's possible to apply it globally by default: LIBADD = $(top_builddir)/libwinpthread.la can you try that? -- Best regards, LIU Hao OpenPGP_sig

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-31 Thread LIU Hao
commenting out the symbol. It is a normal keyword when building a DLL; I don't see why it's not supported. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing l

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-31 Thread LIU Hao
DllDebugObjectRPCHook', ]; ``` There are also symbols that are apparently not to be imported, such as `DllRegisterServerEx{A,W,}`, and all names that begin with `IID_` or `LIBID_`. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] headers: Add WSACMSGHDR related symbols in mswsock.h

2025-05-26 Thread LIU Hao
/v2025.05.26.00/folly/io/async/AsyncUDPSocket.cpp#L67 Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/mswsock.h | 17 + 1 file changed, 17 insertions(+) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP

Re: [Mingw-w64-public] [PATCH] crt: Make .CRT section read only

2025-05-25 Thread LIU Hao
w-w64-crt/include/sect_attribs.h | 93 +---  1 file changed, 43 insertions(+), 50 deletions(-) Thanks for the patch. Looks good to me. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital sign

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread LIU Hao
erate DEF files from Windows SDK LIBs then we need no such checking. And today, whoever wants to do that really doesn't have to install Windows: On GitHub actions there are now images (including Windows on ARM!) with preinstalled development resources. The process can be made automatic.

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-24 Thread LIU Hao
在 2025-5-24 18:29, Pali Rohár 写道: On Saturday 24 May 2025 18:25:35 LIU Hao wrote: 在 2025-5-24 18:12, Pali Rohár 写道: And it deduplicated 496 def files. What do you think about it? Just a robotic change and can decrease number of def files which needs to be maintained. I don't have a spe

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-24 Thread LIU Hao
es of inconsistency is largely unpractical. I'd prefer we generate DEFs from LIBs from Windows SDK and blindly accept the divergence. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-p

Re: [Mingw-w64-public] [PATCH] crt: Add new APIs in lib32/odbc32.def

2025-05-23 Thread LIU Hao
| 4 1 file changed, 4 insertions(+) Thanks for the patch. Pushed to master too, -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in sql.h

2025-05-23 Thread LIU Hao
/nanodbc.cpp#L932 Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/sql.h | 19 +++ 1 file changed, 19 insertions(+) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

[Mingw-w64-public] Generating DEF files from import libs from Windows SDK

2025-05-22 Thread LIU Hao
-defs -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt: Regenerate oleacc.def from Windows 11 DLL

2025-05-17 Thread LIU Hao
在 2025-5-17 19:02, Jacek Caban via Mingw-w64-public 写道: On 17.05.2025 12:15, LIU Hao wrote: Private exports are commented out. Signed-off-by: LIU Hao ---  mingw-w64-crt/lib-common/oleacc.def | 15 ++-  mingw-w64-crt/lib32/oleacc.def  | 15 ++-  2 files changed, 20

[Mingw-w64-public] [PATCH] crt: Regenerate oleacc.def from Windows 11 DLL

2025-05-17 Thread LIU Hao
Private exports are commented out. Signed-off-by: LIU Hao --- mingw-w64-crt/lib-common/oleacc.def | 15 ++- mingw-w64-crt/lib32/oleacc.def | 15 ++- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/mingw-w64-crt/lib-common/oleacc.def b/mingw-w64

Re: [Mingw-w64-public] [PATCH] winpthreads: Ensure `struct _timespec{32, 64}` are defined before use

2025-05-16 Thread LIU Hao
在 2025-5-16 16:21, Martin Storsjö 写道: LGTM Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] winpthreads: Replace K&R declarations with ISO ones

2025-05-16 Thread LIU Hao
在 2025-5-16 16:22, Martin Storsjö 写道: On Thu, 8 May 2025, LIU Hao wrote: diff --git a/mingw-w64-libraries/winpthreads/src/libgcc/dll_math.c b/mingw-w64-libraries/winpthreads/ src/libgcc/dll_math.c index 77bb1fea3..fe2ae36f8 100644 --- a/mingw-w64-libraries/winpthreads/src/libgcc/dll_math.c

Re: [Mingw-w64-public] [PATCH] winpthreads: Replace K&R declarations with ISO ones

2025-05-16 Thread LIU Hao
在 2025-5-8 21:57, LIU Hao 写道: From 4d36a88ac4ce2de382bb198ee5b788c6b51777fd Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Thu, 8 May 2025 21:55:36 +0800 Subject: [PATCH] winpthreads: Replace K&R declarations with ISO ones Signed-off-by: LIU Hao --- .../winpthreads/src/libgcc/dll_ma

[Mingw-w64-public] [PATCH] winpthreads: Ensure `struct _timespec{32, 64}` are defined before use

2025-05-16 Thread LIU Hao
^ We include so those function declarations reference the global types and do not declare their own. Reported-by: Jeremy Lainé Signed-off-by: LIU Hao --- mingw-w64-libraries/winpthreads/include/pthread_time.h | 1 + mingw-w64-libraries/winpthreads/include/semaphore.h| 1 + 2 files changed,

Re: [Mingw-w64-public] [PATCH 1/9] crt: exe: Enable per-thread locale if user asked for it

2025-05-14 Thread LIU Hao
t;? I don't mind that change, as long as it matches MSVC behavior. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourc

Re: [Mingw-w64-public] [PATCH 1/9] crt: exe: Enable per-thread locale if user asked for it

2025-05-14 Thread LIU Hao
ave an opinion from LH and Jacek on this one? // Martin -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Always correctly #define NULL __null if available, like stddef.h

2025-05-09 Thread LIU Hao
在 2025-5-9 22:24, наб 写道: On Fri, May 09, 2025 at 10:31:38AM +0800, LIU Hao wrote: 在 2025-5-4 22:24, наб 写道: In C++ it's common to have `NULL` defined as `0`. This is not the case. I think I was a little overzealous to say that "C++11 <=> NULL=nullptr" (both C and C++ al

Re: [Mingw-w64-public] [PATCH] headers: Import httprequest.idl from wine

2025-05-09 Thread LIU Hao
| 1 + mingw-w64-headers/Makefile.am| 1 + mingw-w64-headers/wine-import.sh | 1 + 3 files changed, 3 insertions(+) Thanks for the patch. Pushed to master now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Always correctly #define NULL __null if available, like stddef.h

2025-05-08 Thread LIU Hao
llptr); static auto z = f("a", "b", 0); #define NULL 123 in C++11 and later, NULL=nullptr so N/n are valid, and z is wrong. In C++ it's common to have `NULL` defined as `0`. Your code should not assume `NULL` is an expression whose size is a pointer. -- Best regards, LIU H

Re: [Mingw-w64-public] [PATCH 5/7] crt: Add __mingw_filename_cp()

2025-05-08 Thread LIU Hao
ed in inline functions, without having to be declared it everywhere else. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

[Mingw-w64-public] [PATCH] winpthreads: Replace K&R declarations with ISO ones

2025-05-08 Thread LIU Hao
a, quad_t b, quad_t *rem) { u_quad_t ua, ub, uq, ur; int negq, negr; -- 2.49.0 -- Best regards, LIU Hao From 4d36a88ac4ce2de382bb198ee5b788c6b51777fd Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Thu, 8 May 2025 21:55:36 +0800 Subject: [PATCH] winpthreads: Replace K&a

Re: [Mingw-w64-public] [V2] winpthreads: add support for _USE_32BIT_TIME_T and _TIME_BITS macros

2025-05-08 Thread LIU Hao
在 2025-4-22 16:16, Kirill Makurin 写道: This is the updated patch series. Some patches have been reordered and new patches have been added. Some patches have been updated. I think this series of patches are safe for now. Applied and pushed to master. Thanks for the work. -- Best regards, LIU

Re: [Mingw-w64-public] [PATCH] crt: Add new symbols in ole32 import library

2025-05-07 Thread LIU Hao
Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/lib-common/ole32.def.in | 3 +++ mingw-w64-crt/lib32/ole32.def | 28 +++ 2 files changed, 31 insertions(+) Thanks for the patch. Pushed. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP

Re: [Mingw-w64-public] [PATCH 2/2] headers: Add new constants in sqlext.h

2025-05-05 Thread LIU Hao
Fixeshttps://github.com/mingw-w64/mingw-w64/issues/93 Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/sqlext.h | 77 +- 1 file changed, 75 insertions(+), 2 deletions(-) Thanks for these patches. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc

Re: [Mingw-w64-public] [PATCH 5/5] github: Run test-libcxx on arm too

2025-05-03 Thread LIU Hao
gets passed as --target= parameter when running the tests.) Only the check-cxx testsuite currently passes on ARM; there are a couple things missing for making all unwind testcases pass ^~~ a couple _of_ things Other than that, these patches all look good to me. -- Best regards

Re: [Mingw-w64-public] [PATCH] headers: Add the DISPATCHER_CONTEXT_NONVOLREG_ARM64 data type

2025-05-03 Thread LIU Hao
x27;s really needed, we have a lot of cases where it's missing anyway. This patch looks good to me on its own. `__C89_NAMELESS` seems to expand to `__extension__`. We can add all missing specifiers in a separate patch. -- Best regards, LIU Hao OpenPGP_signature.asc Descriptio

Re: [Mingw-w64-public] [PATCH] headers: Add IsUserCetAvailableInEnvironment in sysinfoapi.h

2025-04-26 Thread LIU Hao
-dev/commit/cc73dd0338135e9fee7adddb9981515c8e3714ca Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/sysinfoapi.h | 10 ++ 1 file changed, 10 insertions(+) Thanks for the patch. Pushed now . -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH 2/2] winpthreads: Move SEH handler declaration to end of function

2025-04-24 Thread LIU Hao
consider this separately? I'm okay with that. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/lis

Re: [Mingw-w64-public] [PATCH 2/2] winpthreads: Move SEH handler declaration to end of function

2025-04-24 Thread LIU Hao
tionContinueSearch; if(pExceptionRecord->ExceptionFlags & EXCEPTION_NONCONTINUABLE) return ExceptionContinueSearch; return ExceptionContinueExecution; } ``` -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] crt: Move quartz to lib-common

2025-04-24 Thread LIU Hao
mon}/quartz.def | 0 mingw-w64-crt/libarm32/Makefile.am | 1 + mingw-w64-crt/libarm64/Makefile.am | 1 + 3 files changed, 2 insertions(+) rename mingw-w64-crt/{lib64 => lib-common}/quartz.def (100%) Thanks for the patch. Pushed now. -- Best regards, L

Re: [Mingw-w64-public] [PATCH] github: use new public preview windows-11-arm runner

2025-04-20 Thread LIU Hao
ot; ;; *) echo "not arm64" ;; esac ``` -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] winpthreads: add support for _USE_32BIT_TIME_T and _TIME_BITS macros

2025-04-20 Thread LIU Hao
在 2025-4-20 01:28, Kirill Makurin 写道: Please let me know if patches in 0005.txt and 0006.txt are ok. I would like to reorder them before large changes. Those look good to me. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] winpthreads: add support for _USE_32BIT_TIME_T and _TIME_BITS macros

2025-04-19 Thread LIU Hao
ons/clock_gettime.html The clock_gettime() function shall fail if: [EOVERFLOW] The number of seconds will not fit in an object of type time_t. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64

Re: [Mingw-w64-public] winpthreads: add support for _USE_32BIT_TIME_T and _TIME_BITS macros

2025-04-19 Thread LIU Hao
the static library), so it is not very useful. Can it be removed? I would like to move definition of `WIN32_LEAN_AND_MEAN` from Makefile.am to source files (just before `#include `. Yes it makes sense. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital

Re: [Mingw-w64-public] [PATCH] winpthreads: check if __GNUC__ is defined to prevent -Wundef warning

2025-04-19 Thread LIU Hao
在 2025-4-17 14:53, Antonin Décimo 写道: --- mingw-w64-libraries/winpthreads/src/thread.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] github: use new public preview windows-11-arm runner

2025-04-16 Thread LIU Hao
.exe ;; + ${{ runner.arch == 'ARM64' && '*' || '*86*' }}) ./$name-regular.exe ; ./$name-crt-first.exe ;; esac done done Windows 11 24H2 can no longer run 32-bit ARM programs. I think we shouldn'

Re: [Mingw-w64-public] [PATCH] github: Add an optional set of smoke tests for github actions

2025-04-11 Thread LIU Hao
在 2025-4-11 15:59, Martin Storsjö 写道: On Wed, 9 Apr 2025, Jacek Caban wrote: LGTM. I think it's a good idea to include it. I've been using it for a while, and it's proven very useful. Thanks! If nobody minds this, I'll go ahead and merge this soon. LGTM, too. -- B

Re: [Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-04-07 Thread LIU Hao
在 2025-4-7 16:32, Jacek Caban 写道: Looks good to me. Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https

Re: [Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-04-06 Thread LIU Hao
在 2025-3-31 21:23, LIU Hao 写道: These macros are to be used with `fesetenv()`, so they belong there. Having these `selectany` variables in 'fenv.h' causes them to be defined with external linkage in every source file which includes 'fenv.h'. They can also be exported inappr

Re: [Mingw-w64-public] libgcc_s_seh-1.dll and libwinpthread-1.dll, gcc 12.1.0

2025-04-05 Thread LIU Hao
of all of this is necessary for building an SEH only exception handler. SEH doesn't require TLS (but SJLJ does). If dependency on winpthread is undesired, you may build the win32 thread model. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital sign

[Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-03-31 Thread LIU Hao
either is built with `--export-all-symbols`, or does not contain explicit `dllexport` and is not built with a DEF file. Signed-off-by: LIU Hao --- mingw-w64-crt/misc/fesetenv.c | 16 mingw-w64-headers/crt/fenv.h | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff -

Re: [Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-03-30 Thread LIU Hao
在 2025-3-30 23:41, Jacek Caban 写道: On 29.03.2025 20:53, Martin Storsjö wrote: On Sun, 30 Mar 2025, LIU Hao wrote: This eliminates such warnings in C:    .../mingw-w64-headers/crt/fenv.h:64:39: warning: ‘__mingw_fe_dfl_env’ initialized and declared ‘extern’     extern const

  1   2   3   4   5   6   7   8   9   10   >