在 2025-7-13 05:45, Kirill Makurin 写道:
```
The new testcases don't build in UCRT mode - see
https://github.com/mstorsjo/mingw-w64/actions/runs/16238894867/job/45852642223#step:5:4386
```

Right... I forgot that UCRT's mbstate_t is a structure when was writing the 
tests initially. I noticed and fixed this issue in my project (from which I 
based both implementation and tests), but forgot to mirror the fix in sent 
patches.

I attached a patch which should fix it.

Thanks for the fix. The patch looks good to me. Pushed now.


I am only unsure whether it is OK to check for _UCRT, maybe checking 
__MSVCRT_VERSION__ would be better?

It doesn't matter; _mingw.h defines `_UCRT` if `__MSVCRT_VERSION__` is defined to 0xE00. The difference is that MSVC also defines `_UCRT`.



--
Best regards,
LIU Hao

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to