Re: [Mingw-w64-public] [PATCH] headers: make Mingw-w64 pass -Wstrict-prototypes.

2020-04-16 Thread Jehan Pagès
Hi! On Thu, Apr 16, 2020 at 4:14 PM Liu Hao wrote: > 在 2020/4/15 22:03, Jehan Pagès 写道: > > Hi! > > > > > > > > Ok well I have also reported a patch upstream to json-c to disable this > > warning/error when building for Windows: > > https://github.c

Re: [Mingw-w64-public] [PATCH] headers: make Mingw-w64 pass -Wstrict-prototypes.

2020-04-15 Thread Jehan Pagès
Hi! On Wed, Apr 15, 2020 at 3:48 PM Liu Hao wrote: > 在 2020/4/15 20:48, Jehan Pagès 写道: > > > > Sorry I was not clear. These patches were complementary, not a > > replacement (I should have merged both of them into one or amended the > > first one, but once again g

Re: [Mingw-w64-public] [PATCH] headers: make Mingw-w64 pass -Wstrict-prototypes.

2020-04-15 Thread Jehan Pagès
Hi! On Wed, Apr 15, 2020 at 2:11 PM Liu Hao wrote: > 在 2020/4/15 20:02, Jehan Pagès 写道: > > > > After sending the previous patch, I thought I was a bit lazy and that was > > not cool to you. So I made an additional patch (attached). > > Basically I did a sed like this

Re: [Mingw-w64-public] [PATCH] headers: make Mingw-w64 pass -Wstrict-prototypes.

2020-04-15 Thread Jehan Pagès
Hi again! On Wed, Apr 15, 2020 at 1:27 PM Jehan Pagès wrote: > Hi! > > I had a case today when a dependency in GIMP CI would fail because they > recently added -Wstrict-prototypes to their list of warnings (additionally > to existing -Werror). > > The attached patch fixes

[Mingw-w64-public] [PATCH] headers: make Mingw-w64 pass -Wstrict-prototypes.

2020-04-15 Thread Jehan Pagès
Hi! I had a case today when a dependency in GIMP CI would fail because they recently added -Wstrict-prototypes to their list of warnings (additionally to existing -Werror). The attached patch fixes some headers to make them strict-prototypes compliant… well at least the ones which were included b

Re: [Mingw-w64-public] [PATCH] headers: define various *_EPSILON in float.h.

2020-03-24 Thread Jehan Pagès
Thanks! Jehan On Tue, Mar 24, 2020 at 3:19 AM Liu Hao wrote: > 在 2020/3/24 5:45, Jehan Pagès 写道: > > Hi all! > > > > I had some issues with the *_EPSILON constants on building a project > > (actually I remember this issue so I think I had it on other projects, &g

[Mingw-w64-public] [PATCH] headers: define various *_EPSILON in float.h.

2020-03-23 Thread Jehan Pagès
Hi all! I had some issues with the *_EPSILON constants on building a project (actually I remember this issue so I think I had it on other projects, but back then I think I just fixed in the project code with some #ifndef #define instead of properly fixing the source of the bug in Mingw-w64; fixing

Re: [Mingw-w64-public] [PATCH] headers: non C90-compliant C++ style comments break builds.

2019-11-21 Thread Jehan Pagès
Thanks! Jehan On Thu, Nov 21, 2019 at 9:01 PM Martin Storsjö wrote: > On Thu, 21 Nov 2019, Jehan Pagès wrote: > > > Hi! > > > > While building Pango with mingw-w64 (x86_64-w64-mingw32-gcc (GCC) 9.2.1 > > 20190827 (Fedora MinGW 9.2.1-1.fc31)), th

[Mingw-w64-public] [PATCH] headers: non C90-compliant C++ style comments break builds.

2019-11-21 Thread Jehan Pagès
Hi! While building Pango with mingw-w64 (x86_64-w64-mingw32-gcc (GCC) 9.2.1 20190827 (Fedora MinGW 9.2.1-1.fc31)), the build failed with this error: - [10/153] Compiling C object 'subprojects/fribidi/lib/c8b5423@@fribidi@sha /fribidi-bidi-types.c.obj'. FAILED: subproje