Thanks!
Jehan
On Thu, Nov 21, 2019 at 9:01 PM Martin Storsjö <mar...@martin.st> wrote:
> On Thu, 21 Nov 2019, Jehan Pagès wrote:
>
> > Hi!
> >
> > While building Pango with mingw-w64 (x86_64-w64-mingw32-gcc (GCC) 9.2.1
> > 20190827 (Fedora MinGW 9.2.1-1.fc31)), the build failed with this error:
> >
> > -----------------------------
> > [10/153] Compiling C object 'subprojects/fribidi/lib/c8b5423@
> @fribidi@sha
> > /fribidi-bidi-types.c.obj'.
> > FAILED: subprojects/fribidi/lib/c8b5423@@fribidi@sha
> /fribidi-bidi-types.c.obj
> >
> > x86_64-w64-mingw32-gcc -Isubprojects/fribidi/lib/c8b5423@@fribidi@sha
> > -Isubprojects/fribidi/lib -I../subprojects/fribidi/lib
> > -Isubprojects/fribidi -I../subprojects/fribidi
> > -Isubprojects/fribidi/gen.tab -I../subprojects/fribidi/gen.tab
> > -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -std=gnu99 -O2 -g
> > -ansi -fvisibility=hidden -DHAVE_CONFIG_H '-DFRIBIDI_ENTRY=extern
> > __attribute__ ((visibility ("default")))' -MD -MQ
> > 'subprojects/fribidi/lib/c8b5423@@fribidi@sha/fribidi-bidi-types.c.obj'
> -MF
> > 'subprojects/fribidi/lib/c8b5423@@fribidi@sha
> /fribidi-bidi-types.c.obj.d'
> > -o 'subprojects/fribidi/lib/c8b5423@@fribidi@sha
> /fribidi-bidi-types.c.obj'
> > -c ../subprojects/fribidi/lib/fribidi-bidi-types.c
> > In file included from ../subprojects/fribidi/lib/common.h:55,
> > from ../subprojects/fribidi/lib/fribidi-bidi-types.c:28:
> > /home/jehan/.local/share/crossroad/roads/w64/gimp/include/stdlib.h:473:1:
> > error: C++ style comments are not allowed in ISO C90
> > 473 | // The ucrtbase version of strtod is C99 compliant, so we don't
> > need to redirect it to the mingw version.
> > | ^
> > -----------------------------
> >
> > The attached patch fixes the build by simply using only C-style comments.
> > Thanks.
>
> Thanks, pushed.
>
> // Martin
>
> _______________________________________________
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
--
ZeMarmot open animation film
http://film.zemarmot.net
Liberapay: https://liberapay.com/ZeMarmot/
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
