Re: [Mingw-w64-public] [PATCH] Include minwindef.h in minwinbase.h

2024-06-06 Thread Daniel Bonniot
On Thu, 6 Jun 2024 at 16:57, LIU Hao wrote: > > 在 2024-06-06 21:33, Daniel Bonniot 写道: > > Thanks for your explanation. Even if it's customary, is there any > > benefit in *not* applying this patch? > > > > I think an argument would be that we try to maint

Re: [Mingw-w64-public] [PATCH] Include minwindef.h in minwinbase.h

2024-06-06 Thread Daniel Bonniot
On Mon, 3 Jun 2024 at 08:21, LIU Hao wrote: > > 在 2024-05-30 21:14, Daniel Bonniot 写道: > > This can be worked around by the user by adding a #include > > before, but it can be confusing/surprising at first. > > Since minwinbase.h depends on definitions from minwind

[Mingw-w64-public] [PATCH] Include minwindef.h in minwinbase.h

2024-06-02 Thread Daniel Bonniot
Hello, Compiling a program which only includes minwinbase.h (or winbase.h) fails with about a hundred errors, starting with: mingw-w64-headers/include/minwinbase.h:16:5: error: ‘DWORD’ does not name a type 16 | DWORD nLength; | ^ This can be worked around by the user by adding a #in