Hello,
Compiling a program which only includes minwinbase.h (or winbase.h)
fails with about a hundred errors, starting with:
mingw-w64-headers/include/minwinbase.h:16:5: error: ‘DWORD’ does not name a type
16 | DWORD nLength;
| ^~~~~
This can be worked around by the user by adding a #include <windef.h>
before, but it can be confusing/surprising at first.
Since minwinbase.h depends on definitions from minwindef.h, wouldn't
it be cleaner if it included it?
My apologies if this is a bad idea for some reason, as I'm not
familiar with the code base.
My proposed patch is below for what it's worth.
Cheers!
Daniel
---
mingw-w64-headers/include/minwinbase.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mingw-w64-headers/include/minwinbase.h
b/mingw-w64-headers/include/minwinbase.h
index 138e0d8..1f06789 100644
--- a/mingw-w64-headers/include/minwinbase.h
+++ b/mingw-w64-headers/include/minwinbase.h
@@ -1,6 +1,8 @@
#ifndef _MINWINBASE_
#define _MINWINBASE_
+#include <minwindef.h>
+
#ifdef __cplusplus
extern "C" {
#endif
--
2.42.0
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
