Re: [Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

2017-12-15 Thread Rob Clark
On Fri, Dec 15, 2017 at 4:41 AM, Nicolai Hähnle wrote: > On 15.12.2017 00:56, Rob Clark wrote: >> >> On Wed, Dec 6, 2017 at 3:31 PM, Ian Romanick wrote: >>> >>> On 12/05/2017 08:25 AM, Ilia Mirkin wrote: >>>> >>>> On Tue, Dec 5, 2017

Re: [Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

2017-12-18 Thread Rob Clark
On Fri, Dec 15, 2017 at 1:08 PM, Nicolai Hähnle wrote: > On 15.12.2017 12:37, Rob Clark wrote: >> >> On Fri, Dec 15, 2017 at 4:41 AM, Nicolai Hähnle >> wrote: >>> >>> On 15.12.2017 00:56, Rob Clark wrote: >>>> >>>>

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2017-12-21 Thread Rob Clark
On Thu, Dec 21, 2017 at 3:36 AM, Daniel Vetter wrote: > On Thu, Dec 21, 2017 at 9:06 AM, James Jones wrote: >> However, making some assumptions, I suspect it's probably going to come down >> to yes we can fit what we need in some number of bits marginally less than >> 56 now, with the current use

[Mesa-dev] [PATCH] nir: add missing local_group_size intrinsic

2017-12-25 Thread Rob Clark
For GL_ARB_compute_variable_group_size Reported-by: Karol Herbst Signed-off-by: Rob Clark --- src/compiler/nir/nir.c| 4 src/compiler/nir/nir_intrinsics.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 688f2b1ae32

Re: [Mesa-dev] [PATCH] nir: add missing local_group_size intrinsic

2017-12-26 Thread Rob Clark
On Mon, Dec 25, 2017 at 10:22 PM, Kenneth Graunke wrote: > On Monday, December 25, 2017 12:19:49 PM PST Rob Clark wrote: >> For GL_ARB_compute_variable_group_size >> >> Reported-by: Karol Herbst >> Signed-off-by: Rob Clark >> --- >> src/compiler/nir/nir

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-01-03 Thread Rob Clark
, but one of > the allocator main features is negotiation of nearly optimal allocation > parameters given a set of uses on different devices/engines by the > capability merge operation. A client should have queried what every > device/engine is capable of for the given uses, find the optima

Re: [Mesa-dev] [PATCH] nv50/ir/ra: Fix copying compound for moves

2018-01-08 Thread Rob Clark
On Mon, Jan 8, 2018 at 7:25 PM, Connor Abbott wrote: > In order to reduce moves when coalescing multiple registers into a > larger register, RA will try to coalesce MERGE instructions with their > definitions. For example, for something like this in GLSL: > > uint a = ...; > uint b = ...; > uint64

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

2018-01-10 Thread Rob Clark
o_state.c > index dd42aa0..9f0c490 100644 > --- a/src/gallium/drivers/freedreno/freedreno_state.c > +++ b/src/gallium/drivers/freedreno/freedreno_state.c > @@ -24,20 +24,21 @@ > * > * Authors: > *Rob Clark > */ > > #include "pipe/p_state.h&quo

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

2018-01-10 Thread Rob Clark
On Wed, Jan 10, 2018 at 3:33 PM, Rob Clark wrote: > On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/freedreno/freedreno_screen.c | 4 +--- >> src/gallium/drivers/freedreno/freedreno_state.c | 13

Re: [Mesa-dev] [PATCH 04/10] freedreno: implement user constant buffers

2018-01-11 Thread Rob Clark
On Wed, Jan 10, 2018 at 4:41 PM, Marek Olšák wrote: > On Wed, Jan 10, 2018 at 9:36 PM, Rob Clark wrote: >> On Wed, Jan 10, 2018 at 3:33 PM, Rob Clark wrote: >>> On Wed, Jan 10, 2018 at 2:49 PM, Marek Olšák wrote: >>>> From: Marek Olšák >>>> &g

Re: [Mesa-dev] [PATCH] st/mesa: enable ARB_enhanced_layouts on nir drivers

2018-01-12 Thread Rob Clark
On Fri, Jan 12, 2018 at 12:52 AM, Timothy Arceri wrote: > I'm guessing this may have been disable because of missing > component packing support. However recent nir linking changes > required nir based gallium drivers to support component packing > so this should now be ok to en

Re: [Mesa-dev] [PATCH] freedreno: actually mark SSBOs as being written

2017-09-25 Thread Rob Clark
I think this is reasonable in the short term.. and looks like it was what I intended to do, so: Reviewed-by: Rob Clark Doing better would require shuffling things around a bit so we could look up the shader variant. Possibly moving some of this bookkeeping into helper fxns that are called back

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Rob Clark
On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: > On 09/26/2017 09:57 AM, Daniel Vetter wrote: >> Hi all, >> >> First again big thanks to Stéphane and Jennifer for organizing a great XDC. >> >> Like last year we'd like to hear feedback on how this year's XDC went, >> both the good (and what y

Re: [Mesa-dev] XDC 2017 feedback

2017-09-27 Thread Rob Clark
On Wed, Sep 27, 2017 at 10:49 PM, Ian Romanick wrote: > On 09/27/2017 04:55 PM, Rob Clark wrote: >> On Wed, Sep 27, 2017 at 7:25 PM, Ian Romanick wrote: >>> On 09/26/2017 09:57 AM, Daniel Vetter wrote: >>>> Hi all, >>>> >>>> First again big

[Mesa-dev] [PATCH 0/6] gallium/freedreno support for context priority

2017-10-04 Thread Rob Clark
ernel UABI), so while I don't expect the freedreno gallium parts to change, they aren't quite ready to merge. Just including them for reference, and so people can begin reviewing the gallium part (first patch). [1] https://patchwork.freedesktop.org/series/31159/ Rob Clark (6): gallium

[Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c| 1 + src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 2/6] freedreno: pass context flags through to fd_context_init()

2017-10-04 Thread Rob Clark
Prep work for later patch. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a2xx/fd2_context.c | 2 +- src/gallium/drivers/freedreno/a3xx/fd3_context.c | 2 +- src/gallium/drivers/freedreno/a4xx/fd4_context.c | 2 +- src/gallium/drivers/freedreno/a5xx/fd5_context.c | 2 +- src

[Mesa-dev] [PATCH 6/6] freedreno: add debug flag to force high priority context

2017-10-04 Thread Rob Clark
Mainly for testing, FD_MESA_DEBUG=hiprio will force high priority contexts. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_util.h| 1 + 3 files changed

[Mesa-dev] [PATCH 3/6] freedreno: rename pipe -> vsc_pipe

2017-10-04 Thread Rob Clark
To add context priority support we need to have an fd_pipe per context, rather than per-screen. Which conflicts with existing ctx->pipe (which is actually a visibility stream pipe (hw resource). So just rename it. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a3xx/fd3_gme

[Mesa-dev] [PATCH 5/6] freedreno: context priority support

2017-10-04 Thread Rob Clark
For devices (and kernels) which support different priority ringbuffers, expose context priority support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 9 - src/gallium/drivers/freedreno/freedreno_screen.c | 12 +++- src/gallium/drivers

[Mesa-dev] [PATCH 4/6] freedreno: per-context fd_pipe

2017-10-04 Thread Rob Clark
To enable per-context priorities, we need to have per-context pipe's. Unfortunately we still need to keep the global screen pipe, mostly just for screen->get_timestamp(). Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a5xx/fd5_draw.c | 2 +- src/gallium/drivers/f

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: > Am 04.10.2017 um 17:44 schrieb Rob Clark: >> Signed-off-by: Rob Clark >> --- >> src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + >> src/gallium/drivers/freedreno/freedreno_screen.c| 1 + &

[Mesa-dev] [PATCH] meson: build freedreno

2017-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- This applies on top of Dylan's wip/meson-radeonsi branch meson.build | 6 + meson_options.txt| 2 +- src/gallium/drivers/freedreno/meson.build| 212 +++ src/ga

[Mesa-dev] [PATCH v2 1/2] freedreno/ir3: use a flag instead of setting PYTHONPATH

2017-10-14 Thread Rob Clark
Similar to 848da662224326ccfbe6647bc82f4f89ca22c762, pass an arg to ir3_nir_trig.py to add to python path, rather than using $PYTHONPATH, to prep for meson build support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/Makefile.am | 2 +- src/gallium/drivers/freedreno/ir3

[Mesa-dev] [PATCH v2 2/2] meson: build freedreno

2017-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- As before, applies on top of of Dylan's wip/meson-radeonsi branch. But now it actually builds freedreno (and fixes some mistakes in v1 that I hadn't noticed because freedreno wasn't actually getting added to the build

[Mesa-dev] [PATCH v3 2/2] meson: build freedreno

2017-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- v1: actually build freedreno v2: corrected installed ${driver}_dri.so name meson.build | 6 + meson_options.txt| 2 +- src/gallium/drivers/freedreno/meson.build| 221

Re: [Mesa-dev] [PATCH v3 2/2] meson: build freedreno

2017-10-15 Thread Rob Clark
On Sat, Oct 14, 2017 at 11:10 PM, Dylan Baker wrote: > Quoting Rob Clark (2017-10-14 11:41:49) >> Signed-off-by: Rob Clark >> --- >> v1: actually build freedreno >> v2: corrected installed ${driver}_dri.so name >> >> meson.build

[Mesa-dev] [PATCH] ttn: set ->info->num_ubos

2016-12-24 Thread Rob Clark
For dealing w/ 32b vs 64b gpu addresses, I need to rework how we pass UBO buffer addresses to shader, and knowing up front the # of UBOs is useful. But I noticed ttn wasn't setting this. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 5 - 1 file chang

Re: [Mesa-dev] [PATCH] ttn: set ->info->num_ubos

2016-12-24 Thread Rob Clark
On Sat, Dec 24, 2016 at 7:30 PM, Eric Anholt wrote: > Rob Clark writes: > >> For dealing w/ 32b vs 64b gpu addresses, I need to rework how we pass >> UBO buffer addresses to shader, and knowing up front the # of UBOs is >> useful. But I noticed ttn wasn't setting t

Re: [Mesa-dev] Patch for freedreno features

2016-12-31 Thread Rob Clark
hey, I don't suppose you could send a git patch? I can push (although tbh glxinfo is the authoritative source when it comes to which extensions are supported on which generations of adreno) BR, -R On Fri, Dec 30, 2016 at 2:09 PM, Romain Failliot wrote: > Hi! > > There's a

Re: [Mesa-dev] Patch for freedreno features

2017-01-01 Thread Rob Clark
DONE > -- > 2.10.1 (Apple Git-78) > > > 2016-12-31 12:26 GMT-05:00 Romain Failliot : >> I'll try to do the git patch! >> >> I know features.txt isn't the official support source and it is more >> for the devs to follow on

Re: [Mesa-dev] Patch for freedreno features

2017-01-03 Thread Rob Clark
On Mon, Jan 2, 2017 at 1:18 PM, Romain Failliot wrote: > 2017-01-01 16:15 GMT-05:00 Rob Clark : >> well, I was trying to not loose authorship/etc from the patch >> (although tbh I've lost track of who the original author was).. >> http://www.mesa3d.org/devinfo.html#submi

Re: [Mesa-dev] [PATCH v2] Rename the DEBUG macro to MESA_DEBUG

2017-01-10 Thread Rob Clark
On Tue, Jan 10, 2017 at 12:07 PM, Jan Vesely wrote: > On Tue, 2017-01-10 at 16:43 +, Emil Velikov wrote: >> On 10 January 2017 at 15:04, Vedran Miletić wrote: >> > On 09/19/2016 08:39 PM, Vedran Miletić wrote: >> > > On 09/07/2016 06:52 PM, Vedran Miletić wrote: >> > > > LLVM and Mesa both de

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Rob Clark
On Mon, Jan 2, 2017 at 9:36 PM, Ben Widawsky wrote: > Same as v1 with the requested fixes and tags added. v1 is here: > https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html > > I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be > doing > it this week,

[Mesa-dev] [PATCH] glsl/standalone: add missing do_mat_op_to_vec() pass

2017-01-19 Thread Rob Clark
glsl_to_nir expects matrix ops to be lowered away to vector by the time it runs, but standalone wasn't bothering to call this pass. Signed-off-by: Rob Clark --- src/compiler/glsl/standalone.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/standalone.cpp b/src/com

Re: [Mesa-dev] [PATCH] glsl/standalone: add missing do_mat_op_to_vec() pass

2017-01-19 Thread Rob Clark
On Thu, Jan 19, 2017 at 1:48 PM, Kenneth Graunke wrote: > On Thursday, January 19, 2017 1:16:18 PM PST Rob Clark wrote: >> glsl_to_nir expects matrix ops to be lowered away to vector by the time >> it runs, but standalone wasn't bothering to call this pass. >> &

[Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-19 Thread Rob Clark
Just a friendly reminder that now would be a good time to update the wiki page for GSoC/EVoC ideas: https://www.x.org/wiki/SummerOfCodeIdeas/ There are currently still some stale ideas there (and probably plenty of missing good ideas). Also, I've added a "Potential Mentors" section. Please ad

Re: [Mesa-dev] [PATCH v2 2/5] intel: Move tools/decoder.[ch] to common/gen_decoder.[ch].

2017-03-23 Thread Rob Clark
On Thu, Mar 23, 2017 at 6:32 PM, Matt Turner wrote: > On Wed, Mar 22, 2017 at 12:53 PM, Rob Herring wrote: >> On Wed, Mar 22, 2017 at 6:50 AM, Emil Velikov >> wrote: >>> n 21 March 2017 at 20:58, Kenneth Graunke wrote: On Tuesday, March 21, 2017 4:40:26 AM PDT Emil Velikov wrote: > On

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Rob Clark
On Fri, Mar 24, 2017 at 3:10 PM, Kristian Høgsberg wrote: > On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >> On 23/03/17 01:38, Rob Clark wrote: >>> >>> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: >>>> >>>> On Wed,

[Mesa-dev] [PATCH 1/2] gallium/util: clean up stack frame printing

2017-03-24 Thread Rob Clark
Prep work for next patch. Ideally 'struct debug_stack_frame' would be opaque, but it is embedded in a bunch of places. But at least we can treat it opaquely. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_debug_refcnt.c | 27 --- src/gallium/auxi

[Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-03-24 Thread Rob Clark
gure out a different format. Signed-off-by: Rob Clark --- configure.ac | 24 src/gallium/Automake.inc | 1 + src/gallium/auxiliary/util/u_debug_stack.c | 91 ++ src/gallium/auxiliary/util/u_debug_stack.h | 15

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Rob Clark
>>>> On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca >>>> wrote: >>>>> >>>>> >>>>> On 23/03/17 01:38, Rob Clark wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Wed, Mar 22, 20

Re: [Mesa-dev] [PATCH kmscube 5/7] drm-atomic.c: remove unused variables `gpu_fence_fd`, `kms_fence_fd`

2017-03-25 Thread Rob Clark
On Wed, Mar 15, 2017 at 6:06 AM, Emil Velikov wrote: > On 14 March 2017 at 13:33, Eric Engestrom wrote: >> Signed-off-by: Eric Engestrom >> --- >> I feel like I might be missing something here; is copying the fields >> into these vars of any use when debugging? > Well places question. > > Last t

[Mesa-dev] [PATCH kmscube 1/3] add license file

2017-03-25 Thread Rob Clark
Signed-off-by: Rob Clark --- COPYING | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 COPYING diff --git a/COPYING b/COPYING new file mode 100644 index 000..7fb42c7 --- /dev/null +++ b/COPYING @@ -0,0 +1,18 @@ +Permission is hereby granted, free of charge, to

[Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-25 Thread Rob Clark
he decoder is pretty simple so I suppose other decoders would be possible. (But hopefully they could already be supported via gstreamer.) Signed-off-by: Rob Clark --- Makefile.am | 6 + common.h | 20 +++ configure.ac | 9 ++ cube-tex.c| 5 +- cube-vide

[Mesa-dev] [PATCH kmscube 3/3] meson build support

2017-03-25 Thread Rob Clark
both cases) Signed-off-by: Rob Clark --- meson.build | 44 1 file changed, 44 insertions(+) create mode 100644 meson.build diff --git a/meson.build b/meson.build new file mode 100644 index 000..08e14b6 --- /dev/null +++ b/meson.build @@ -0,0

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-25 Thread Rob Clark
On Fri, Mar 24, 2017 at 11:47 AM, Jose Fonseca wrote: > > Like I said in another email, maybe mesademos is a good way to get our feet > wet. jfwiw, I decided to figure out what this meson stuff is all about, and converted kmscube (after adding an optional bit for video-cube, to make it *slightly*

[Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-26 Thread Rob Clark
both cases) Signed-off-by: Rob Clark --- meson.build | 48 1 file changed, 48 insertions(+) create mode 100644 meson.build diff --git a/meson.build b/meson.build new file mode 100644 index 000..be83e7b --- /dev/null +++ b/meson.build @@ -0,0

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-27 Thread Rob Clark
On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: > Hi Rob, > > On Sun, Mar 26, 2017 at 10:59 AM, Rob Clark wrote: >> Figured I should figure out what this meson stuff is all about. After a >> bit of hunting around to find examples to look at (and interruptions) it

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-27 Thread Rob Clark
On Mon, Mar 27, 2017 at 7:59 AM, Daniel Stone wrote: > On 27 March 2017 at 12:50, Rob Clark wrote: >> On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: >>> gst-decoder.c:189:40: note: each undeclared identifier is reported >>> only once for each function it

Re: [Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-27 Thread Rob Clark
On Mon, Mar 27, 2017 at 5:41 AM, Emil Velikov wrote: > >> + dec->egl->eglDestroyImageKHR(dec->egl->display, >> dec->last_frame); > > Unrelated: we must be using glGetString(GL_EXTENSIONS) and > eglQueryString(... EGL_EXTENSIONS) alongside eglGetProcAddress(). > It's not cool that km

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-27 Thread Rob Clark
On Mon, Mar 27, 2017 at 5:51 AM, Emil Velikov wrote: > On 26 March 2017 at 14:59, Rob Clark wrote: >> Figured I should figure out what this meson stuff is all about. After a >> bit of hunting around to find examples to look at (and interruptions) it >> took maybe ~1hr to

[Mesa-dev] [PATCH kmscube] meson build support (v3)

2017-03-27 Thread Rob Clark
both cases) Signed-off-by: Rob Clark Reviewed-by: Eric Engestrom Tested-by: Eric Engestrom --- Updated with feedback from various folks.. also tried to make the gst support configurable.. which seems to work, but not sure if there is a more canonical way to do the true/false/auto thing. meson.

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

2017-03-30 Thread Rob Clark
On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli wrote: > > > On 03/30/2017 05:57 PM, Emil Velikov wrote: >> >> On 30 March 2017 at 15:30, Tomasz Figa wrote: >>> >>> On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov >>> wrote: On 30 March 2017 at 11:55, Tomasz Figa wrote: > >

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

2017-03-31 Thread Rob Clark
On Fri, Mar 31, 2017 at 2:06 AM, Tapani Pälli wrote: > > > On 03/31/2017 08:24 AM, Rob Clark wrote: >> >> On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli >> wrote: >>> >>> >>> >>> On 03/30/2017 05:57 PM, Emil Velikov wrot

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-03 Thread Rob Clark
On Mon, Apr 3, 2017 at 12:56 PM, Thomas Hellstrom wrote: > Hi, Rob, > > On 03/24/2017 10:21 PM, Rob Clark wrote: >> It's kinda sad that (a) we don't have debug_backtrace support on !X86 >> and that (b) we re-invent our own crude backtrace support in the fir

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-03 Thread Rob Clark
On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom wrote: > On 04/03/2017 07:33 PM, Thomas Hellstrom wrote: >> On 04/03/2017 07:13 PM, Rob Clark wrote: >>> On Mon, Apr 3, 2017 at 12:56 PM, Thomas Hellstrom >>> wrote: >>>> Hi, Rob, >>>> >&

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-03 Thread Rob Clark
On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom wrote: > On 04/03/2017 07:33 PM, Thomas Hellstrom wrote: >> On 04/03/2017 07:13 PM, Rob Clark wrote: >>> On Mon, Apr 3, 2017 at 12:56 PM, Thomas Hellstrom >>> wrote: >>>> Hi, Rob, >>>> >&

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-03 Thread Rob Clark
On Mon, Apr 3, 2017 at 4:57 PM, Rob Clark wrote: > On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom > wrote: >> On 04/03/2017 07:33 PM, Thomas Hellstrom wrote: >>> On 04/03/2017 07:13 PM, Rob Clark wrote: >>>> On Mon, Apr 3, 2017 at 12:56 PM, Thomas Hell

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 5:00 AM, Thomas Hellstrom wrote: > On 04/03/2017 11:09 PM, Rob Clark wrote: >> On Mon, Apr 3, 2017 at 4:57 PM, Rob Clark wrote: >>> On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom >>> wrote: >>>> On 04/03/2017 07:33 PM, Thomas Hel

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 6:28 AM, Emil Velikov wrote: > On 4 April 2017 at 10:00, Thomas Hellstrom wrote: >> On 04/03/2017 11:09 PM, Rob Clark wrote: >>> On Mon, Apr 3, 2017 at 4:57 PM, Rob Clark wrote: >>>> On Mon, Apr 3, 2017 at 4:06 PM, Thomas Hellstrom >>

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 1:49 AM, Thomas Hellstrom wrote: > But one more worrying thing is that with these fixes, debug_flush gets > too slow to be usable. I get about one frame every 5 seconds from Ubuntu > compiz. The culprit seems to be unw_get_proc_name(). Is there a way we > can save intermedia

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 8:45 AM, Thomas Hellstrom wrote: > On 04/04/2017 02:34 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 1:49 AM, Thomas Hellstrom >> wrote: >>> But one more worrying thing is that with these fixes, debug_flush gets >>> too slow to be usab

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 8:06 AM, Rob Clark wrote: > On Tue, Apr 4, 2017 at 6:28 AM, Emil Velikov wrote: >> On 4 April 2017 at 10:00, Thomas Hellstrom wrote: >>> On 04/03/2017 11:09 PM, Rob Clark wrote: >>>> On Mon, Apr 3, 2017 at 4:57 PM, Rob Clark wrote: >&g

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 8:45 AM, Thomas Hellstrom wrote: > On 04/04/2017 02:34 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 1:49 AM, Thomas Hellstrom >> wrote: >>> But one more worrying thing is that with these fixes, debug_flush gets >>> too slow to be usab

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 10:00 AM, Rob Clark wrote: > On Tue, Apr 4, 2017 at 8:45 AM, Thomas Hellstrom > wrote: >> On 04/04/2017 02:34 PM, Rob Clark wrote: >>> On Tue, Apr 4, 2017 at 1:49 AM, Thomas Hellstrom >>> wrote: >>>> But one more worrying thing

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 10:28 AM, Thomas Hellstrom wrote: > On 04/04/2017 04:06 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 10:00 AM, Rob Clark wrote: >>> On Tue, Apr 4, 2017 at 8:45 AM, Thomas Hellstrom >>> wrote: >>>> On 04/04/2017 02:34 PM, Rob Clar

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-04 Thread Rob Clark
On Tue, Apr 4, 2017 at 12:10 PM, Thomas Hellstrom wrote: > On 04/04/2017 05:36 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 10:28 AM, Thomas Hellstrom >> wrote: >>> On 04/04/2017 04:06 PM, Rob Clark wrote: >>>> On Tue, Apr 4, 2017 at 10:00 AM, Rob Clark w

Re: [Mesa-dev] [PATCH v2] libgl-xlib: Link with libunwind.

2017-04-04 Thread Rob Clark
s: 70c272004f72 ("gallium/util: libunwind support") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100562 > Signed-off-by: Vinson Lee thanks, Reviewed-by: Rob Clark > --- > src/gallium/targets/libgl-xlib/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 de

Re: [Mesa-dev] [PATCH] gallium/util: fixup libunwind includes

2017-04-05 Thread Rob Clark
On Wed, Apr 5, 2017 at 8:25 AM, Emil Velikov wrote: > From: Emil Velikov > > Honour the LIBUNWIND_CFLAGS and include the header only where needed. Please drop the part other than the Makefile.am hunk.. I'm about to need libunwind.h included in the header file. BR, -R > Cc: R

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-05 Thread Rob Clark
On Wed, Apr 5, 2017 at 12:14 PM, Philipp Zabel wrote: > +void > +etna_fence_server_sync(struct pipe_context *pctx, > + struct pipe_fence_handle *pfence) > +{ > + struct etna_context *ctx = etna_context(pctx); > + > + /* FIXME: where should in_fence_fd be stored? */ > +

Re: [Mesa-dev] [PATCH] gallium/util: fixup libunwind includes

2017-04-05 Thread Rob Clark
On Wed, Apr 5, 2017 at 1:42 PM, Emil Velikov wrote: > On 5 April 2017 at 13:37, Rob Clark wrote: >> On Wed, Apr 5, 2017 at 8:25 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> Honour the LIBUNWIND_CFLAGS and include the header only where nee

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Rob Clark
On Thu, Apr 6, 2017 at 10:23 AM, Philipp Zabel wrote: > On Wed, 2017-04-05 at 19:46 +0200, Christian Gmeiner wrote: > [...] >> > --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c >> > +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c >> > @@ -137,6 +137,9 @@ etna_screen_get_param(struct pipe_scr

Re: [Mesa-dev] [PATCH 2/2] egl, dri: Propagate context priority hint to driver->CreateContext

2017-04-06 Thread Rob Clark
On Thu, Apr 6, 2017 at 3:12 PM, Chris Wilson wrote: > Jump through the layers of abstraction between egl and dri in order to > feed the context priority attribute through to the backend. This > requires us to read the value from the base _egl_context, convert it to > a DRI attribute, parse it agai

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

2017-04-07 Thread Rob Clark
On Fri, Apr 7, 2017 at 5:06 AM, Thomas Hellstrom wrote: > Hi, Rob, > > On 04/04/2017 07:12 PM, Rob Clark wrote: >> On Tue, Apr 4, 2017 at 12:10 PM, Thomas Hellstrom >> wrote: >>> On 04/04/2017 05:36 PM, Rob Clark wrote: >>>> On Tue, Apr 4, 2017

[Mesa-dev] [PATCH] gallium/docs: small correction about register files for atomics

2017-04-12 Thread Rob Clark
These can operate on MEMORY[], in addition to BUFFER[] and IMAGE[] Signed-off-by: Rob Clark --- src/gallium/docs/source/tgsi.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 05b06ce..2da2bb6

[Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-13 Thread Rob Clark
This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw there isn't a particularly good reason to treat these differently. Signed-off-by: Rob Clark --- This is part of a larger patchset I'm working on to add SSBO and compute shader support in mesa/st glsl_to_nir path, a

Re: [Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-13 Thread Rob Clark
but then lower to add if hw doesn't have atomic inc/dec instructions) BR, -R > On Thu, Apr 13, 2017 at 8:23 AM, Rob Clark wrote: >> >> This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw >> there isn't a particularly good reason to treat these diff

[Mesa-dev] [PATCH] nir/print: add compute shader info

2017-04-14 Thread Rob Clark
Signed-off-by: Rob Clark --- noticed this hanging out on a branch.. guess I forgot to send it to list.. src/compiler/nir/nir_print.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index af10555..e6c5c9c 100644 --- a

Re: [Mesa-dev] [RFC] nir: add pass to lower atomic counters to SSBO

2017-04-17 Thread Rob Clark
On Thu, Apr 13, 2017 at 11:23 AM, Rob Clark wrote: > This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw > there isn't a particularly good reason to treat these differently. > > Signed-off-by: Rob Clark > --- > This is part of a larger patchset I'

[Mesa-dev] [PATCH] util/queue: don't hang at exit

2017-04-17 Thread Rob Clark
dom crashes when the app calls exit()") Signed-off-by: Rob Clark --- src/util/u_queue.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 0519667..8db09b0 100644 --- a/src/util/u_queue.c +++ b/src/util/u_

[Mesa-dev] [PATCH 0/9] freedreno/a5xx: basic compute shader + SSBOs

2017-04-18 Thread Rob Clark
tate looks basically the same.) Not sure how much time I'll have to work on images or a4xx parts in the near future, but if anyone is looking for a project... Rob Clark (9): nir: add pass to lower atomic counters to SSBO mesa/st: compute+SSBO support for glsl_to_nir freedreno/ir3: resy

[Mesa-dev] [PATCH 1/9] nir: add pass to lower atomic counters to SSBO

2017-04-18 Thread Rob Clark
This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw there isn't a particularly good reason to treat these differently. Signed-off-by: Rob Clark --- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h | 1 + src/compile

[Mesa-dev] [PATCH 4/9] freedreno: core SSBO support

2017-04-18 Thread Rob Clark
The generation-independent support for binding shader buffer objects. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.h | 8 src/gallium/drivers/freedreno/freedreno_draw.c | 6 +++ src/gallium/drivers/freedreno/freedreno_resource.c | 9 src/gallium

[Mesa-dev] [PATCH 2/9] mesa/st: compute+SSBO support for glsl_to_nir

2017-04-18 Thread Rob Clark
Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 14 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- src/mesa/state_tracker/st_program.c| 13 + src/mesa/state_tracker/st_program.h| 3 +++ 4 files changed, 32 insertions

[Mesa-dev] [PATCH 5/9] freedreno/ir3: SSBO/atomic support

2017-04-18 Thread Rob Clark
TODO cwabbott pointed out a write-after-read hazzard, which effects both this and arrays. A write needs to depend on *all* reads since the last write, not just the last read. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3.c| 74 +++- src/gallium/drivers

[Mesa-dev] [PATCH 6/9] freedreno/a5xx: SSBO support

2017-04-18 Thread Rob Clark
resort to shader variants. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a5xx/fd5_emit.c| 69 src/gallium/drivers/freedreno/a5xx/fd5_program.c | 15 -- src/gallium/drivers/freedreno/freedreno_screen.c | 37 - 3 files changed, 114 insertions

[Mesa-dev] [PATCH 3/9] freedreno/ir3: resync instr-a3xx.h/disasm-a3xx.c

2017-04-18 Thread Rob Clark
Sync to the same files from freedreno.git to correct decoding of ldgb/ stgb instructions. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c | 2 +- src/gallium/drivers/freedreno/disasm.h | 3 + src/gallium/drivers/freedreno/ir3/disasm-a3xx.c | 83

[Mesa-dev] [PATCH 9/9] freedreno/a5xx: basic experimental compute support

2017-04-18 Thread Rob Clark
Hidden under FD_MESA_DEBUG=compute flag for now. In particular because we completely lie about having image support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/Makefile.sources | 2 + src/gallium/drivers/freedreno/a5xx/fd5_compute.c | 175 +++ src

[Mesa-dev] [PATCH 8/9] freedreno: core compute support

2017-04-18 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.h | 14 +++- src/gallium/drivers/freedreno/freedreno_draw.c| 47 src/gallium/drivers/freedreno/freedreno_gmem.c| 7 ++ src/gallium/drivers/freedreno/freedreno_gmem.h| 1 + src/gallium/drivers

[Mesa-dev] [PATCH 7/9] freedreno/ir3: compute shader support

2017-04-18 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/disasm.h | 1 + .../drivers/freedreno/ir3/ir3_compiler_nir.c | 81 +- src/gallium/drivers/freedreno/ir3/ir3_shader.c | 76 +++- src/gallium/drivers/freedreno/ir3/ir3_shader.h

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-30 Thread Rob Clark
On Wed, May 30, 2018 at 7:53 PM, Jordan Justen wrote: > On 2018-05-30 14:14:18, Laura Ekstrand wrote: >> The current plan is that this first patch series should just update the >> website. Then we can swap out the theme easily with one or two commands in >> the next series. > > If it's easy to do

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

2018-05-31 Thread Rob Clark
On Thu, May 31, 2018 at 10:04 AM, Eric Engestrom wrote: > Some people have mentioned they don't like the current get_reviewers.pl > script (the one from the kernel) because it is way too greedy in its > search for reviewers. > > I tried to modify it to remove the git blame functionality, but I had

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-05-31 Thread Rob Clark
On Thu, May 31, 2018 at 8:31 PM, Jordan Justen wrote: > On 2018-05-31 16:06:13, Laura Ekstrand wrote: >> A little bit of messing around this afternoon, led to this: >> https://drive.google.com/file/d/1rteTv9415XEMN1E11fyN0l3hTUCCbgwz/view?usp=sharing > > Nice. That confirms we can easily get back

Re: [Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

2018-06-01 Thread Rob Clark
On Fri, Jun 1, 2018 at 3:39 PM, Jason Ekstrand wrote: > If something uses get_variable, it's likely that it doesn't know what to > do with casts. If there are any casts in the chain, just return NULL. > --- > src/compiler/nir/nir.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

2018-06-01 Thread Rob Clark
tch review, so not really sure r-b is appropriate, but I'm pretty happy with the result (and the amount of churn involved does make tranditional patch-by-patch review difficult) BR, -R > > Thanks, > > --Jason Ekstrand > > > > Cc: Rob Clark > Cc: Timothy Arceri

Re: [Mesa-dev] GitLab personal repos

2018-06-02 Thread Rob Clark
On Sat, Jun 2, 2018 at 12:07 PM, Jason Ekstrand wrote: > All, > > This is for those of you who wish to have your personal mesa repo on gitlab. > If you want to keep it on people.freedesktop.org and use cgit, you are more > than welcome to continue doing so for the foreseeable future and you can >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Rob Clark
On Sat, Jun 2, 2018 at 7:49 PM, Jason Ekstrand wrote: > With all this talk of fancy looking new websites, I decided to take a crack > at being artsy and coming up with a fancy-looking logo to put on it. Here's > a first rough draft: > > https://people.freedesktop.org/~jekstrand/gears-logo-bold.pn

Re: [Mesa-dev] [PATCH 08/21] etnaviv: nir: add virtual register classes

2018-06-05 Thread Rob Clark
On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > Since all threads share a global temporary vec4 register file, it is > important to reduce temporary register use of shaders. > Using source swizzles and destination write mask of ALU operations we > can layer smaller virtual registers on top

Re: [Mesa-dev] [PATCH 06/21] etnaviv: nir: hardwire position location

2018-06-05 Thread Rob Clark
On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > The temporary input/output register 0 is reserved for position in the > fragment shader. Hardwire it to 0 and start other input/output variables > at 1. The intrinsic input load and output store base corresponds to the > temporary register nu

<    9   10   11   12   13   14   15   16   17   18   >