On Fri, Jan 12, 2018 at 12:52 AM, Timothy Arceri <[email protected]> wrote:
> I'm guessing this may have been disable because of missing
> component packing support. However recent nir linking changes
> required nir based gallium drivers to support component packing
> so this should now be ok to enable.
>
> Cc: Rob Clark <[email protected]>
It looks like Nicolai added this, including the check for TGSI, but I
guess you are right about the reason.
freedreno/vc4/vc5 don't enable PIPE_CAP_TGSI_ARRAY_COMPONENTS so I
guess this change shouldn't harm anyone. Although I guess from a
quick look maybe we can turn it on for freedreno. (I'm not 100% sure
what "declaring arrays with overlapping ranges" translates to in
nir..)
BR,
-R
> ---
> src/mesa/state_tracker/st_extensions.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c
> b/src/mesa/state_tracker/st_extensions.c
> index 9ef0df1e92..c8411a6995 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -956,9 +956,7 @@ void st_init_extensions(struct pipe_screen *screen,
> }
>
> if (consts->GLSLVersion >= 140) {
> - if (screen->get_param(screen, PIPE_CAP_TGSI_ARRAY_COMPONENTS) &&
> - screen->get_shader_param(screen, PIPE_SHADER_FRAGMENT,
> - PIPE_SHADER_CAP_PREFERRED_IR) ==
> PIPE_SHADER_IR_TGSI)
> + if (screen->get_param(screen, PIPE_CAP_TGSI_ARRAY_COMPONENTS))
> extensions->ARB_enhanced_layouts = GL_TRUE;
> }
>
> --
> 2.14.3
>
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
