Tested-by: Mark Janes
Ben Widawsky writes:
> The original code meant to do this, but was only checking num_samples == 1 to
> figure out if a surface was fast clear capable. However, we can allocate
> single
> sample miptrees with num_samples == 0 (when it's an internally
I would capitalize the hex strings, to match the rest of the file.
with that,
Reviewed-by: Mark Janes
Ben Widawsky writes:
> These match the ones defined in the kernel. The only one tested by us is
> 0x0a84.
>
> Signed-off-by: Ben Widawsky
> ---
> include/pci_ids/
This fixes 1256 tests on BDW.
Tested-by: Mark Janes
Kenneth Graunke writes:
> Matrix vertex attributes have their columns padded out to vec4s, which
> I was failing to account for. Scalar NIR expects them to be packed,
> however.
>
> Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Mark Janes
Tested-by: Mark Janes
Nanley Chery writes:
> From: Nanley Chery
>
> The ASTC spec forbids other compressed formats from being used against
> the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other
> compressed formats were previously supp
Francisco Jerez writes:
> Iago Toral writes:
>
>> On Tue, 2015-11-03 at 15:28 +0200, Francisco Jerez wrote:
>>> Iago Toral writes:
>>>
>>> > On Fri, 2015-10-30 at 16:19 +0200, Francisco Jerez wrote:
>>> >> Iago Toral Quiroga writes:
>>> >>
>>> >> > Right now some opcodes that only use consta
Hi Emil,
I get this regression testing the new branch:
piglit.spec.oes_compressed_paletted_texture.basic api
/tmp/build_root/m64/lib/piglit/bin/oes_compressed_paletted_texture-api -auto
-fbo
Trying glTexImage2D...
Trying glCompressedTexImage2D...
Unexpected GL error: GL_INVALID_ENUM 0x500
(Erro
This test breaks !OpenGL 1_1.infinite-spot-light on broadwell.
Probe color at (0,0)
Expected: 0.50 0.00 0.00 1.00
Observed: 0.00 0.00 0.00 1.00
-Mark
Matt Turner writes:
> Prevents piglit regressions from the next patch.
> ---
> src/mesa/drivers/dri/i965/br
the FS back-end
> does.
>
> Reported-by: Mark Janes
> ---
> src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp | 18 +-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp
> b/src/mesa/
Timothy Arceri writes:
> Use common intrastage array validation for interface blocks. This change also
> allows us to support interface blocks that are arrays of arrays.
Please wrap this message to fit within 80 columns.
> ---
> src/glsl/link_interface_blocks.cpp | 76
> ++---
The series is
Reviewed-by: Mark Janes
Timothy Arceri writes:
> V2: return true when var->type is unsized by max access is within valid range
>
> ---
> src/glsl/linker.cpp | 89
> ++---
> src/glsl/linker.h | 5 +++
&
Hi Brian,
Did you try to `make check` in mesa with these patches?
I get errors compiling glx-test:
src/glx/glxclient.h:59:25: fatal error: util/macros.h: No such file or
directory
-Mark
Brian Paul writes:
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +-
> 1 file changed, 1 inse
Due to recent #include changes, `make check` fails on glx-test. The
target requires a standard include path to find util/macros.h.
---
src/glx/tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am
index dd82449..4db01c0 100644
Jose Fonseca writes:
> From: José Fonseca
>
> This is just to help repro and fixing these issues with any C++ compiler --
>
> commiting this will of course wait until all issues are addressed.
Hi Jose,
I have a patch which trivially fixes extern "C" in the 14 files
identified by no_extern_c.h
System headers may contain C++ declarations, which cannot be given C
linkage. For this reason, include statements should never occur
inside extern "C".
This patch moves the C linkage statements to enclose only the
declarations within a single header.
---
src/gallium/auxiliary/util/u_math.h
Assuming my patch to fix 'extern "C"' issues is pushed before this one,
Reviewed-by: Mark Janes
Jose Fonseca writes:
> From: José Fonseca
>
> This is just to help repro and fixing these issues with any C++ compiler --
>
> commiting this will of course
Several patches added include statements where required by the m64
build. Some files are only compiled for m32, and require similar
changes.
---
src/mesa/tnl/t_vertex_sse.c | 2 ++
src/mesa/x86/rtasm/x86sse.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/mesa/tnl/t_vertex_sse.c b/src
Matt Turner writes:
> On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca wrote:
>> Thanks for doing this. It looks great.
>>
>> Reviewed-by: Jose Fonseca
>>
>>
>> Feel free to push my patch or I'll push it after you push this one.
>
> Thanks José. I've just pushed it.
Unfortunately, my build configuration does not build gallium. This
caused me to miss some files which still have extern C includes.
Due to this oversight, master encounters build errors. I'll send a
patch asap.
-Mark
Mark Janes writes:
> Assuming my patch to fix 'extern &
The previous patch to fix header inclusion within extern "C" neglected
to fix the occurences of this pattern in nouveau files.
When the helper to detect this issue was pushed to master, it broke
the build for the nouveau driver. This patch fixes the nouveau build.
Bugzilla: https://bugs.freedesk
A previous patch to fix header inclusion within extern "C" neglected
to fix the occurences of this pattern in r300 files.
When the helper to detect this issue was pushed to master, it broke
the build for the r300 driver. This patch fixes the r300 build.
Bugzilla: https://bugs.freedesktop.org/sho
A previous patch to fix header inclusion within extern "C" neglected
to fix the occurences of this pattern in nouveau files.
When the helper to detect this issue was pushed to master, it broke
the build for the nouveau driver. This patch fixes the nouveau build.
Bugzilla: https://bugs.freedeskto
Tested-by: Mark Janes
Jason Ekstrand writes:
> Cc: "13.0 17.0"
> ---
> src/intel/blorp/blorp_clear.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
> index afc505d..f
I still get build errors when compiling with LLVM 3.6:
Tom Stellard writes:
> This was broken by: e0cc0a614c96011958bc3a1b84da9168e0e1ccbb
> ---
> src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/src/gal
Tested-by: Mark Janes
Tom Stellard writes:
> This was broken by: e0cc0a614c96011958bc3a1b84da9168e0e1ccbb
>
> v2:
> - Use preprocessor macro
> ---
> src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
&g
With this series, I encounter the following crash using wflinfo:
wflinfo: src/mesa/drivers/dri/common/xmlconfig.c:1028: driQueryOptionb:
Assertion `cache->info[i].name != ((void *)0)' failed.
Samuel Pitoiset writes:
> Mesa currently doesn't allow to create 3.1+ compatibility profiles
> mainly
This series breaks the scons build:
src/compiler/glsl/linker.cpp:4641: undefined reference to
`shader_cache_read_program_metadata(gl_context*, gl_shader_program*)'
Timothy Arceri writes:
> ---
> src/util/disk_cache.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/
Timothy Arceri writes:
> On 17/02/17 12:20, Mark Janes wrote:
>> This series breaks the scons build:
>>
>> src/compiler/glsl/linker.cpp:4641: undefined reference to
>> `shader_cache_read_program_metadata(gl_context*, gl_shader_program*)'
>
> To me it looks l
Should this patch be cc'd to stable branches?
Without it, the compiler crashes on invalid inputs, instead of
generating an error.
This patch applies cleanly to 10.5 and 10.6.
-Mark
Renaud Gaubert writes:
> This is done by returning an rvalue of type void in the
> ast_function_expression::hi
This test regresses a large number of tests in piglit and dEQP, for
example:
piglit.spec.oes_texture_float.oes_texture_float.snbgt2m64 (from piglit)
Standard Output
/tmp/build_root/m64/lib/piglit/bin/oes_texture_float -auto -fbo
oes-texture-float: error 0x502 at
/var/lib/jenkins/jobs/Leeroy/work
This patch regresses the following tests:
piglit.spec.oes_compressed_paletted_texture.basic api
piglit.spec.oes_compressed_paletted_texture.basic api
piglit.spec.oes_compressed_etc1_rgb8_texture.basic
When you submit v4, please verify that there are no piglit or dEQP
regressions. Also, please co
These three patches are
Tested-by: Mark Janes
Neil Roberts writes:
> When the edge flag element is enabled then the elements are slightly
> reordered so that the edge flag is always the last one. This was
> confusing the code to upload the 3DSTATE_VF_INSTANCING state because
Digging through old, un-reviewed patches... Mesa builds and runs just
fine without this.
Reviewed-by: Mark Janes
Matt Turner writes:
> Never used.
> ---
> src/mapi/glapi/gen/gl_x86-64_asm.py | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/mapi/glapi/ge
Tested-by: Mark Janes
Jason Ekstrand writes:
> Signed-off-by: Jason Ekstrand
> Cc: "12.0"
> Cc: Jordan Justen
> ---
> src/compiler/nir/nir_lower_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_lower_io.c
Reviewed-by: Mark Janes
Tested-by: Mark Janes
Ilia Mirkin writes:
> This was missed when I added the updated (and new) Khronos headers.
>
> Signed-off-by: Ilia Mirkin
> ---
> src/mapi/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/map
Hi Lionel,
This patch triggered CID 1372521 in Coverity. Please let me know if my
the analysis is correct below:
Lionel Landwerlin writes:
> Fixes new CTS tests :
>
> dEQP-VK.spirv_assembly.instruction.compute.opatomic.load
> dEQP-VK.spirv_assembly.instruction.compute.opatomic.store
>
> v2: do
This patch regresses
es2-cts.gtf.gl2extensiontests.egl_image_external.testsimpleunassociated
https://bugs.freedesktop.org/show_bug.cgi?id=97761
Antia Puentes writes:
> - Fixes CTS tests:
>
> * GL44-CTS.shader_image_size.advanced-nonMS-cs-float
> * GL44-CTS.shader_image_size.advanced-nonMS-cs-in
Dave Airlie writes:
> From: Dave Airlie
>
> This moves these outside the wsi platform code, so we can reuse
> that code
> ---
> src/intel/vulkan/anv_wsi.c | 121 +++-
> src/intel/vulkan/anv_wsi.h | 19 -
> src/intel/vulkan/anv_wsi_wayland.c | 120
Tested-by: Mark Janes
Tapani Pälli writes:
> Otherwise we can end up with mismatching behavior between config and
> surface when client queries surface attributes. As example, configs
> for DRI3 do not support preserved behavior but here we were setting
> preserved behavior fo
Matt Turner writes:
> On Tue, Nov 8, 2016 at 1:59 PM, Emil Velikov wrote:
>> Jordan Justen (1)
>> 49c24d8 i965: fix noop_scissor range issue on width/height
>> Note: temporary on hold since it causes GPU lockups on 32bit builds.
>
> Let's just drop this one. I found it in an old branch and
g back to an ARGB
>>> visual, which led me to the discovery that this had only been changed for
>>> i965.
>>>
>>> I'll try to get him to reply with a "Tested-by" tomorrow.
>>>
>>>
>>
>> Thanks for the kind repl
Reviewed-by: Mark Janes
Chad Versace writes:
> Don't dereference a null EGLDisplay.
>
> Fixes tests
> dEQP-EGL.functional.negative_api.create_pbuffer_surface
> dEQP-EGL.functional.negative_api.create_pixmap_surface
>
> Fixes: https://bugs.freedesktop.org/show_bug
Tested-by: Mark Janes
Tapani Pälli writes:
> This makes better guarantee that the values we return are
> in sync what the underlying drawable currently has.
>
> Together with dEQP change in bug #98327 this fixes following test:
>
>dEQP-EGL.functional.resize.surface_size.
In the interest of getting the build going again, I pushed this patch
with Jason's review.
Emil Velikov writes:
> From: Emil Velikov
>
> Atm the actual rule will expand to foo.o which is used for static
> libraries only.
>
> Thus the automake manual recommendation [to use OBJEXT] won't help us,
Tested-by: Mark Janes
Kenneth Graunke writes:
> The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae
> was entirely broken. A missing "break" made the load_interpolated_input
> case always fall through to "default" and hit a "continue&q
I'll test it.
Chad Versace writes:
> Hi Intel folks, could one of you please run this through Jenkins?
> I verified manually that it fixes the listed dEQP tests on Skylake.
>
> Chad Versace (2):
> i965: Fix miptree layout for EGLImage-based renderbuffers
> i965: Respect miptree offsets in in
I saw no regressions from these tests. However, I wasn't able to run
the dEQP-EGL tests the last time I tried. What branch of dEQP are you
running?
InternalError (Runtime check failed: '(m_capabilities &
CAPABILITY_GET_DISPLAY_PLATFORM) == 0' at egluNativeDisplay.cpp:70)
-Mark
Chad Versa
`make check` fails to link test_vec4_copy_propagation after 6dac455e.
---
src/mesa/program/sampler.cpp | 5 ++---
src/mesa/program/sampler.h | 7 +++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp
index f8584c9..7754
Brian Paul writes:
> I don't think this is right. The functions in question are C++
> functions and they're only called from .cpp files. I don't see why
> C-style linkage is desired.
>
> See https://bugs.freedesktop.org/show_bug.cgi?id=87371 for another
> approach. Please test that patch if
C linkage was removed from functions in program/sampler.cpp. However,
some cpp files include program/sampler.h within extern "C" blocks,
causing link errors for test_vec4_copy_propagation.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_fs.h |
Hi Matt,
The tests which originated this bug still crash:
glslparsertest:
../../../../../../src/mesa/drivers/dri/i965/brw_fs.cpp:2930: void
fs_visitor::insert_gen4_post_send_dependency_workarounds(bblock_t*,
fs_inst*): Assertion `!needs_dep[i]' failed.
You don't need a g965 to reproduce it, as w
This patch regresses thousands of tests on BDW and HSW:
http://mesa-ci-results.jf.intel.com/vulkancts/builds/10035/group/63a9f0ea7bb98050796b649e85481845#fails
I'll revert it as soon as my testing completes.
Iago Toral Quiroga writes:
> We had defined MAX_IMAGES as 8, which we used to size the
Hi Iago,
It looks like you tested this patch in CI and got the same failures that
we are seeing on master:
http://mesa-ci-results.jf.intel.com/itoral/builds/263/group/63a9f0ea7bb98050796b649e85481845
Why was this patch pushed?
-Mark
Mark Janes writes:
> This patch regresses thousands
Eero Tamminen writes:
> Hi,
>
> On 31.1.2019 1.37, Dylan Baker wrote:
>> This email announces the mesa 19.0 release candidate 1. I'll keep this email
>> fairly brief since I'm already running a little late on getting this done :)
>> I've just had to resolve quite a few autotools issues to get the
Kenneth Graunke writes:
> On Wednesday, September 02, 2015 12:03:12 AM Matt Turner wrote:
>> The lowered code reads from the destination, which isn't possible from
>> message registers.
>>
>> Fixes the dEQP functional.shaders.precision.int.highp_mul_fragment test
>> on SNB.
>> ---
>> src/mesa/d
I verified that this fixed the following tests on snb:
dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment
dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragment
dEQP-GLES3.functional.shaders.precision.int.lowp_mul_fragment
However, my testing showed the following
Mark Janes writes:
> I verified that this fixed the following tests on snb:
>
> dEQP-GLES3.functional.shaders.precision.int.highp_mul_fragment
> dEQP-GLES3.functional.shaders.precision.int.mediump_mul_fragment
> dEQP-GLES3.functional.shaders.precision.int.lo
Tested-by: Mark Janes
Kenneth Graunke writes:
> In various versions of OpenGL and GLSL, it's possible to declare
> multiple VS input variables with aliasing attribute locations.
>
> So, when computing the storage requirements for vertex attributes,
> we can't simply a
Please add Matt Turner's patch:
[PATCH 10.6] i965/fs: Handle MRF destinations in
lower_integer_multiplication().
This fixes a sandy bridge regression in dEQP. dEQP regressions on
stable will prevent ChromeOS from using 10.6.6 as the basis for their
Mesa build.
thanks,
Mark
Emil Velikov write
By my count, this series fixes 59 separate dEQP tests on various
platforms. I found no regressions.
Tested-by: Mark Janes
Eduardo Lima Mitev writes:
> This is a new version of the mini-series that fixes the regression described
> at https://bugs.freedesktop.org/show_bug.cgi?id
Mark Janes writes:
> By my count, this series fixes 59 separate dEQP tests on various
I incorrectly attributed 54 of those test fixes to this patch series. I
had applied this patch on top of Iago's
96ea1663082c4a17eaf59873190f1e9677623d91, which also improved dEQP.
> platforms.
Ben Widawsky writes:
> On Fri, Sep 04, 2015 at 02:58:30PM -0700, Ben Widawsky wrote:
>> On Wed, Sep 02, 2015 at 01:03:43PM +0100, Chris Wilson wrote:
>> > On Wed, Aug 26, 2015 at 10:52:58AM -0700, Ben Widawsky wrote:
>> > > Docs suggest this is no longer required starting with Gen8.
>> > >
>> >
I tested this series, and found some issues:
The following tests assert on g33:
piglit.shaders.glsl-fwidth
piglit.shaders.glsl-fs-sampler-numbering
piglit.shaders.glsl-lod-bias
piglit.shaders.glsl-kwin-blur-1
piglit.shaders.glsl-bug-22603
piglit.shaders.glsl-fs-texturecube
This fixes a GPU hang on IVB, which is triggered with
piglit.spec.arb_shader_image_load_store.invalid
Tested-by: Mark Janes
Francisco Jerez writes:
> IVB and VLV hang sporadically when an untyped surface read or write
> message is used to access a surface of format other than RAW,
When I tested this, I saw an intermittent BSW gpu hang. I haven't been
able to confirm that it is due to the host-mem-barrier test.
-Mark
Francisco Jerez writes:
> The hardware documentation relating to the UAV HW-assisted coherency
> mechanism and UAV access enable bits is scarce and sometime
Francisco Jerez writes:
> Mark Janes writes:
>
>> When I tested this, I saw an intermittent BSW gpu hang. I haven't been
>> able to confirm that it is due to the host-mem-barrier test.
>>
> It would probably be useful to know if the hang is due to any of the
>
Mark Janes writes:
> Francisco Jerez writes:
>
>> Mark Janes writes:
>>
>>> When I tested this, I saw an intermittent BSW gpu hang. I haven't been
>>> able to confirm that it is due to the host-mem-barrier test.
>>>
>> It would pro
I tested this series, and found a few issues:
- `make check` fails the dispatch sanity tests in Mesa
- The branch doesn't rebase cleanly on top of master (this isn't wrong,
it just surprised me, since you sent out the series so recently)
- piglit.spec.arb_uniform_buffer_object.getintegeri_
This series hits an assertion on ILK and G45:
src/mesa/drivers/dri/i965/brw_eu_emit.c:150: brw_set_dest: Assertion
`dest.nr < (devinfo->gen == 6 ? 24 : 16)' failed.
It triggers about 8k piglit assertions on those platforms. I'm turning
off testing for G45 and ILK until it is resolved.
https://b
Hi Iago,
According to my tests, this patch series fixes the gles2/gles3
"functional.uniform_api.random.23" tests in dEQP, on sandybridge.
Do you see the same results? Should this patch series be applied to the
stable branch?
thanks,
Mark
Iago Toral Quiroga writes:
> There are some bug repor
Hi Eduardo,
I can't get this patch to apply to any recent version of glformats.c
Can you double check it?
thanks,
Mark
Eduardo Lima Mitev writes:
> When validating format+type+internalFormat for texture pixel operations
> on GLES3, the effective internal format should be used if the one
> sp
Emil Velikov writes:
> Hi all,
>
> On 10 September 2015 at 00:30, Mark Janes wrote:
>> Mark Janes writes:
>>
>>> Francisco Jerez writes:
>>>
>>>> Mark Janes writes:
>>>>
>>>>> When I tested this, I saw an intermit
Can you please add this commit to the branch for 11.0.1?
commit 2ea16966ae66d4dd5c5dcb996d7996d9c734bbee
Author: Kristian Høgsberg Kristensen
Date: Wed Sep 23 16:57:47 2015 -0700
i965: Respect stride and subreg_offset for ATTR registers
It fixes a Braswell dEQP regression.
thanks,
Mark
This patch series fixes a few dEQP tests on braswell. The rest of the
platform are unaffected, according to my tests.
deqp-gles2.functional.negative_api.texture.teximage2d_invalid_type
deqp-gles2.functional.negative_api.texture.teximage2d_invalid_internalformat
deqp-gles3.functional.negative_api.
Tested-by: Mark Janes
Eduardo Lima Mitev writes:
> This is a new version of the series that attempt to fix the regression
> reported at:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=91582
>
> The review by Jason helped me uncover the fact that the following 3 dEQP
I tested this patch and found:
regressions:
spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only)
expected[1] = 1.00. Read value: 0.00
spec.arb_copy_image.arb_copy_image-srgb-copy (assertion)
arb_copy_image-srgb-copy: src/mesa/main/texobj.c:1739:
_mesa_Bi
Mark Janes writes:
> I tested this patch and found:
>
> regressions:
> spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW only)
> expected[1] = 1.00. Read value: 0.00
In subsequent testing I found this BDW failure to be a pre-existing and
intermittent.
yes, the assertions are still accurate. I haven't been able to get a
stack trace yet. If I don't get to it perhaps Tapani can take a look
this evening.
Ian Romanick writes:
> On 10/06/2015 09:31 AM, Mark Janes wrote:
>> Mark Janes writes:
>>
>>
Brian Paul writes:
> On 10/05/2015 05:18 PM, Mark Janes wrote:
>> I tested this patch and found:
>>
>> regressions:
>>spec.arb_shader_storage_buffer_object.layout-std140-write-shader (BDW
>> only)
>> expected[1] = 1.00. Read value: 0.00
>>
No regressions were indicated by this patch. However, the initial
regression did not trigger any test failures, either.
It is unacceptable for such an obvious regression to pass Mesa's
automated test suites. I re-opened the bug, pending the creation of
suitable tests.
-Mark
Emil Velikov write
Tested-by: Mark Janes
Brian Paul writes:
> Callers of create_texture() will either pass target=0 or a validated
> GL texture target enum so no need to do another error check inside
> the loop.
> ---
> src/mesa/main/texobj.c | 11 ++-
> 1 file changed, 2 insertio
Brian Paul writes:
> On 10/07/2015 04:47 PM, Mark Janes wrote:
>> Brian Paul writes:
>>
>>> On 10/05/2015 05:18 PM, Mark Janes wrote:
>>>> I tested this patch and found:
>>>>
>>>> regressions:
>>>> spec.arb_
Brian Paul writes:
> You tested with all 3 patches and everything's OK now?
Sorry, I should have been more clear:
Series is
Tested-by: Mark Janes
>
> I guess I'd still like an R-b on the 3rd patch ("mesa,meta: move
> gl_texture_object::TargetIndex initializa
commit, KBL passes piglit at parity with SKL.
Signed-off-by: Mark Janes
---
src/mesa/drivers/dri/i965/brw_device_info.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c
b/src/mesa/drivers/dri/i965/brw_device_info.c
index 42bcb98..3ca522b
Sarah Sharp writes:
> On Fri, Jan 08, 2016 at 04:30:20PM -0800, Mark Janes wrote:
>> In testing KBL, I found:
>>
>> - urb size was not set for slices gt1.5, gt2, and gt3. The value I
>>used for these slices (384) was taken from an earlier patch aut
Thanks Sarah. I'll turn on KBL testing in the CI.
Sarah Sharp writes:
> From: Mark Janes
>
> In testing KBL, I found:
>
> - urb size was not set for slices gt1.5, gt2, and gt3. The value I
>used for these slices (384) was taken from an earlier patch author
s the rules for multiple layouts.
>
> Cc: Mark Janes
> ---
> src/glsl/ast_type.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index cf494d9..e0e3311 100644
> --- a/src/glsl/ast_type.cpp
>
Tested-by: Mark Janes
Ben Widawsky writes:
> When setting the conservative thread counts, I halved everything. That isn't
> correct for the wm, which has nothing to do with actual thread counts. I suck.
>
> BXT only has 1 slice, and there is some ambiguity about subslices,
Fixes intermittent Vulkan CTS failures within the test groups:
dEQP-VK.api.object_management.multithreaded_per_thread_device
dEQP-VK.api.object_management.multithreaded_per_thread_resources
dEQP-VK.api.object_management.multithreaded_shared_resources
Signed-off-by: Mark Janes
Bugzilla: https
Jason Ekstrand writes:
> On Tue, Apr 12, 2016 at 3:51 PM, Jason Ekstrand
> wrote:
>
>>
>> On Apr 12, 2016 3:41 PM, "Matt Turner" wrote:
>> >
>> > On Tue, Apr 12, 2016 at 3:10 PM, Mark Janes
>> wrote:
>> > > Fixes i
Reviewed-by: Mark Janes
Chad Versace writes:
> _mesa_libgcrypt_init() returns NULL, but its return type is void.
>
> Cc: Mark Janes
> ---
> src/util/mesa-sha1.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/mesa-sha1.c b/src/
Tested-by: Mark Janes
Jason Ekstrand writes:
> We have had a guard against OOB array access of images on IVB for a long
> time, but it can actually cause hangs on any GPU generation. This can
> happen due to getting an untyped SURFACE_STATE for a typed message or
> vice-versa. We
Reviewed-by: Mark Janes
Jason Ekstrand writes:
> This adds functions for splicing one list into another. These have
> more-or-less the same API as the kernel list splicing functions.
> ---
> src/util/list.h | 22 ++
> 1 file changed, 22 insertions(+)
>
Tested-by: Mark Janes
Tapani Pälli writes:
> Refactoring done on active attribute queries did not take in to
> account special built-in inputs for the vertex stage. This commit
> sets them referenced by vertex stage so that they get enumerated
> properly.
>
> Fixes Pigli
Francisco Jerez writes:
> This is not a real IR in the sense of a long-lived representation of
> the program. An SVEC4 instruction, defined as an opcode operating on
> 4-vectors of FS registers, is broken up into its scalar components
> (each an fs_inst) as soon as it's emitted. The svec4_inst
Tested-by: Mark Janes
Tapani Pälli writes:
> Commit dd5c825 changed the way how execution size for instructions
> get set. Previously it was based on destination register width, now
> it is set explicitly when emitting instructions.
>
> Signed-off-by: Tapani Pälli
> Revi
Hi Emil,
This patch prevents piglit from linking:
[ 98%] CMakeFiles/ext_image_dma_buf_import-sample_rgb.dir/sample_common.c.o:
In function `sample_and_destroy_img':
piglit/tests/spec/ext_image_dma_buf_import/sample_common.c:107:
undefined reference to `eglDestroyImageKHR'
Is th
This patch fixes `make check` for me, but v2 has been pushed, so...
Who gets to make a patch to fix master?
Tested-by: Mark Janes
Ian Romanick writes:
> From: Brian Paul
>
> Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and
> _glapi_set_nop_handler() functions
This patch allows us to enable our Braswell in our continuous
integration pool. Without it, gpu hangs prevent piglit from
completing.
Getting Braswell enabled in the pool will help us prevent future
regressions on the platform.
Tested-by: Mark Janes
Ben Widawsky writes:
> AFAICT, there
Piglit tests on Ironlake, and probably Gen4 as well.
>
> Reported-by: Mark Janes
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_curbe.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_curbe.c
> b/src/m
Reviewed-by: Mark Janes
Jason Ekstrand writes:
> ---
> src/glsl/nir/nir_worklist.c | 10 +-
> src/glsl/nir/nir_worklist.h | 4 ++--
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/src/glsl/nir/nir_worklist.c b/src/glsl/nir/nir_worklist.c
> i
1 - 100 of 284 matches
Mail list logo
