Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-27 Thread Samuel Pitoiset
On 07/27/2017 03:24 AM, Timothy Arceri wrote: On 27/07/17 01:48, Samuel Pitoiset wrote: Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (es

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Jason Ekstrand
On Wed, Jul 26, 2017 at 5:26 PM, Timothy Arceri wrote: > On 27/07/17 04:53, Jason Ekstrand wrote: > >> On July 26, 2017 8:48:18 AM Samuel Pitoiset >> wrote: >> >> Hi guys, >>> >>> I didn't review the radeonsi and radv patches, but I have sent comments >>> on other parts. >>> >>> More generally:

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Timothy Arceri
On 27/07/17 01:48, Samuel Pitoiset wrote: Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (especially for bisecting) Can you double check? E

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Timothy Arceri
On 27/07/17 04:53, Jason Ekstrand wrote: On July 26, 2017 8:48:18 AM Samuel Pitoiset wrote: Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Jason Ekstrand
On July 26, 2017 8:48:18 AM Samuel Pitoiset wrote: Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (especially for bisecting) Can you double ch

Re: [Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Samuel Pitoiset
Hi guys, I didn't review the radeonsi and radv patches, but I have sent comments on other parts. More generally: - I wonder if some intermediate patches can break Mesa, would be nice to avoid that (especially for bisecting) Can you double check? - I don't see any piglit tests... or did I m

[Mesa-dev] Initial support for EXT_external_objects v4

2017-07-26 Thread Timothy Arceri
Hi all, Andres is not around at the moment so as well are reviewing the remaining patches I've rebased and added all Marek's suggestions. I've also made a few minor changes (see commit messages) and reworked some of the patches to reduce code churn. I thought I'd send it out one last time to see