Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-20 Thread Timothy Arceri
On 21/2/19 2:32 am, Marek Olšák wrote: On Wed, Feb 20, 2019 at 2:31 AM Connor Abbott > wrote: On Wed, Feb 20, 2019 at 4:29 AM Marek Olšák mailto:mar...@gmail.com>> wrote: On Tue, Feb 19, 2019 at 7:57 PM Rob Clark mailto:robdcl...@gmail.com>> wrote:

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-20 Thread Eero Tamminen
Hi, On 20.2.2019 17.32, Marek Olšák wrote: On Wed, Feb 20, 2019 at 2:31 AM Connor Abbott On Wed, Feb 20, 2019 at 4:29 AM Marek Olšák ... That's a harsh reaction to a relatively good benchmarking setup. I use debugoptimized with -DDEBUG. My performance is probably mor

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-20 Thread Marek Olšák
On Wed, Feb 20, 2019 at 2:31 AM Connor Abbott wrote: > > > On Wed, Feb 20, 2019 at 4:29 AM Marek Olšák wrote: > >> On Tue, Feb 19, 2019 at 7:57 PM Rob Clark wrote: >> >>> On Tue, Feb 19, 2019 at 6:49 PM Marek Olšák wrote: >>> > >>> > st_link_shader takes 55% of CPU time with NIR, and 9% with T

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Connor Abbott
On Wed, Feb 20, 2019 at 4:29 AM Marek Olšák wrote: > On Tue, Feb 19, 2019 at 7:57 PM Rob Clark wrote: > >> On Tue, Feb 19, 2019 at 6:49 PM Marek Olšák wrote: >> > >> > st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. >> > >> > nir_validate_shader 49% >> > >> > nir_validate_shade

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Marek Olšák
On Tue, Feb 19, 2019 at 7:57 PM Rob Clark wrote: > On Tue, Feb 19, 2019 at 6:49 PM Marek Olšák wrote: > > > > st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. > > > > nir_validate_shader 49% > > > > nir_validate_shader is overused. It doesn't make sense even in debug > builds. >

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Rob Clark
On Tue, Feb 19, 2019 at 6:49 PM Marek Olšák wrote: > > st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. > > nir_validate_shader 49% > > nir_validate_shader is overused. It doesn't make sense even in debug builds. tbh, I like nir_validate enabled when I do piglit/deqp runs.. and I

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Timothy Arceri
On 20/2/19 10:59 am, Timothy Arceri wrote: On 20/2/19 10:49 am, Marek Olšák wrote: st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. nir_validate_shader 49% nir_validate_shader is overused. It doesn't make sense even in debug builds. It's used to validate the IR between opt

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Timothy Arceri
On 20/2/19 10:49 am, Marek Olšák wrote: st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. nir_validate_shader 49% nir_validate_shader is overused. It doesn't make sense even in debug builds. It's used to validate the IR between optimisation/lowering passes. For debug builds yo

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-19 Thread Marek Olšák
st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI. nir_validate_shader 49% nir_validate_shader is overused. It doesn't make sense even in debug builds. Marek On Wed, Feb 13, 2019 at 4:26 AM Connor Abbott wrote: > Reviewed-by: Connor Abbott > > I'm a bit surprised it's that slow

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Timothy Arceri
On 13/2/19 8:47 pm, Timothy Arceri wrote: On 13/2/19 8:38 pm, Timothy Arceri wrote: On 13/2/19 8:26 pm, Connor Abbott wrote: Reviewed-by: Connor Abbott > I'm a bit surprised it's that slow... do you have any idea what's going on? I've made flamegraphs in the past o

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Timothy Arceri
On 13/2/19 10:01 pm, Michel Dänzer wrote: On 2019-02-13 10:38 a.m., Timothy Arceri wrote: On 13/2/19 8:26 pm, Connor Abbott wrote: Reviewed-by: Connor Abbott mailto:cwabbo...@gmail.com>> I'm a bit surprised it's that slow... do you have any idea what's going on? I've made flamegraphs in the pa

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Michel Dänzer
On 2019-02-13 10:38 a.m., Timothy Arceri wrote: > On 13/2/19 8:26 pm, Connor Abbott wrote: >> Reviewed-by: Connor Abbott > > >> >> I'm a bit surprised it's that slow... do you have any idea what's >> going on? I've made flamegraphs in the past on i965 to see where most >

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Timothy Arceri
On 13/2/19 8:38 pm, Timothy Arceri wrote: On 13/2/19 8:26 pm, Connor Abbott wrote: Reviewed-by: Connor Abbott > I'm a bit surprised it's that slow... do you have any idea what's going on? I've made flamegraphs in the past on i965 to see where most of the time is sp

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Timothy Arceri
On 13/2/19 8:26 pm, Connor Abbott wrote: Reviewed-by: Connor Abbott > I'm a bit surprised it's that slow... do you have any idea what's going on? I've made flamegraphs in the past on i965 to see where most of the time is spent. Some shaders are actually faster, bu

Re: [Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Connor Abbott
Reviewed-by: Connor Abbott I'm a bit surprised it's that slow... do you have any idea what's going on? I've made flamegraphs in the past on i965 to see where most of the time is spent. On Wed, Feb 13, 2019 at 9:00 AM Timothy Arceri wrote: > Currently the radeonsi NIR backend takes around twice

[Mesa-dev] A few NIR compile time optimisations

2019-02-13 Thread Timothy Arceri
Currently the radeonsi NIR backend takes around twice the time of the tgsi backend to compile shader-db. These are some first steps at reducing the overhead of NIR. This series reduces the compile time of a Deus Ex program I was profiling by around 5%. ___