Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-07 Thread Ilia Mirkin
On Wed, Nov 7, 2018 at 7:45 AM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 15:28 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 3:15 PM Gert Wollny > > wrote: > > > > > > > > > The extension has the status "not complete" but after reading is it > > > seems to describe what is neede

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-07 Thread Gert Wollny
Am Dienstag, den 06.11.2018, 15:28 -0500 schrieb Ilia Mirkin: > On Tue, Nov 6, 2018 at 3:15 PM Gert Wollny > wrote: > > > > > > The extension has the status "not complete" but after reading is it > > seems to describe what is needed from ARB_framebuffer_sRGB in GLES > > 3.0, Well, after starti

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 3:15 PM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 11:14 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny > m> wrote: > > I'm not as intimately familiar with GLES extensions / features, but > > would EXT_sRGB be the extension that covers t

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Dienstag, den 06.11.2018, 11:14 -0500 schrieb Ilia Mirkin: > On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny m> wrote: > I'm not as intimately familiar with GLES extensions / features, but > would EXT_sRGB be the extension that covers that support? The extension has the status "not complete" but a

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Marek Olšák
I prefer not to have any negative caps. Marek On Tue, Nov 6, 2018, 11:14 AM Ilia Mirkin On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny > wrote: > > > > Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > > > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > > > wrote: > > > > > > > > > > >

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 10:27 AM Gert Wollny wrote: > > Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > > wrote: > > > > > > > > > I'm not so sure that things break, at least we have all the dEQP > > > master tests that are enabled by

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Dienstag, den 06.11.2018, 09:29 -0500 schrieb Ilia Mirkin: > On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny > wrote: > > > > > > I'm not so sure that things break, at least we have all the dEQP > > master tests that are enabled by the available extension (level > > GLES 3.2+) passing on virgl, wh

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Ilia Mirkin
On Tue, Nov 6, 2018 at 5:59 AM Gert Wollny wrote: > > Am Montag, den 05.11.2018, 11:17 -0500 schrieb Ilia Mirkin: > > On Mon, Nov 5, 2018 at 11:02 AM Gert Wollny > m> wrote: > > > > > > Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > > > > At the gallium level, it's a promise that s

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Montag, den 05.11.2018, 17:00 -0500 schrieb Marek Olšák: > At the Gallium level, you can change between UNORM and SRGB in > pipe_surface. If you allocate a texture as SRGB, you should be able > to use it as LINEAR and vice versa. > > All hardware that supports both LINEAR and SRGB supports this

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-06 Thread Gert Wollny
Am Montag, den 05.11.2018, 11:17 -0500 schrieb Ilia Mirkin: > On Mon, Nov 5, 2018 at 11:02 AM Gert Wollny m> wrote: > > > > Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > > > At the gallium level, it's a promise that some PIPE_FORMAT_*_SRGB > > > is > > > supported for rendering an

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Marek Olšák
At the Gallium level, you can change between UNORM and SRGB in pipe_surface. If you allocate a texture as SRGB, you should be able to use it as LINEAR and vice versa. All hardware that supports both LINEAR and SRGB supports this. A typical hw driver does that simply by changing the format in the f

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Ilia Mirkin
On Mon, Nov 5, 2018 at 11:02 AM Gert Wollny wrote: > > Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > > At the gallium level, it's a promise that some PIPE_FORMAT_*_SRGB is > > supported for rendering and that you can use a non-srgb format in the > > surface even if the resource was

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Gert Wollny
Am Montag, den 05.11.2018, 08:56 -0500 schrieb Ilia Mirkin: > At the gallium level, it's a promise that some PIPE_FORMAT_*_SRGB is > supported for rendering and that you can use a non-srgb format in the > surface even if the resource was originally allocated with an srgb > format (and vice-versa).

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Ilia Mirkin
On Mon, Nov 5, 2018 at 7:12 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > > > > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_control is a > > GLES ext that was meant to provide the same functionality in GLES > > (have a glance at Issue

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-05 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_control is a > GLES ext that was meant to provide the same functionality in GLES > (have a glance at Issue #1 in that spec). You could have hardware > that supports neit

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > > > It is not different, this extension was specifically written to > > bring GLES on par with GL in this asspect (although with a > > different default). [...] > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_contr

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Ilia Mirkin
On Thu, Nov 1, 2018 at 12:17 PM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 12:03 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > > > On Thu, Nov 1, 2018 at 10:41 AM Ge

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 12:03 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny > > a.co > > > m> wrote: > > > > > > > > Am Donnersta

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Ilia Mirkin
On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > > > On Thu, Nov 1, 2018 at 10:31 AM Ge

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny > > a.co > > > m> wrote: > > > > > > > > Am Donnersta

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Ilia Mirkin
On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > > > So ... thinking about this a littl

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > > So ... thinking about this a little more ... how is the new > > > enable > > > different from the e

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Ilia Mirkin
On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > So ... thinking about this a little more ... how is the new enable > > different from the existing "EXT_framebuffer_sRGB" enable? When would > > one be set but not the other?

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > So ... thinking about this a little more ... how is the new enable > different from the existing "EXT_framebuffer_sRGB" enable? When would > one be set but not the other? This one is a GLES extension, there, if the surface attached

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Ilia Mirkin
So ... thinking about this a little more ... how is the new enable different from the existing "EXT_framebuffer_sRGB" enable? When would one be set but not the other? On Thu, Nov 1, 2018 at 7:30 AM Gert Wollny wrote: > > From: Gert Wollny > > Dear all, > > yet another update, only to the Gallium

[Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

2018-11-01 Thread Gert Wollny
From: Gert Wollny Dear all, yet another update, only to the Gallium part: i.e. the format check was simplified according to Mareks comment, Best, Gert Gert Wollny (3): mesa/core: Add support for EXT_sRGB_write_control mesa/st: enable EXT_sRGB_write_control for Gallium drivers that