On Wed, Jan 23, 2019 at 7:33 AM Sergii Romantsov
wrote:
> Hello, Jason. Sorry for belated answer.
> Why length of 1 was selected: primary type SpvOpTypeBool is already using
> length 1 (and description "For Workgroup pointers, this is the size of the
> referenced type.").
>
> Additionally with le
Hello, Jason. Sorry for belated answer.
Why length of 1 was selected: primary type SpvOpTypeBool is already using
length 1 (and description "For Workgroup pointers, this is the size of the
referenced type.").
Additionally with length of 4 CI gives 3 failed tests:
https://mesa-ci.01.org/global_logi
I think this is probably mostly ok. There's still some question about
exactly what gets stored there and who is storing it.
On Thu, Jan 17, 2019 at 4:34 AM apinheiro wrote:
> I was waiting Jason to chime in, but just in case he is too busy I took
> a look in detail to the patch. It LGTM, so ass
I was waiting Jason to chime in, but just in case he is too busy I took
a look in detail to the patch. It LGTM, so assuming it passes intel CI:
Reviewed-by: Alejandro Piñeiro
On 15/1/19 12:08, Sergii Romantsov wrote:
During conversion type-length was lost due to math.
CC: Jason Ekstrand
Fix
Just tested it with the ARB_gl_spirv tests where I found this:
Tested-by: Alejandro Piñeiro
On 15/1/19 12:08, Sergii Romantsov wrote:
During conversion type-length was lost due to math.
CC: Jason Ekstrand
Fixes: 44227453ec03 (nir: Switch to using 1-bit Booleans for almost everything)
Bugzil
During conversion type-length was lost due to math.
CC: Jason Ekstrand
Fixes: 44227453ec03 (nir: Switch to using 1-bit Booleans for almost everything)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109353
Signed-off-by: Sergii Romantsov
---
src/compiler/spirv/spirv_to_nir.c | 9 ++--
