Re: [Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

2019-06-17 Thread Boris Brezillon
On Mon, 17 Jun 2019 07:09:16 -0700 Alyssa Rosenzweig wrote: > > No problem, I'll rebase once this work has landed. > > I thought it has? Then it's all good (I'm based on mesa master from today, and just fetched/rebased 2 minutes ago to make sure I had everything). > > > Hm, the list of allo

Re: [Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

2019-06-17 Thread Alyssa Rosenzweig
> No problem, I'll rebase once this work has landed. I thought it has? > Hm, the list of allowed ops is likely to differ (doesn't make sense to > allow txs instructions when building a midgard tex instruction) so I'm > not sure it's a good idea to share this switch statement. Well, I was maybe m

Re: [Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

2019-06-17 Thread Boris Brezillon
On Mon, 17 Jun 2019 06:56:11 -0700 Alyssa Rosenzweig wrote: > This conflicts with texture bias/LOD work (in a functional sense, not > a git sense). No problem, I'll rebase once this work has landed. > We can probably reuse the switch from the previous > function rather than duplicating the op l

Re: [Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

2019-06-17 Thread Alyssa Rosenzweig
This conflicts with texture bias/LOD work (in a functional sense, not a git sense). We can probably reuse the switch from the previous function rather than duplicating the op list :) signature.asc Description: PGP signature ___ mesa-dev mailing list mes

[Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

2019-06-17 Thread Boris Brezillon
Right now the failure happens when building the midgard texture instruction. Since we're about to add support for texop_txs (texture size) which is does not involve the creation of a texture instruction, let's add a instr->op check at the beginning of the emit_tex() function so we can easily branch