Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-20 Thread Dave Airlie
On 21 July 2015 at 08:50, Marek Olšák wrote: > If the extension is core only, we can rip out the checks, but the > checks that test ctx->API == API_OPEGL_CORE should stay (if they are > missing, they should be added). > I've reconsidered this, and I'm sticking with my original plan, NIR and the i

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-20 Thread Marek Olšák
If the extension is core only, we can rip out the checks, but the checks that test ctx->API == API_OPEGL_CORE should stay (if they are missing, they should be added). Marek On Thu, Jul 9, 2015 at 3:27 PM, Roland Scheidegger wrote: > Should expose that only if hw has glsl 130 support? > > Roland

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-09 Thread Roland Scheidegger
Should expose that only if hw has glsl 130 support? Roland Am 09.07.2015 um 09:17 schrieb Dave Airlie: > From: Dave Airlie > > I'm not sure if we shouldn't enable this everywhere > and rip out the API checks, > > discuss, > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_exte

[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-07-09 Thread Dave Airlie
From: Dave Airlie I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-06-01 Thread Marek Olšák
In that case, it should use the ARB_gpu_shader5 enable bit. Marek On Mon, Jun 1, 2015 at 5:41 AM, Kenneth Graunke wrote: > On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: >> From: Dave Airlie >> >> I'm not sure if we shouldn't enable this everywhere >> and rip out the API checks, >> >>

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-06-01 Thread Steven Newbury
On Sun, 2015-05-31 at 20:41 -0700, Kenneth Graunke wrote: > On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: > > From: Dave Airlie > > > > I'm not sure if we shouldn't enable this everywhere > > and rip out the API checks, > > > > discuss, > > > > Signed-off-by: Dave Airlie > > --- > >

Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-05-31 Thread Kenneth Graunke
On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: > From: Dave Airlie > > I'm not sure if we shouldn't enable this everywhere > and rip out the API checks, > > discuss, > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_extensions.c | 1 + > 1 file changed, 1 insertion(+)

[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine

2015-05-31 Thread Dave Airlie
From: Dave Airlie I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker