Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Alyssa Rosenzweig
> We need a wrapper that contains a BO plus a pb_slab object for > SLAB-based allocations (allocation of sub-page-size objects), that's > exactly what panfrost_memory is right now. We can rename it if you > like, but I don't think we can get rid of it. Eventually I do think we'll want to toss thes

Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Tomeu Vizoso
On Tue, 2 Jul 2019 at 17:02, Boris Brezillon wrote: > > On Tue, 2 Jul 2019 16:54:22 +0200 > Tomeu Vizoso wrote: > > > On Tue, 2 Jul 2019 at 15:24, Boris Brezillon > > wrote: > > > > > > There's no point duplicating the code, and it will help us simplify > > > the bo_handles[] filling logic in pa

Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Boris Brezillon
On Tue, 2 Jul 2019 16:54:22 +0200 Tomeu Vizoso wrote: > On Tue, 2 Jul 2019 at 15:24, Boris Brezillon > wrote: > > > > There's no point duplicating the code, and it will help us simplify > > the bo_handles[] filling logic in panfrost_drm_submit_job(). > > Looks good but, could we drop panfrost

Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Tomeu Vizoso
On Tue, 2 Jul 2019 at 15:24, Boris Brezillon wrote: > > There's no point duplicating the code, and it will help us simplify > the bo_handles[] filling logic in panfrost_drm_submit_job(). Looks good but, could we drop panfrost_memory completely? Other drivers seem to do fine wthout such a thing.

Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Alyssa Rosenzweig
R-b, thank you! On Tue, Jul 02, 2019 at 03:23:52PM +0200, Boris Brezillon wrote: > There's no point duplicating the code, and it will help us simplify > the bo_handles[] filling logic in panfrost_drm_submit_job(). > > Signed-off-by: Boris Brezillon > --- > src/gallium/drivers/panfrost/pan_alloc

[Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Boris Brezillon
There's no point duplicating the code, and it will help us simplify the bo_handles[] filling logic in panfrost_drm_submit_job(). Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_allocate.c | 21 +++--- src/gallium/drivers/panfrost/pan_allocate.h | 22 -- src/gallium/dr