Re: [Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-17 Thread Jason Ekstrand
On Dec 17, 2014 7:43 AM, "Connor Abbott" wrote: > > On Wed, Dec 17, 2014 at 6:52 AM, Jason Ekstrand wrote: > > > > > > On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott wrote: > >> > >> As a future cleanup, would it be worth getting rid of fddx and fddy > >> entirely and just generating the correc

Re: [Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-17 Thread Connor Abbott
On Wed, Dec 17, 2014 at 6:52 AM, Jason Ekstrand wrote: > > > On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott wrote: >> >> As a future cleanup, would it be worth getting rid of fddx and fddy >> entirely and just generating the correct variant based on the >> glHint/drirc configuration? > > > Nope.

Re: [Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-17 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott wrote: > > As a future cleanup, would it be worth getting rid of fddx and fddy > entirely and just generating the correct variant based on the > glHint/drirc configuration? > Nope. https://www.opengl.org/registry/specs/ARB/derivative_control.txt

Re: [Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-16 Thread Connor Abbott
As a future cleanup, would it be worth getting rid of fddx and fddy entirely and just generating the correct variant based on the glHint/drirc configuration? On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opcodes.h | 4 > 1 file changed, 4 insertions(+) > >

[Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-15 Thread Jason Ekstrand
--- src/glsl/nir/nir_opcodes.h | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_opcodes.h b/src/glsl/nir/nir_opcodes.h index bee4bd1..9a7a2ab 100644 --- a/src/glsl/nir/nir_opcodes.h +++ b/src/glsl/nir/nir_opcodes.h @@ -111,6 +111,10 @@ UNOP(fcos_reduced, nir_type_float) /*