Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-03-19 Thread Martin Peres
Bump. I would really like to push this series ASAP and I only have a few patches without R-b. On 16/02/15 16:13, Martin Peres wrote: Maybe this should be the job of the dispatch layer. Signed-off-by: Martin Peres --- src/mesa/main/multisample.c | 9 + 1 file changed, 9 insertions(+

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-23 Thread Martin Peres
On 23/02/15 17:35, Jason Ekstrand wrote: People do tend to use page numbers from what I've seen. Yes, it has the potential to get out-of-sync but probably never by more than a page or two. I don't thnk spec updates are all that substantial, especially in older versions. You could also give a

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-23 Thread Jason Ekstrand
On Mon, Feb 23, 2015 at 12:51 AM, Martin Peres wrote: > On 20/02/15 20:38, Laura Ekstrand wrote: > >> Please provide a page number and a section title in your spec comment. >> > > I'm not very fond of giving the page number as Khronos updates the pdf > quite often > and the page number may change

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-23 Thread Martin Peres
On 20/02/15 20:57, Ilia Mirkin wrote: On Mon, Feb 16, 2015 at 9:13 AM, Martin Peres wrote: Maybe this should be the job of the dispatch layer. Signed-off-by: Martin Peres --- src/mesa/main/multisample.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/multisample.

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-23 Thread Martin Peres
On 20/02/15 20:38, Laura Ekstrand wrote: Please provide a page number and a section title in your spec comment. I'm not very fond of giving the page number as Khronos updates the pdf quite often and the page number may change. Since I see so little people write the pdf page number, is there

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-20 Thread Ilia Mirkin
On Mon, Feb 16, 2015 at 9:13 AM, Martin Peres wrote: > Maybe this should be the job of the dispatch layer. > > Signed-off-by: Martin Peres > --- > src/mesa/main/multisample.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-20 Thread Laura Ekstrand
Please provide a page number and a section title in your spec comment. Thanks. On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > Maybe this should be the job of the dispatch layer. > > Signed-off-by: Martin Peres > --- > src/mesa/main/multisample.c | 9 + > 1 file changed, 9 inse

[Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

2015-02-16 Thread Martin Peres
Maybe this should be the job of the dispatch layer. Signed-off-by: Martin Peres --- src/mesa/main/multisample.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index 1f3fa0c..a0a659b 100644 --- a/src/mesa/main/multisample.c +