Re: [Mesa-dev] [PATCH 0/6] Gallivm GS and related cleanups

2013-03-27 Thread Zack Rusin
> Wow, that's a lot of code to digest, but it looks good AFAICT (without > spending hours on it). I just found some minor nits. > > Nice work! > > Reviewed-by: Brian Paul Thanks Brian! I'm sorry about the large patch, it was one of those "just sit down and do it" types of coding sessions and b

Re: [Mesa-dev] [PATCH 0/6] Gallivm GS and related cleanups

2013-03-27 Thread Brian Paul
On 03/26/2013 10:38 AM, Zack Rusin wrote: This set implements code generation of geometry shaders in the LLVM paths. There are some cleanups that will follow (e.g. changing the input array to handle lp_native vectors and not TGSI_NUM_CHANNELS) but all the simple examples are working and as far as

[Mesa-dev] [PATCH 0/6] Gallivm GS and related cleanups

2013-03-26 Thread Zack Rusin
This set implements code generation of geometry shaders in the LLVM paths. There are some cleanups that will follow (e.g. changing the input array to handle lp_native vectors and not TGSI_NUM_CHANNELS) but all the simple examples are working and as far as I can tell there's no regressions in the co