Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-11 Thread Nicolai Hähnle
On 07.09.2017 15:07, Bas Nieuwenhuizen wrote: On Thu, Sep 7, 2017, at 14:52, Nicolai Hähnle wrote: On 07.09.2017 12:26, Dave Airlie wrote: On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" mailto:nhaeh...@gmail.com>> wrote: On 07.09.2017 09 :58, Bas Nieuwenhuizen wrote: I'm not reall

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-07 Thread Bas Nieuwenhuizen
On Thu, Sep 7, 2017, at 14:52, Nicolai Hähnle wrote: > On 07.09.2017 12:26, Dave Airlie wrote: > > > > > > On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" > > wrote: > > > > On 07.09.2017 09 :58, Bas Nieuwenhuizen wrote: > > > > I'm not really happy with this,

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-07 Thread Nicolai Hähnle
On 07.09.2017 12:26, Dave Airlie wrote: On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" > wrote: On 07.09.2017 09 :58, Bas Nieuwenhuizen wrote: I'm not really happy with this, what happens if a game actually uses e.g. indirect count in a secon

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-07 Thread Dave Airlie
On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" wrote: On 07.09.2017 09:58, Bas Nieuwenhuizen wrote: > I'm not really happy with this, what happens if a game actually uses > e.g. indirect count in a secondary cmd buf? > Note that some packets that require fetching data in the CP cannot be run in seco

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-07 Thread Nicolai Hähnle
On 07.09.2017 09:58, Bas Nieuwenhuizen wrote: I'm not really happy with this, what happens if a game actually uses e.g. indirect count in a secondary cmd buf? Note that some packets that require fetching data in the CP cannot be run in secondary command buffers, because the data fetching path

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-07 Thread Bas Nieuwenhuizen
I'm not really happy with this, what happens if a game actually uses e.g. indirect count in a secondary cmd buf? That said this patch seems correct, so Reviewed-by: Bas Nieuwenhuizen You may want to nominate this for stable (and provide a backport probably..) On Thu, Sep 7, 2017, at 05:03, Da

[Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

2017-09-06 Thread Dave Airlie
From: Dave Airlie This fixes some observed hangs on CIK GPUs. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_b