Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Kenneth Graunke
On Monday, September 21, 2015 09:24:17 AM Jason Ekstrand wrote: > On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke > wrote: > > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: > >> Designated initializers are not allowed in C++ (not even C++11). Since > >> nir_lower_samplers is n

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Jason Ekstrand
On Mon, Sep 21, 2015 at 9:24 AM, Matt Turner wrote: > On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke > wrote: >> On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >>> Designated initializers are not allowed in C++ (not even C++11). Since >>> nir_lower_samplers is now using nir_b

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Matt Turner
On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke wrote: > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >> Designated initializers are not allowed in C++ (not even C++11). Since >> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in >> C++, this breaks the

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Jason Ekstrand
On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke wrote: > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >> Designated initializers are not allowed in C++ (not even C++11). Since >> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in >> C++, this breaks the

Re: [Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Kenneth Graunke
On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: > Designated initializers are not allowed in C++ (not even C++11). Since > nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in > C++, this breaks the build on some compilers. Aparently, GCC 5 allows it > in some

[Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

2015-09-21 Thread Jason Ekstrand
Designated initializers are not allowed in C++ (not even C++11). Since nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in C++, this breaks the build on some compilers. Aparently, GCC 5 allows it in some limited extent because mesa still builds on my system without this patc