On Mon, Sep 21, 2015 at 9:22 AM, Kenneth Graunke <[email protected]> wrote: > On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote: >> Designated initializers are not allowed in C++ (not even C++11). Since >> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in >> C++, this breaks the build on some compilers. Aparently, GCC 5 allows it >> in some limited extent because mesa still builds on my system without this >> patch. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92052 >> --- >> src/glsl/nir/nir_builder.h | 21 ++++++++++++++++++--- >> 1 file changed, 18 insertions(+), 3 deletions(-) > > I'd rather just take Emil's patch to convert nir_lower_samplers out of > C++, honestly. NIR is in C99, let's keep it that way.
I think Jason's argument was that we'd have to make nir_builder compatible with C++ if we plan to use it with glsl_to_nir, but I agree that we should convert nir_lower_samplers to C regardless. _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
