Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-14 Thread Dylan Baker
Quoting Jon Turney (2017-11-14 04:05:21) > On 13/11/2017 17:41, Dylan Baker wrote: > > I thought I'd fixed this already, > > Reviewed-by: Dylan Baker > > This workaround is already in place for dep_xxf86vm. > > I took a brief look, and didn't see anywhere the same problem could > occur with any

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-14 Thread Jon Turney
On 13/11/2017 17:41, Dylan Baker wrote: I thought I'd fixed this already, Reviewed-by: Dylan Baker This workaround is already in place for dep_xxf86vm. I took a brief look, and didn't see anywhere the same problem could occur with any of the other uses of [] for a dependency. Quoting Jon

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-13 Thread Dylan Baker
I thought I'd fixed this already, Reviewed-by: Dylan Baker Quoting Jon Turney (2017-11-13 02:28:27) > It's ok to use an empty list for dependencies:, but it's not ok to try to > use the found() method of it. > > See also https://github.com/mesonbuild/meson/issues/2324 > > Signed-off-by: Jon Tur

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-13 Thread Eric Engestrom
On Monday, 2017-11-13 10:28:27 +, Jon Turney wrote: > It's ok to use an empty list for dependencies:, but it's not ok to try to > use the found() method of it. > > See also https://github.com/mesonbuild/meson/issues/2324 > > Signed-off-by: Jon Turney Reviewed-by: Eric Engestrom > --- > m

[Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-13 Thread Jon Turney
It's ok to use an empty list for dependencies:, but it's not ok to try to use the found() method of it. See also https://github.com/mesonbuild/meson/issues/2324 Signed-off-by: Jon Turney --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.buil