Re: [Mesa-dev] [PATCH] include: update GL & GLES headers (v2)

2018-08-03 Thread Ian Romanick
Acked-by: Ian Romanick On 08/03/2018 04:03 PM, Marek Olšák wrote: > From: Marek Olšák > > v2: use correct files > --- > include/GL/glcorearb.h | 76 --- > include/GL/glext.h | 85 +++--- > include/GL/glxext.h| 22 +- > include/GLES2/gl2.h| 8

[Mesa-dev] [PATCH] include: update GL & GLES headers (v2)

2018-08-03 Thread Marek Olšák
From: Marek Olšák v2: use correct files --- include/GL/glcorearb.h | 76 --- include/GL/glext.h | 85 +++--- include/GL/glxext.h| 22 +- include/GLES2/gl2.h| 8 +- include/GLES2/gl2ext.h | 161 +++-- include

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-03 Thread Marek Olšák
Sorry, the patch is incorrect. It came from a stale repo of mine, not from opengl-registry. I'll send a new patch. Marek On Fri, Aug 3, 2018 at 2:17 PM, Ian Romanick wrote: > Actually, I'm going to NAK it. :P I was going to submit a Khronos bug, > but I noticed that there are newer header files

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-03 Thread Ian Romanick
Actually, I'm going to NAK it. :P I was going to submit a Khronos bug, but I noticed that there are newer header files (July 25, 2018 vs May 25, 2018) that don't have this weird issue. Can we have those instead? :) See https://github.com/KhronosGroup/OpenGL-Registry/blob/master/api/GL/glext.h.

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Jason Ekstrand
Hooray for less GLvoid. Acked-by: Jason Ekstrand On August 2, 2018 04:16:23 Marek Olšák wrote: From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77 +--- include/GL/glxext.h| 22 -- include/GLES2/gl2.h| 8 +-- includ

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Jason Ekstrand
On August 2, 2018 16:45:55 Ian Romanick wrote: On 08/02/2018 04:40 PM, Ilia Mirkin wrote: On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: On 08/02/2018 02:26 PM, Sagar Ghuge wrote: I have few comments below, I might be wrong about those but except that this patch looks good to me. I c

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ian Romanick
On 08/02/2018 04:40 PM, Ilia Mirkin wrote: > On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: >> On 08/02/2018 02:26 PM, Sagar Ghuge wrote: >>> I have few comments below, I might be wrong about those but except that >>> this patch looks good to me. I checked it against Khronos headers. >>> >>>

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ilia Mirkin
On Thu, Aug 2, 2018 at 7:34 PM, Ian Romanick wrote: > On 08/02/2018 02:26 PM, Sagar Ghuge wrote: >> I have few comments below, I might be wrong about those but except that >> this patch looks good to me. I checked it against Khronos headers. >> >> On 08/01/2018 11:34 AM, Marek Olšák wrote: >>> +

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Ian Romanick
On 08/02/2018 02:26 PM, Sagar Ghuge wrote: > I have few comments below, I might be wrong about those but except that > this patch looks good to me. I checked it against Khronos headers. > > On 08/01/2018 11:34 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >>   include/GL/glcorearb.h |  68

Re: [Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Sagar Ghuge
I have few comments below, I might be wrong about those but except that this patch looks good to me. I checked it against Khronos headers. On 08/01/2018 11:34 AM, Marek Olšák wrote: From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77

[Mesa-dev] [PATCH] include: update GL & GLES headers

2018-08-02 Thread Marek Olšák
From: Marek Olšák --- include/GL/glcorearb.h | 68 -- include/GL/glext.h | 77 +--- include/GL/glxext.h| 22 -- include/GLES2/gl2.h| 8 +-- include/GLES2/gl2ext.h | 159 +++-- include/GLES3/gl3.h| 8 +-