Re: [Mesa-dev] [PATCH] i965/fs: Don't offset uniform registers in half().

2014-12-02 Thread Matt Turner
On Tue, Dec 2, 2014 at 10:11 PM, Jason Ekstrand wrote: > > On Dec 2, 2014 9:19 PM, "Matt Turner" wrote: >> >> Half gives you the second half of a SIMD16 register, but if the register >> is a uniform it would incorrectly give you the next register. > > I'm curious as to where this came up. To my k

Re: [Mesa-dev] [PATCH] i965/fs: Don't offset uniform registers in half().

2014-12-02 Thread Jason Ekstrand
On Dec 2, 2014 9:19 PM, "Matt Turner" wrote: > > Half gives you the second half of a SIMD16 register, but if the register > is a uniform it would incorrectly give you the next register. I'm curious as to where this came up. To my knowledge, the only time that's used, we know it's not a uniform.

[Mesa-dev] [PATCH] i965/fs: Don't offset uniform registers in half().

2014-12-02 Thread Matt Turner
Half gives you the second half of a SIMD16 register, but if the register is a uniform it would incorrectly give you the next register. --- src/mesa/drivers/dri/i965/brw_fs.h | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_