Re: [Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit (v2)

2016-02-02 Thread Marek Olšák
Sadly, this patch doesn't fix NS2, so I'm kinda on the fence about pushing it. Marek On Tue, Feb 2, 2016 at 9:01 PM, Marek Olšák wrote: > From: Marek Olšák > > This might fix mmap errors with Natural Selection 2, which a 32-bit game. > > It would be nice if someone tested this patch with the ga

[Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit (v2)

2016-02-02 Thread Marek Olšák
From: Marek Olšák This might fix mmap errors with Natural Selection 2, which a 32-bit game. It would be nice if someone tested this patch with the game. v2: use sizeof(void*) --- src/gallium/drivers/radeon/r600_texture.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit

2016-02-01 Thread Michel Dänzer
On 01.02.2016 23:20, Marek Olšák wrote: > From: Marek Olšák > > This might fix mmap errors with Natural Selection 2, which a 32-bit game. > > It would be nice if someone tested this patch with the game. > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ > src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit

2016-02-01 Thread Marek Olšák
On Mon, Feb 1, 2016 at 6:59 PM, Axel Davy wrote: > Hi, > > This path is used for vertex buffers as well, right ? No. It's only used by textures. > > Most d3d9 games are 32 bits, I guess your change would slow down a lot of > d3d9 games. > > I suggest rather to really unmap, except if the resourc

Re: [Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit

2016-02-01 Thread Axel Davy
Hi, This path is used for vertex buffers as well, right ? Most d3d9 games are 32 bits, I guess your change would slow down a lot of d3d9 games. I suggest rather to really unmap, except if the resource was already mapped/unmapped, ... say 5 times. That way if the resource is frequently mapp

[Mesa-dev] [PATCH] gallium/radeon: always unmap textures on 32-bit

2016-02-01 Thread Marek Olšák
From: Marek Olšák This might fix mmap errors with Natural Selection 2, which a 32-bit game. It would be nice if someone tested this patch with the game. --- src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++ src/gallium/drivers/radeon/r600_texture.c | 9 + 2 files changed, 15