Re: [Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

2017-11-12 Thread Jason Ekstrand
On Sun, Nov 12, 2017 at 3:29 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 12/11/17 05:45, Jason Ekstrand wrote: > >> The previous iteration algorithm would advance the field pointer right >> after we advance the group. This meant that you would end up with >> skipping the fi

Re: [Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

2017-11-12 Thread Lionel Landwerlin
On 12/11/17 05:45, Jason Ekstrand wrote: The previous iteration algorithm would advance the field pointer right after we advance the group. This meant that you would end up with skipping the first field of the group. In the common case, where the only field is a struct (e.g. 3DSTATE_VERTEX_BUFF

[Mesa-dev] [PATCH] aubinator: Don't skip the first field in each subgroup

2017-11-11 Thread Jason Ekstrand
The previous iteration algorithm would advance the field pointer right after we advance the group. This meant that you would end up with skipping the first field of the group. In the common case, where the only field is a struct (e.g. 3DSTATE_VERTEX_BUFFERS), it would get skipped entirely. --- s