Re: [Mesa-dev] swrast gallium provider doesn't work on Solaris SPARC (Mesa 20 with LLVM 10)

Oh I missed that sparc is big endian. Still not sure where the llvm IR would differ but indeed some different unpacking somewhere could explain things. (And I'd guess we'd get issues reported for other big endian archs soon enough too...) Roland Am 19.05.20 um 22:00 schrieb Adam Jackson: > On We

Re: [Mesa-dev] swrast gallium provider doesn't work on Solaris SPARC (Mesa 20 with LLVM 10)

You can also set LP_DEBUG=tgsi_ir instead (but it will only work in debug builds). No idea though what could go wrong when using NIR, seems fairly strange since there's nothing architecture specific in there (and the generated IR should be fairly similar too especially for simple stuff). Roland

Re: [Mesa-dev] size of LP_MAX_VBUF_SIZE

Am 20.02.20 um 02:45 schrieb Dave Airlie: > Hey, > > Anyone know why LP_MAX_VBUF_SIZE is only 4K? > > Tess submits > 100K verts to the draw pipeline, which start to split > them, due to the 4K size of the above it splits 50 vertices per vbuf, > however it then calls draw_reset_vertex_ids which it

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

So, I'm guilty of being one of the few still using the mailing list... But in any case, certainly I can switch to using MRs if everybody prefers that now (meaning, I'm really indifferent to this). Roland Am 10.12.19 um 00:07 schrieb Dylan Baker: > Hi everyone, > > I think its time we discussed

Re: [Mesa-dev] [PATCH] Revert "draw: revert using correct order for prim decomposition."

Sorry for the delay, I've now pushed this. Roland Am 21.11.19 um 06:31 schrieb Zebediah Figura: > Ping? > > On 11/5/19 10:21 AM, Zebediah Figura wrote: >> This reverts commit f97b731c82afb06cfd6ffebc90a3e098a9a1b308. >> >> Closes: >> https://nam04.safelinks.protection.outlook.com/?url=https%3A

Re: [Mesa-dev] [PATCH] llvmpipe: Check thread creation errors

Looks great to me. Reviewed-by: Roland Scheidegger Am 08.11.19 um 23:05 schrieb Nathan Kidd: > In the case of glibc, pthread_t is internally a pointer. If > lp_rast_destroy() passes a 0-value pthread_t to pthread_join(), the > latter will SEGV dereferencing it. > > pthread_creat

Re: [Mesa-dev] [PATCH] scons: Fix force_scons parsing.

Looks alright to me. Reviewed-by: Roland Scheidegger Am 25.10.19 um 23:12 schrieb Jose Fonseca: > - Use parsed options instead of using ARGUMENTS directly. > - Handle case mingw cross compilation. > --- > SConstruct | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) &g

Re: [Mesa-dev] [PATCH] gallivm: use fallback code for mul_hi with llvm >= 7.0

Am 16.10.19 um 01:20 schrieb Dave Airlie: > On Fri, 30 Aug 2019 at 00:55, Roland Scheidegger wrote: >> >> Am 29.08.19 um 15:05 schrieb Jose Fonseca: >>> This change is >>> >>> Reviewed-by: Jose Fonseca >>> >>> Regarding follow up

Re: [Mesa-dev] [PATCH] llvmpipe: increase max texture size to 2GB

> *From:* srol...@vmware.com > *Sent:* Thursday, October 10, 2019 19:18 > *To:* Jose Fonseca ; mesa-dev@lists.freedesktop.org > > *Cc:* Roland Scheidegger > *Subject:* [PATCH] llvmpipe: increase max texture size to 2GB >   > From: Roland Scheidegger

Re: [Mesa-dev] [PATCH] gallivm: disable accurate cube corner for integer textures.

e_filter && !util_format_is_pure_integer() (maybe with a comment that we should only end up with the linear image path here in case of gather). With that fixed, Reviewed-by: Roland Scheidegger > lp_build_extract_image_sizes(bld, > &bld-

Re: [Mesa-dev] [PATCH] gallivm: use fallback code for mul_hi with llvm >= 7.0

gt; > > *From:* srol...@vmware.com > *Sent:* Wednesday, August 28, 2019 20:37 > *To:* mesa-dev@lists.freedesktop.org ; > Jose Fonseca ; airl...@freedesktop.org > > *Cc:* Roland Scheidegger > *Subject:* [P

Re: [Mesa-dev] [PATCH 4/4] scons: Make GCC builds stricter.

ypes', > +'-Werror=implicit-function-declaration', > +'-Werror=missing-prototypes', > +'-Werror=return-type', > +'-Werror=incompatible-pointer-types', > '-std=gnu99', >

Re: [Mesa-dev] [PATCH] gallivm: fix issue with AtomicCmpXchg wrapper on llvm 3.5-3.8

Am 02.08.19 um 18:54 schrieb Brian Paul: > On 08/02/2019 10:36 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> These versions still need wrapper but already have both success and >> failure ordering. >> (Compile tested on llvm 3.7,

Re: [Mesa-dev] [AppVeyor] mesa master #11902 failed

Am 16.07.19 um 20:55 schrieb AppVeyor: > > Build mesa 11902 failed > Commit 856e84083e by Rob Clark on > 7/15/2019 4:05 PM: > mesa/st: add sampler uniforms\n\nAdd sampler uniforms for the UV > plane(s), so driver can count the\nuniforms and get the correct sampler

Re: [Mesa-dev] [PATCH] gallivm: Improve lp_build_rcp_refine.

Looks good to me, albeit it's potentially minimally slower, so I'm wondering if the higher precision is actually useful? I guess though the last two steps could use lp_build_fmuladd? Reviewed-by: Roland Scheidegger Am 25.06.19 um 11:17 schrieb Jose Fonseca: > Use the alternative

Re: [Mesa-dev] [PATCH] llvmpipe: make remove_shader_variant static.

Reviewed-by: Roland Scheidegger Am 19.06.19 um 22:47 schrieb Dave Airlie: > From: Dave Airlie > > this isn't used outside this file. > --- > src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +- > src/gallium/drivers/llvmpipe/lp_state_fs.h | 4 > 2 files changed, 1

Re: [Mesa-dev] [PATCH] gallivm: fix default cbuf info.

Am 27.05.19 um 11:39 schrieb Juan A. Suarez Romero: > On Fri, 2019-05-24 at 03:08 +0200, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The default null_output really needs to be static, otherwise the values >> we'll eventually get later are doubly

Re: [Mesa-dev] [PATCH 5/5] gallium/util: fix two MSVC compiler warnings

For the series: Reviewed-by: Roland Scheidegger Am 04.05.19 um 18:07 schrieb Brian Paul: > Remove stray const qualifier. > s/unsigned/enum tgsi_semantic/ > --- > src/gallium/auxiliary/util/u_format_zs.h | 2 +- > src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++-- >

Re: [Mesa-dev] [PATCH] llvmpipe: init some vars to NULL to silence MinGW compiler warnings

Reviewed-by: Roland Scheidegger Am 01.05.19 um 18:48 schrieb Brian Paul: > --- > src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_s3tc.c > b/src/gallium

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

Am 15.04.19 um 13:55 schrieb Dominik Drees: > On 4/12/19 5:32 PM, Roland Scheidegger wrote: >> Am 12.04.19 um 14:34 schrieb Dominik Drees: >>> Hi Roland! >>> >>> On 4/11/19 8:18 PM, Roland Scheidegger wrote: >>>> What version of mesa are you usin

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

Looks correct to me. For the series, Reviewed-by: Roland Scheidegger Am 11.04.19 um 18:05 schrieb Emil Velikov: > The function is analogous to lp_fence_wait() while taking at timeout > (ns) parameter, as needed for EGL fence/sync. > > Cc: Roland Scheidegger > Signed-off-b

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

Am 12.04.19 um 14:34 schrieb Dominik Drees: > Hi Roland! > > On 4/11/19 8:18 PM, Roland Scheidegger wrote: >> What version of mesa are you using? > The original results were generated using version 19.0.2 (from the arch > linux repositories), but I got the same results

Re: [Mesa-dev] Low interpolation precision for 8 bit textures using llvmpipe

What version of mesa are you using? The debug flags were changed a while ago (so that those perf tweaks can be disabled on release builds too), it needs to be either: GALLIVM_PERF=no_rho_approx,no_brilinear,no_quad_lod or easier GALLIVM_PERF=no_filter_hacks (which disables these 3 things above toge

Re: [Mesa-dev] [PATCH 1/2] draw: fix undefined shift of (1 << 31)

For the series, and the other one (undefined shifts in swrast/draw), Reviewed-by: Roland Scheidegger Am 11.04.19 um 12:32 schrieb Dave Airlie: > From: Dave Airlie > > Pointed out by a coverity scan. > --- > src/gallium/auxiliary/draw/draw_pipe_aapoint.c | 2 +- > 1 file ch

Re: [Mesa-dev] [PATCH 5/5] softpipe: add support for vertex streams

think technically you should make this dependent on !sp_screen->use_llvm (unless you want to fix the llvm paths :-)). For the series: Reviewed-by: Roland Scheidegger > case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE: >return 2048; > case PIPE_CAP_PRIMITIVE_RESTART: > _

Re: [Mesa-dev] [PATCH 1/2] softpipe/draw: fix vertex id in soft paths.

unsigned vid = > machine->SysSemanticToIndex[TGSI_SEMANTIC_VERTEXID_NOBASE]; > assert(vid < ARRAY_SIZE(machine->SystemValue)); > -machine->SystemValue[vid].xyzw[0].i[j] = i + j; > +machine->SystemValue[vid].xyzw[0].

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

Looks alright to me, it's all quite tricky stuff... Reviewed-by: Roland Scheidegger Am 22.03.19 um 20:51 schrieb Brian Paul: > When we destroy a context, we need to temporarily make that context > the current one for the thread. > > That's because during context tear-down

Re: [Mesa-dev] [PATCH 2/2] softpipe: handle 32-bit bitfield inserts

k) | (src0->u[i] & > ~bitmask); > + } > } > } > > I think this is a really highly annoying difference between d3d11 and GL there for bitfieldInsert/Extract... But in any case, all 4 patches look good to me. Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: implement "zombie" sampler views (v2)

Reviewed-by: Roland Scheidegger Am 15.03.19 um 22:12 schrieb Brian Paul: > When st_texture_release_all_sampler_views() is called the texture may > have sampler views belonging to several contexts. If we unreference a > sampler view and its refcount hits zero, we need to be sure to dest

Re: [Mesa-dev] [PATCH 1/9] gallium/u_math: add ushort_to_float/float_to_ushort

Am 16.03.19 um 02:28 schrieb Qiang Yu: > Signed-off-by: Qiang Yu > --- > src/util/u_math.h | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/src/util/u_math.h b/src/util/u_math.h > index e7dbbe5ca22..ffadfb47282 100644 > --- a/src/util/u_math.h > +++ b/src

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Am 15.03.19 um 02:18 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 22:06 schrieb Rob Clark: >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger >>> wrote: >>>> >>>> Am 14.03.19 um

Re: [Mesa-dev] [PATCH 8/8] gallium/util: remove pipe_sampler_view_release()

This looks all good to me. For the series: Reviewed-by: Roland Scheidegger Am 14.03.19 um 20:37 schrieb Brian Paul: > It's no longer used. > --- > src/gallium/auxiliary/util/u_inlines.h | 20 > 1 file changed, 20 deletions(-) > > diff --git a/src

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Am 14.03.19 um 22:06 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 14:13 schrieb Rob Clark: >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger >>> wrote: >>>> >>>> Am 12.03.19

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Am 14.03.19 um 14:13 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: >> >> Am 12.03.19 um 16:16 schrieb Rob Clark: >>> This previously was not called out clearly, but based on a survey of the >>> code, it seems the expected behavi

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Am 12.03.19 um 22:48 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: >> >> Am 12.03.19 um 16:16 schrieb Rob Clark: >>> This previously was not called out clearly, but based on a survey of the >>> code, it seems the expected behavi

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

Am 12.03.19 um 16:16 schrieb Rob Clark: > This previously was not called out clearly, but based on a survey of the > code, it seems the expected behavior is to release the reference to any > sampler views beyond the new range being bound. That isn't really true. This was designed to work like d3d1

Re: [Mesa-dev] [PATCH] st/mesa: init hash keys with memset(), not designated initializers

Am 12.03.19 um 18:34 schrieb Eric Anholt: > Ilia Mirkin writes: > >> I believe the distinction here is between initializing all the fields >> and using them individually (thus leaving the padding uninitialized), >> vs using the fields to create a structure to hash as a sequence of >> bytes. For t

Re: [Mesa-dev] [PATCH] st/mesa: init hash keys with memset(), not designated initializers

Reviewed-by: Roland Scheidegger Am 08.03.19 um 18:14 schrieb Brian Paul: > Since the compiler may not zero-out padding in the object. > Add a couple comments about this to prevent misunderstandings in > the future. > > Fixes: 67d96816ff5 ("st/mesa: move, clean-up shader var

Re: [Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

Am 07.03.19 um 17:20 schrieb Brian Paul: > Move the variant key declarations inside the scope they're used. > Use designated initializers instead of memset() calls. I don't think this will always work as intended, since there's non-explicit padding bits in the key, and AFAIK even with c11 compilers

Re: [Mesa-dev] [PATCH] gallium: Add PIPE_BARRIER_UPDATE_BUFFER and UPDATE_TEXTURE bits.

The idea seems reasonable to me (albeit I think having so many different barrier bits in the API in the first place is likely to cause apps to slightly misuse them...). Drivers which don't need to care can always ignore it. Roland Am 06.03.19 um 09:32 schrieb Kenneth Graunke: > The glMemoryBarr

Re: [Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

Am 01.03.19 um 00:28 schrieb Gurchetan Singh: > On Thu, Feb 28, 2019 at 12:39 AM Boris Brezillon > wrote: >> >> Hello Gurchetan, >> >> On Wed, 27 Feb 2019 10:34:26 -0800 >> Gurchetan Singh wrote: >> >>> On Mon, Feb 25, 2019 at 12:35 AM Boris Brezillon >>> wrote: From: Daniel Stone >>>

Re: [Mesa-dev] [PATCH] scons: Workaround failures with MSVC when using SCons 3.0.[2-4].

n < distutils.version.StrictVersion('3.0.2') or \ > + scons_version > distutils.version.StrictVersion('3.0.4'): > +env.Decider('MD5-timestamp') > env.SetOption('max_drift', 60) > > # C preprocessor options > Reviewe

Re: [Mesa-dev] [PATCH] gallium: allow more PIPE_RESOURCE_ driver flags

Looks ok to me, there's still a few bits left luckily... Reviewed-by: Roland Scheidegger Am 30.01.19 um 20:21 schrieb Marek Olšák: > From: Marek Olšák > > radeonsi has 8 and will probably have 9 soon. > --- > src/gallium/include/pipe/p_defines.h | 2 +- > 1 file cha

Re: [Mesa-dev] [PATCH] nir: Optimize double-precision lower_round_even()

Am 29.01.19 um 10:10 schrieb Erik Faye-Lund: > On Mon, 2019-01-28 at 09:31 -0800, Matt Turner wrote: >> Use the trick of adding and then subtracting 2**52 (52 is the number >> of >> explicit mantissa bits a double-precision floating-point value has) >> to >> implement round-to-even. >> >> Cuts the

Re: [Mesa-dev] [PATCH] nir: Optimize double-precision lower_round_even()

hen it probably won't round at all (at least I think it would be legal to eliminate the add/sub in this case). So I'm not entirely sure anymore if this can be used unconditionally. But I can't really tell if those potential caveats actually matter, hence Reviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH 2/2] gallivm: Return true from arch_rounding_available() if NEON is available

I have no clue on aarch64, but looks all good to me. For the series: Reviewed-by: Roland Scheidegger Am 23.01.19 um 00:12 schrieb Matt Turner: > LLVM uses the single instruction "FRINTI" to implement llvm.nearbyint. > Fixes the rounding tests of lp_test_arit. > >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

Am 11.01.19 um 23:28 schrieb Ilia Mirkin: > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: >> >> From: Gert Wollny >> >> Since Meson will eventually be the only build system deprecate autotools >> now. It can still be used by invoking configure with the flag >> --enable-autotools >> >> NAKe

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Am 10.01.19 um 04:51 schrieb Tomasz Figa: > Hi Roland, > > On Thu, Jan 10, 2019 at 1:36 AM Roland Scheidegger wrote: >> >> Sorry but I had to revert this, as we've seen lots of assertion failures >> (src/gallium/drivers/llvmpipe/lp_fence.c:120: lp_fence_wait:

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

Am 08.01.19 um 21:03 schrieb Marek Olšák: > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger <mailto:srol...@vmware.com>> wrote: > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák mailto:marek.ol...@amd.com>> > > >

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

ove the assert or if it needs some more work, and I don't have time right now for a thorough investigation, but I'll happily take new patches... Roland Am 09.01.19 um 02:09 schrieb Roland Scheidegger: > Am 07.01.19 um 09:54 schrieb Tomasz Figa: >> On Sun, Dec 23, 2018

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Am 07.01.19 um 09:54 schrieb Tomasz Figa: > On Sun, Dec 23, 2018 at 12:55 AM Roland Scheidegger > wrote: >> >> Alright, I guess it should work... >> >> Reviewed-by: Roland Scheidegger >> > > Thanks! > > Would we have anyone who could help to c

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

Am 08.01.19 um 17:17 schrieb Marek Olšák: > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context objects. Well they are supposed to

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

Am 03.01.19 um 20:50 schrieb Jason Ekstrand: > > The problem you're describing is in converting from NIR to another IR, > > not to hardware.  In LLVM they made a choice to put types on SSA > values > > but then to have the actual semantics be based on the instruction > > itself.

Re: [Mesa-dev] NIR constant problem for GPU which doesn't have native integer support

Am 03.01.19 um 18:58 schrieb Jason Ekstrand: > On Thu, Jan 3, 2019 at 3:39 AM Erik Faye-Lund > mailto:erik.faye-l...@collabora.com>> wrote: > > On Wed, 2019-01-02 at 10:16 -0600, Jason Ekstrand wrote: > > On Wed, Jan 2, 2019 at 9:43 AM Ilia Mirkin > >

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Alright, I guess it should work... Reviewed-by: Roland Scheidegger Am 14.12.18 um 09:17 schrieb Tomasz Figa: > If there is no last fence, due to no rendering happening yet, just > create a new signaled fence and return it, to match the expectations of > the EGL sync fence API. &

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

Am 22.12.18 um 01:21 schrieb Ilia Mirkin: > > > On Fri, Dec 21, 2018, 19:16 Marek Olšák wrote: > > > > On Fri, Dec 21, 2018, 6:28 PM Kenneth Graunke wrote: > > That seems like a reasonable interface to me. > >

Re: [Mesa-dev] [PATCH] gallivm: abort when trying to use non-existing intrinsic

Am 21.12.18 um 15:30 schrieb Jose Fonseca: > On 21/12/2018 14:28, Roland Scheidegger wrote: >> Am 21.12.18 um 08:46 schrieb Jose Fonseca: >>> On 21/12/2018 01:42, srol...@vmware.com wrote: >>>> From: Roland Scheidegger >>>> >>>> Whenever

Re: [Mesa-dev] [PATCH] gallivm: abort when trying to use non-existing intrinsic

Am 21.12.18 um 08:46 schrieb Jose Fonseca: > On 21/12/2018 01:42, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Whenever llvm removes an intrinsic (we're using), we're hitting segfaults >> due to llvm doing calls to address 0 in the jitted code

Re: [Mesa-dev] [PATCH] gallivm: use llvm jit code for decoding s3tc

it > to trap unsupported intrinsics? > > Jose > > On 20/12/2018 22:09, Roland Scheidegger wrote: >> Am 20.12.18 um 16:56 schrieb Michel Dänzer: >>> On 2018-12-19 4:51 a.m., srol...@vmware.com wrote: >>>> From: Roland Scheidegger >>>> >&

Re: [Mesa-dev] [PATCH] gallivm: use llvm jit code for decoding s3tc

Am 20.12.18 um 16:56 schrieb Michel Dänzer: > On 2018-12-19 4:51 a.m., srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This is (much) faster than using the util fallback. >> (Note that there's two methods here, one would use a cache, similar to >>

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

Fix looks good to me. Reviewed-by: Roland Scheidegger Am 19.12.18 um 04:50 schrieb Ilia Mirkin: > Not sure if this ever worked, but the current logic for setting the > min/max index is definitely wrong for indexed draws. While we're at it, > bring in all the usual logic from th

Re: [Mesa-dev] [PATCH] gallivm: use llvm jit code for decoding s3tc

Am 19.12.18 um 08:35 schrieb Jose Fonseca: > On 19/12/2018 03:51, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This is (much) faster than using the util fallback. >> (Note that there's two methods here, one would use a cache, similar to >> the

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

Am 17.12.18 um 23:27 schrieb Roland Scheidegger: > Am 17.12.18 um 23:07 schrieb Ilia Mirkin: >> On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: >>> >>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fmerge

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

Am 17.12.18 um 23:07 schrieb Ilia Mirkin: > On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: >> >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fmerge_requests%2F22&data=02%7C01%7Csroland%40vmware.com%7C5773f37aa397417e6beb08d6646c24c6%7

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

Am 15.12.18 um 22:39 schrieb Ilia Mirkin: > On Sat, Dec 15, 2018 at 4:12 PM Kenneth Graunke wrote: >> >> On Saturday, December 15, 2018 9:10:46 AM PST Ilia Mirkin wrote: >>> On Sat, Dec 15, 2018 at 4:45 AM Kenneth Graunke >>> wrote: Gallium handles pipeline statistics queries as a single qu

Re: [Mesa-dev] [PATCH 4/6] mesa/st: wire up DiscardSubFramebuffer

Am 11.12.18 um 23:50 schrieb Rob Clark: > Signed-off-by: Rob Clark > --- > src/gallium/include/pipe/p_context.h | 11 +++ > src/mesa/state_tracker/st_cb_fbo.c | 26 ++ > 2 files changed, 37 insertions(+) > > diff --git a/src/gallium/include/pipe/p_context.h > b

Re: [Mesa-dev] [PATCH 3/6] mesa/st: wire up DiscardFramebuffer

Am 11.12.18 um 23:50 schrieb Rob Clark: > pipe_context::invalidate_resource() is so *almost* what we want, but > with FBOs the fb can be a single layer/level of a pipe_resource, which > makes ::invalidate_resource() not expressive enough. > > Signed-off-by: Rob Clark > --- > src/gallium/include/

Re: [Mesa-dev] [PATCH] gallium/aux: add is_unorm() helper

Am 11.12.18 um 22:21 schrieb Ilia Mirkin: > So ... Z24 will end up with is_unorm() == true? [Just guessing -- > assume it doesn't hae is_mixed == true.] Z24X8 would return true, but Z24S8 would return false. (If you didn't want that I guess you could check for colorspace.) > Also, does RGB10A2 hav

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

Am 11.12.18 um 10:37 schrieb Mathias Fröhlich: > > Hey, > > On Tuesday, 11 December 2018 10:19:47 CET Erik Faye-Lund wrote: >> On Mon, 2018-12-10 at 18:23 +0100, Mathias Fröhlich wrote: >>> Hi Erik, >>> >>> Not sure if this is our problem as I think that I only saw simple >>> bindings with a zero

Re: [Mesa-dev] [PATCH 11/28] util: added float to float16 conversions with RTZ and RTNE

Am 07.12.18 um 05:22 schrieb Matt Turner: > On Thu, Dec 6, 2018 at 7:22 PM Roland Scheidegger wrote: >> >> Am 07.12.18 um 03:20 schrieb Matt Turner: >>> Since this is for an extension that will be BDW+ can we use the >>> _cvtss_sh() intrinsic instead? It correspon

Re: [Mesa-dev] [PATCH 11/28] util: added float to float16 conversions with RTZ and RTNE

Am 07.12.18 um 03:20 schrieb Matt Turner: > Since this is for an extension that will be BDW+ can we use the > _cvtss_sh() intrinsic instead? It corresponds to an IVB+ instruction > and even takes the rounding mode directly as an immediate argument. Not saying trying to use it isn't a good idea, bu

Re: [Mesa-dev] [PATCH] gallivm: Use nextafterf(0.5, 0.0) as rounding constant

nextafterf(0.5, 0.0) instead of 0.5 before > truncating. This works for all values. Reviewed-by: Roland Scheidegger Although this will still do round-to-nearest-away-from-zero, instead of nearest-even which we probably want. That said, I don't think it matters anywhere - d3d10 round will r

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

To: Dylan Baker Cc: Roland Scheidegger; ML mesa-dev; erik.faye-l...@collabora.com Subject: Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf On Fri, Nov 16, 2018 at 10:34 AM Dylan Baker wrote: > > Quoting Roland Scheidegger (2018-11-13 18:41:00) > > Am 14.11.18

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

FWIW this looks like a rather similar incident to me what happened when mesa began to verify the max vertex stride (which needs to be 2048 with GL 4.4 whereas r600 can only do 2047) where I argued it's a much better idea to lie about the GL version there rather than the specific vertex stride bi

Re: [Mesa-dev] [PATCH] r600: clean up the GS ring buffers when the context is destroyed

Reviewed-by: Roland Scheidegger From: mesa-dev on behalf of Gert Wollny Sent: Friday, November 16, 2018 6:06:15 PM To: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] r600: clean up the GS ring buffers when the context is destroyed I

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Am 14.11.18 um 03:21 schrieb Matt Turner: > On Tue, Nov 13, 2018 at 6:03 PM Roland Scheidegger wrote: >> >> Am 13.11.18 um 23:49 schrieb Dylan Baker: >>> Quoting Roland Scheidegger (2018-11-13 14:13:00) >>>> Am 13.11.18 um 18:00 schrieb Dylan Baker: >>&g

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Am 14.11.18 um 03:02 schrieb Roland Scheidegger: > Am 13.11.18 um 23:49 schrieb Dylan Baker: >> Quoting Roland Scheidegger (2018-11-13 14:13:00) >>> Am 13.11.18 um 18:00 schrieb Dylan Baker: >>>> Quoting Erik Faye-Lund (2018-11-13 01:34:53) >>>>> O

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Am 13.11.18 um 23:49 schrieb Dylan Baker: > Quoting Roland Scheidegger (2018-11-13 14:13:00) >> Am 13.11.18 um 18:00 schrieb Dylan Baker: >>> Quoting Erik Faye-Lund (2018-11-13 01:34:53) >>>> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: >>>>>

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Am 13.11.18 um 18:00 schrieb Dylan Baker: > Quoting Erik Faye-Lund (2018-11-13 01:34:53) >> On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: >>> Quoting Erik Faye-Lund (2018-11-12 04:51:47) On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > Which has the same behavior.

Re: [Mesa-dev] [PATCH 1/2] nir: add lowering for ffloor

Am 12.11.18 um 20:40 schrieb Jason Ekstrand: > On Mon, Nov 12, 2018 at 1:29 PM Christian Gmeiner > mailto:christian.gmei...@gmail.com>> wrote: > > Hi Jason > > Am Sa., 1. Sep. 2018 um 21:23 Uhr schrieb Jason Ekstrand > mailto:ja...@jlekstrand.net>>: > > > > I don't think eithe

Re: [Mesa-dev] [PATCH] gallivm: fix improper clamping of vertex index when fetching gs inputs

Am 08.11.18 um 14:59 schrieb Jose Fonseca: > Good find. > > On 08/11/2018 01:54, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Because we only have one file_max for the (2d) gs input file, the value >> actually represents the max of attrib and

Re: [Mesa-dev] [PATCH vulkan/spec 1/3] Add an extension to specify that derivative groups are quads

Am 06.11.18 um 22:48 schrieb Jason Ekstrand: > This came to the top of my list recently due to a difference between > OpenGL and Vulkan discard operations and D3D's discard operation. The > OpenGL and Vulkan discard is defined to be control flow and derivatives > are undefined after discard. With

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

Am 07.11.18 um 00:03 schrieb Kristian Høgsberg: > On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: >> >> Hi, >> >> Is there anything to be done in the nine state trackers (or other state >> trackers). >> >> Nine uses create_surface. Should it expect the field to be filled >> properly by the driver

Re: [Mesa-dev] [PATCH v3 4/4] r600: Add support for EXT_texture_sRGB_R8

Reviewed-by: Roland Scheidegger Am 06.11.18 um 12:04 schrieb Gert Wollny: > Hi Dave & Roland, > > Can I persuade you to take a look at this one-liner? > > Many thanks, > Gert > > Am Donnerstag, den 01.11.2018, 12:59 +0100 schrieb Gert Wollny: >> From:

Re: [Mesa-dev] [PATCH v2 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

Am 01.11.18 um 15:48 schrieb Gert Wollny: > Am Dienstag, den 30.10.2018, 16:04 + schrieb Roland Scheidegger: >> With the format ordering in svga_format.c as Ilia mentioned fixed >> Reviewed-by: Roland Scheidegger > > CMIIW, but I guess was that your R-b was only for thi

Re: [Mesa-dev] [PATCH 09/12] gallivm: remove workarounds for pre LLVM 5.0

Am 31.10.18 um 14:30 schrieb Emil Velikov: > From: Emil Velikov > > With LLVM 5.0.1 the minimum required version, we can drop all the dead > code. > > Cc: Roland Scheidegger > Cc: Jose Fonseca > Signed-off-by: Emil Velikov > --- > Gents this is a quick and dirt

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

Am 30.10.18 um 23:55 schrieb Marek Olšák: > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: > > wt., 30 paź 2018, 23:01 Marek Olšák >: > > On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer > mailto:mic...@daen

Re: [Mesa-dev] [PATCH v2 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

With the format ordering in svga_format.c as Ilia mentioned fixed Reviewed-by: Roland Scheidegger Am 30.10.18 um 11:46 schrieb Gert Wollny: > This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new > format enum, the format entries in Gallium and and svga, the mapping b

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Add Gallium support for EXT_texture_sRGB_R8

This patch should probably be split into adding the format to gallium and using it in mesa/st. More comments inline. Am 29.10.18 um 08:35 schrieb Gert Wollny: > This only adds support on the Gallium core level, for the drivers > it is likely that additional changes are needed to support the > new

Re: [Mesa-dev] [PATCH] scons: Remove gles option.

Looks alright to me, if it's broken anyway. Reviewed-by: Roland Scheidegger Am 19.10.18 um 14:33 schrieb Jose Fonseca: > It's broken, and WGL state tracker is always built with GLES support > noawadays. > --- > common.py|

Re: [Mesa-dev] [PATCH mesa] radv: s/abs/fabsf/ for floats

Am 18.10.18 um 19:25 schrieb Matt Turner: > On Thu, Oct 18, 2018 at 8:46 AM Eric Engestrom > wrote: >> >> Fixes: a4c4efad89eceb26cf82 "radv: Rework guard band calculation" >> Cc: Bas Nieuwenhuizen >> Signed-off-by: Eric Engestrom >> --- >> src/amd/vulkan/si_cmd_buffer.c | 8 >> 1 file

Re: [Mesa-dev] Q: to which software renderers should we contribute to help virgl conformance testing

Am 17.10.18 um 19:15 schrieb Gert Wollny: > Dear all, > > we are looking into doing a CI for virglrenderer that also runs a > subset of the GLES dEQP, and in order to be able to run this also in > gitlab.fd.o we were looking into the available gallium software > renderers. Inital tests by just ru

Re: [Mesa-dev] [PATCH] softpipe: dynamically allocate space for immediate constants

Looks reasonable to me. Reviewed-by: Roland Scheidegger Am 16.10.18 um 10:07 schrieb Gert Wollny: > From: Gert Wollny > > The number of immediate constants was fixed and the size check was > only done by means of an assertion. Given this a shader that emits > more immediate

Re: [Mesa-dev] [RFC 4/7] mesa: Helper functions for counting set bits in a mask

Am 15.10.18 um 15:19 schrieb Toni Lönnberg: > --- > src/util/bitscan.h | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/src/util/bitscan.h b/src/util/bitscan.h > index dc89ac9..cdfecaf 100644 > --- a/src/util/bitscan.h > +++ b/src/util/bitscan.h > @@ -112,6 +112

Re: [Mesa-dev] [PATCH] st/mesa: Pass index to pipe->create_query() for statistics queries.

FWIW the gallium pipeline stats query exists for way longer than the GL ARB spec for it, and at least llvmpipe implemented it for ages. So the reason for it being like that is due to dx10 (which always queries these together), when gl couldn't do it at all. To make it a bit nicer you could use new

Re: [Mesa-dev] [PATCH 3/3] appveyor: Cache pip's cache files.

; > - win_flex_bison-2.5.15.zip > - llvm-5.0.1-msvc2017-mtd.7z > > Series looks good to me. Reviewed-by: Roland Scheidegger ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] gallivm: Make it possible to disable some optimization shortcuts in release builds

Looks alright to me. I'm not quite sold on the "safemath" name though, since "safe math" is usually associated with floating point optimizations, and this here is just filtering hacks. Maybe something like disable_filtering_hacks would be more fitting? Reviewed-by: R

Re: [Mesa-dev] [PATCH] gallivm: Make it possible to disable some optimization shortcuts in release builds

en a deliberate decision. Although using a separate variable has the advantage that the compiler can optimise out the unneeded code (we didn't really care). From: Gert Wollny Sent: Thursday, October 4, 2018 12:58:41 AM To: Roland Scheidegger; mes

Re: [Mesa-dev] [PATCH] gallivm: Make it possible to disable some optimization shortcuts in release builds

Is it worth it splitting out to another var? We actually have code branches internally where we just define the gallivm_debug var always, and some of the debug flags outside the #ifdef debug (we'll actually need more than just these 3 accessible outside debug builds). If you think this is cleane

Re: [Mesa-dev] [PATCH] Revert "mesa: remove unnecessary 'sort by year' for the GL extensions"

Looks great to me. Reviewed-by: Roland Scheidegger Am 24.09.2018 um 17:19 schrieb Emil Velikov: > This reverts commit 3d81e11b49366b5636b8524ba0f8c7076e3fdf34. > > As reported by Federico, some games require the 'sort by year' since > they truncate the extensions whic

  1   2   3   4   5   6   7   8   9   10   >