Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

This looks like a useful check for WebGL compatibility: https://threejs.org/docs/index.html#manual/introduction/WebGL-compatibility-check On Mon, Jun 18, 2018, 3:50 PM Laura Ekstrand wrote: > Jordan's version is awesome. But in general most people are concerned > that WebGL will cra

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

Jordan's version is awesome. But in general most people are concerned that WebGL will crash browsers. One idea is to look into using three.js, which is a front-end library for web graphics. It's backed by multiple frameworks including WebGL. On Sun, Jun 17, 2018, 9:23 PM Jordan Justen wrote:

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

Eric, Thanks for finding that command to shut off copyright. I've updated the series to add it. Laura On Fri, Jun 1, 2018 at 7:29 AM, Dylan Baker wrote: > Quoting Eric Engestrom (2018-06-01 02:41:36) > > On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > > >

Re: [Mesa-dev] [PATCH v2 10/15] docs: Add toctree to relnotes

5-30 15:53:22 -0700, Laura Ekstrand wrote: > > From: Jean Hertel > > > > Toctree directives create automatically generated navigation sidebars. > > This is the new relnotes sidebar. > > --- > > docs/relnotes.rst | 210 ++ >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

Stuart, We are now running on our own Docker image: https://mesa-test.freedesktop.org/. This should have fixed both of the issues you encountered. Thanks. Laura On Mon, Jun 11, 2018 at 3:24 PM, Laura Ekstrand wrote: > I really like the rotate on hover effect for the gears. I would rat

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

avicon for a while is definitely worth > it. > > On Tue, 12 Jun 2018 at 08:27, Laura Ekstrand wrote: > >> I really like the rotate on hover effect for the gears. I would rather >> that we use 2D WebGL for it if we could, though, since Mesa enables WebGL >> on certain pla

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

I really like the rotate on hover effect for the gears. I would rather that we use 2D WebGL for it if we could, though, since Mesa enables WebGL on certain platforms. Stuart, I will try to get the favicon and rtd_theme fixed. We may have to make our Docker image. Thanks. Laura On Fri, Jun 8,

Re: [Mesa-dev] [PATCH v2 11/15] docs: Toctree for systems.rst as in jhertel docs.

So actually, Nanley Chery noticed that this puts the xlib driver in the menu under "Deprecated systems." Xlib driver is in active development! Since xlib was not in the navigation menu on the old website, let's just delete this patch. nack'd by Laura Ekstrand (la...@jlekstra

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

Daniel, I literally just followed the example: https://docs.gitlab.com/ee/ci/yaml/#pages As I recall, there's a recursive loop if you don't use .public. On Fri, Jun 1, 2018, 4:17 AM Daniel Stone wrote: > Hi, > > On 1 June 2018 at 11:23, Eric Engestrom wrote: > > On Friday, 2018-06-01 11:16:2

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

ric Anholt wrote: > > Jordan Justen writes: > > > > > On 2018-05-24 17:37:09, Laura Ekstrand wrote: > > >> A few of the commits are quite large and awaiting list approval. I > suggest > > >> that you take a look at the code here: > > >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

at 11:05 PM, Jordan Justen wrote: > On 2018-05-24 17:37:09, Laura Ekstrand wrote: > > A few of the commits are quite large and awaiting list approval. I > suggest > > that you take a look at the code here: > > https://gitlab.freedesktop.org/ldeks/mesa/tree/website1_75,

[Mesa-dev] [PATCH v2 15/15] docs: Human edits to the website code for clarity.

There's a lot here. If you're interested, it's mostly whitespace fixes, switching variable names and function names to the Sphinx orange variable highlight style, and naming code blocks to take advantage of Pygments syntax highlighting. --- docs/application-issues.rst | 8 +- docs/autoconf.rst

[Mesa-dev] [PATCH v2 12/15] docs: Edits to fix toctrees.

ReStructured Text toctrees are used to automatically generate the sidebar. But all top-level headings get added to it by default. In order to workaround this, you must create one and only one top-level heading for each page. --- docs/download.rst | 2 +- docs/faq.rst | 2 +- docs/index.

[Mesa-dev] [PATCH v2 11/15] docs: Toctree for systems.rst as in jhertel docs.

Toctree directives create automatically generated navigation sidebars. This is the new deprecated systems sidebar. --- docs/systems.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/systems.rst b/docs/systems.rst index 707abeeed9..b05aff0621 100644 --- a/docs/systems.rst +++ b/doc

[Mesa-dev] [PATCH v2 14/15] docs: Major manual edits to environment vars.

This is a huge page. The edits I've done here take full advantage of reStructured text and Sphinx's awesome built-in style for explaining commands and variables. Enjoy! --- docs/envvars.rst | 604 ++- 1 file changed, 425 insertions(+), 179 dele

[Mesa-dev] [PATCH v2 09/15] docs: Add a navigation sidebar.

From: Jean Hertel This is the new main sidebar. --- docs/index.rst | 90 ++ 1 file changed, 90 insertions(+) diff --git a/docs/index.rst b/docs/index.rst index dbb4a4ddec..1894b46a4b 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -1,3

[Mesa-dev] [PATCH v2 04/15] docs: Result of script fixing html with Beautiful Soup.

Beautiful Soup patched our html in these ways: - Creating closing tags e.g. where there were none in order to create semantically complete html (like xhtml) - Removing the old header, which is no longer needed - Removing the old content bar to avoid confusion - Removing the outer from the conte

[Mesa-dev] [PATCH v2 05/15] docs: Rename html to rst

This should tell git that the files are really the same. That way, we don't lose the file history. --- docs/{application-issues.html => application-issues.rst} | 0 docs/{autoconf.html => autoconf.rst} | 0 docs/{bugs.html => bugs.rst} | 0 docs/{co

[Mesa-dev] [PATCH v2 13/15] docs: Fix Sphinx compile errors.

This just involves some quick fixes to formatting of the affected pages. --- docs/autoconf.rst| 1 + docs/dispatch.rst| 72 ++-- docs/egl.rst | 2 ++ docs/releasing.rst | 14 +- docs/relnotes/17.0.5.rst | 2 +-

[Mesa-dev] [PATCH v2 06/15] docs: Add results of script - pandoc-generated rst pages.

--- docs/application-issues.rst | 90 +- docs/autoconf.rst | 406 ++- docs/bugs.rst | 75 +- docs/codingstyle.rst| 244 +- docs/conform.rst| 1343 +- docs/debugging.rst | 66 +- docs/developers.rst | 63 +- docs/devinfo

[Mesa-dev] [PATCH v2 07/15] docs: Add Sphinx configuration file.

From: Jean Hertel This tells Sphinx how to build our website from reStructured Text. Signed-off-by: Jean Hertel --- docs/conf.py | 162 +++ 1 file changed, 162 insertions(+) create mode 100644 docs/conf.py diff --git a/docs/conf.py b/do

[Mesa-dev] [PATCH v2 02/15] docs: Add python script that converts html to rst.

Use Beautiful Soup to fix bad html, then use pandoc for converting to rst. --- docs/rstConverter.py | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 docs/rstConverter.py diff --git a/docs/rstConverter.py b/docs/rstConverter.py new file mode 100755 index 0

[Mesa-dev] [PATCH v2 00/16] Move the Mesa Website to Sphinx

ages are much cleaner and easier to read. I've learned a lot by reading these pages. Thanks. Laura Ekstrand --- Jean Hertel (3): docs: Add Sphinx configuration file. docs: Add a navigation sidebar. docs: Add toctree to relnotes Laura Ekstrand (13): Added ci yaml file

[Mesa-dev] [PATCH v2 03/15] docs: Remove contents.html and old mesa.css file.

The old navigation bar, may it rest in peace, causes major problems when running the rstConverter.py script. It and the css file are also unneeded. Let's get rid of them now. --- docs/contents.html | 108 - docs/mesa.css | 63 -

[Mesa-dev] [PATCH v2 08/15] docs: Add command for Sphinx build.

This does two things. 1. It pulls a Docker image which is a Linux system with Sphinx and the Read the Docs Sphinx theme already installed. 2. It uses sphinx-build to build html from our rst pages. --- .gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci

[Mesa-dev] [PATCH v2 10/15] docs: Add toctree to relnotes

From: Jean Hertel Toctree directives create automatically generated navigation sidebars. This is the new relnotes sidebar. --- docs/relnotes.rst | 210 ++ 1 file changed, 210 insertions(+) diff --git a/docs/relnotes.rst b/docs/relnotes.rst ind

[Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

For now, all this does is copy our current webpage into a public folder. Daniel Stone has the server configured to check this public folder and host the index.html as mesa-test.freedesktop.org. When this patch series is approved, Daniel will change it to point at mesa-3d.org. --- .gitlab-ci.yml |

Re: [Mesa-dev] [PATCH 02/16] docs: Add python script that converts html to rst.

Nevermind, Jason used a git revert trick to get it to work. The v2 will have the diff and preserve the git file history. On Fri, May 25, 2018 at 7:58 PM, Laura Ekstrand wrote: > I specifically tried forcing a rename earlier, but it doesn't work. Git > sees too much change. The

Re: [Mesa-dev] [PATCH 02/16] docs: Add python script that converts html to rst.

d for converting to rst doesn't make sense. (.rst to .rst? What?) Laura On Fri, May 25, 2018, 4:26 AM Eric Engestrom wrote: > On Thursday, 2018-05-24 17:27:05 -0700, Laura Ekstrand wrote: > > Use Beautiful Soup to fix bad html, then use pandoc for converting to > > rst. > >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

ontent in the past two weeks, take a > look >at your page. > > I hope you'll agree that the resulting pages are much cleaner and easier to > read. I've learned a lot by reading these pages. > > Thanks. > > Laura Ekstrand > --- > > J

[Mesa-dev] [PATCH 16/16] docs: Remove unneeded mesa css file.

Goodbye old css file. You belong in 1999 from whence you came. --- docs/mesa.css | 63 --- 1 file changed, 63 deletions(-) delete mode 100644 docs/mesa.css diff --git a/docs/mesa.css b/docs/mesa.css deleted file mode 100644 index 7ab8152b0

[Mesa-dev] [PATCH 12/16] docs: Fix Sphinx compile errors.

This just involves some quick fixes to formatting of the affected pages. --- docs/autoconf.rst| 1 + docs/conf.py | 2 +- docs/dispatch.rst| 72 ++-- docs/egl.rst | 2 ++ docs/releasing.rst | 14 +-

[Mesa-dev] [PATCH 13/16] docs: Edits to fix toctrees.

ReStructured Text toctrees are used to automatically generate the sidebar. But all top-level headings get added to it by default. In order to workaround this, you must create one and only one top-level heading for each page. --- docs/download.rst | 2 +- docs/faq.rst | 2 +- docs/index.

[Mesa-dev] [PATCH 14/16] docs: Major manual edits to environment vars.

This is a huge page. The edits I've done here take full advantage of reStructured text and Sphinx's awesome built-in style for explaining commands and variables. Enjoy! --- docs/envvars.rst | 604 ++- 1 file changed, 425 insertions(+), 179 dele

[Mesa-dev] [PATCH 08/16] docs: Add a navigation sidebar.

From: Jean Hertel This is the new main sidebar. --- docs/index.rst | 90 ++ 1 file changed, 90 insertions(+) diff --git a/docs/index.rst b/docs/index.rst index e11b1e4ecc..f2ab63fb63 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -1,3

[Mesa-dev] [PATCH 10/16] docs: Toctree for systems.rst as in jhertel docs.

Toctree directives create automatically generated navigation sidebars. This is the new deprecated systems sidebar. --- docs/systems.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/systems.rst b/docs/systems.rst index 707abeeed9..b05aff0621 100644 --- a/docs/systems.rst +++ b/doc

[Mesa-dev] [PATCH 02/16] docs: Add python script that converts html to rst.

Use Beautiful Soup to fix bad html, then use pandoc for converting to rst. --- docs/rstConverter.py | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 docs/rstConverter.py diff --git a/docs/rstConverter.py b/docs/rstConverter.py new file mode 100755 index 0

[Mesa-dev] [PATCH 07/16] docs: Add command for Sphinx build.

This does two things. 1. It pulls a Docker image which is a Linux system with Sphinx and the Read the Docs Sphinx theme already installed. 2. It uses sphinx-build to build html from our rst pages. --- .gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci

[Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

From: Jean Hertel This tells Sphinx how to build our website from reStructured Text. Signed-off-by: Jean Hertel --- docs/conf.py | 162 +++ 1 file changed, 162 insertions(+) create mode 100644 docs/conf.py diff --git a/docs/conf.py b/do

[Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

g these pages. Thanks. Laura Ekstrand --- Jean Hertel (3): docs: Add Sphinx configuration file. docs: Add a navigation sidebar. docs: Add toctree to relnotes Laura Ekstrand (13): Added ci yaml file for Gitlab. docs: Add python script that converts html to rst. docs: Remove c

[Mesa-dev] [PATCH 09/16] docs: Add toctree to relnotes

From: Jean Hertel Toctree directives create automatically generated navigation sidebars. This is the new relnotes sidebar. --- docs/relnotes.rst | 197 ++ 1 file changed, 197 insertions(+) diff --git a/docs/relnotes.rst b/docs/relnotes.rst ind

[Mesa-dev] [PATCH 03/16] docs: Remove contents.html

The old navigation bar, may it rest in peace, causes major problems when running the rstConverter.py script. It's also unneeded. Let's get rid of it now. --- docs/contents.html | 108 - 1 file changed, 108 deletions(-) delete mode 100644 docs/c

[Mesa-dev] [PATCH 01/16] Added ci yaml file for Gitlab.

For now, all this does is copy our current webpage into a public folder. Daniel Stone has the server configured to check this public folder and host the index.html as mesa-test.freedesktop.org. When this patch series is approved, Daniel will change it to point at mesa-3d.org. --- .gitlab-ci.yml |

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

https://drive.google.com/file/d/1D0k3-p88xEame5gepJQfIcCyZhG4CAsW/view?usp=sharing On Mon, May 14, 2018 at 5:44 PM, Jason Ekstrand wrote: > One more comment: NIR is *not* a stable API. > > On Mon, May 14, 2018 at 2:10 PM, Laura Ekstrand > wrote: > >> I'

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

ting image sizes and > memory layouts" > > BLORP: How about "blit, clear, and resolve functionality" rather than > "driver functionality" > > NIR: Not really a "front-end" more of an "optimizing middle compiler" > > Looks snazzy th

[Mesa-dev] docs: Intel Mesa Drivers infographic

Hi All, I developed the following infographic to inform readers about the various parts that make up the Intel Mesa drivers. It is intended to help groups inside Intel better understand the open source community, and at the same time, it helps train newcomers to Mesa in driver architecture. I ha

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

;t think much has changed. Thanks. Laura On Thu, Apr 5, 2018 at 11:18 AM, Emil Velikov wrote: > On 5 April 2018 at 19:10, Laura Ekstrand wrote: > > Emil, > > > > Specifically, what infrastructure do you need? Gallium is already > carrying > > Sphinx aroun

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Emil, Specifically, what infrastructure do you need? Gallium is already carrying Sphinx around as a dependency. Laura On Thu, Apr 5, 2018 at 11:07 AM, Emil Velikov wrote: > Hi everyone, > > On 5 April 2018 at 01:58, Laura Ekstrand wrote: > > I forgot to note that you have

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

I forgot to note that you have to choose space->ignore in the diff options on cgit in order to see the easy-to-read git diff. On Wed, Apr 4, 2018 at 5:57 PM, Laura Ekstrand wrote: > Jean, > > The main problem is not the conversion to rst. It's preserving the git > history

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

gt; Also, if there is anything else I can do, send me an email and I will do > the best I can to help. > > Kind Regards, > > Jean Hertel > > > -- > *De:* Jean Hertel > *Enviado:* segunda-feira, 2 de abril de 2018 21:19 > *Para:* Lau

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

nto a rst format. > > 2 - Delete the old file > > Kind Regards, > > Jean Hertel > > -- > *De:* Laura Ekstrand > *Enviado:* sábado, 31 de março de 2018 22:06 > *Para:* Jean Hertel > *Cc:* Emil Velikov; Vedran Miletić; mesa-dev@lists.fre

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

stuff in Sphinx. Once we get the page to look nicer, then we can start editing the content for readability!!! Thanks. Laura On Sat, Mar 31, 2018 at 5:57 PM, Laura Ekstrand wrote: > Hello Jean, > > Has anyone reviewed your patch series yet? I would like to get these > websi

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Hello Jean, Has anyone reviewed your patch series yet? I would like to get these website updates moving. Thanks. Laura On Tue, Jun 6, 2017 at 10:43 AM, Jean Hertel wrote: > Hello Emil, > > I've updated the website with the new release notes template. > > Please take a look at: http://mesa2.

Re: [Mesa-dev] GSoC 2015: Request for Registration for Mentorship

Ok, I'm registered on Melange as ldeks. On Thu, Apr 2, 2015 at 10:29 AM, Brian Paul wrote: > Sorry, I've been busy too. What's the URL for the sign-up? > > -Brian > > > On Thu, Apr 2, 2015 at 11:00 AM, Laura Ekstrand > wrote: > >> Hi, >> >

Re: [Mesa-dev] GSoC 2015: Request for Registration for Mentorship

Hi, I haven't been able to do this yet because I have a lot going on. Sorry. Laura On Mon, Mar 30, 2015 at 1:10 AM, Juliet Fru wrote: > > Hello +Laura, +Brian, >> >> I will like you to register on melange with X.org so as to mentor me on >> the Porting Glean tests to piglit project for GSoC 2

Re: [Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

o to the existing unlock. This > would have the advantage of keeping a single unlock, and a single > return path in the function. Your call, you get the R-b either way. > > -ilia > > On Wed, Apr 1, 2015 at 2:23 PM, Laura Ekstrand > wrote: > > Ilia Mirkin found that I

[Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

Ilia Mirkin found that I had forgotten to free the mutex in the error case. --- src/mesa/main/bufferobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b67e1c4..c7ef90b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/buff

Re: [Mesa-dev] [PATCH 05/23] main: Add entry point for CreateBuffers.

Yes, you are right. Thanks for the catch. I will send a fix patch to the mailing list. Laura On Mon, Mar 30, 2015 at 7:10 PM, Ilia Mirkin wrote: > On Wed, Feb 11, 2015 at 9:05 PM, Laura Ekstrand > wrote: > > for (i = 0; i < n; i++) { > > - _mesa_H

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

With your modifications in this patch, the target is already validated by the time you get to this function, so it should be fine to move mesa select tex image up above the format and type checks. On Mar 24, 2015 11:44 PM, "Eduardo Lima Mitev" wrote: > On 03/25/2015 12:02 AM, L

Re: [Mesa-dev] [PATCH v4 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

Looks good to me. Reviewed-by: Laura Ekstrand On Tue, Mar 24, 2015 at 7:43 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - get rid of a change that should not have happened in this patch > - improve the error messages > - fix alignments > - fix a capitalization in

Re: [Mesa-dev] [PATCH v4 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

This looks good. Reviewed-by: Laura Ekstrand On Tue, Mar 24, 2015 at 7:42 AM, Martin Peres wrote: > v2: > - improve an error message > > Reviewed-by: Laura Ekstrand > > v3: > - move a test to less generic functions > - fix an alignment > > v4: > - take the

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

On Tue, Mar 24, 2015 at 11:34 AM, Eduardo Lima Mitev wrote: > Thanks for the review! Please see some comments inline: > > On 03/23/2015 06:53 PM, Laura Ekstrand wrote: > > I'm glad you found this target checking problem. I have come across the > > same problem in othe

Re: [Mesa-dev] [PATCH v3 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

On Mon, Mar 23, 2015 at 12:14 PM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - get rid of a change that should not have happened in this patch > - improve the error messages > - fix alignments > - fix a capitalization in a function name in an error message > >

Re: [Mesa-dev] [PATCH v3 15/17] main: Added entry point for glGetNamedRenderbufferParameteriv

On Mon, Mar 23, 2015 at 12:04 PM, Martin Peres wrote: > v2: > - improve an error message > > Reviewed-by: Laura Ekstrand > > v3: > - move a test to less generic functions > - fix an alignment > > Signed-off-by: Martin Peres > --- > src/mapi/glapi/

Re: [Mesa-dev] [PATCH 3/3] mesa: Validate the target argument earlier in glGenerateMipmap()

Looks good to me. Reviewed-by: Laura Ekstrand On Mon, Mar 23, 2015 at 4:30 AM, Eduardo Lima Mitev wrote: > glGenerateMipmap() queries the current texture object corresponding to the > target > argument before ever validating it. It does so by calling > _mesa_get_current_tex_ob

Re: [Mesa-dev] [PATCH 2/3] mesa: Fix error in target validation of glCompressedTex(ture)SubImage3D() calls

Looks correct to me. Reviewed-by: Laura Ekstrand On Mon, Mar 23, 2015 at 4:30 AM, Eduardo Lima Mitev wrote: > Basically, two different target error checks are chained consecutively, > and the > second one is executed regardless the result of the first one. This > produces an inc

Re: [Mesa-dev] [PATCH 1/3] mesa: Improve validation of target, format and type of glTexSubImage[2, 3]D

I'm glad you found this target checking problem. I have come across the same problem in other texture functions, but I have been too busy to find all instances of this. It's kind of a natural, negative byproduct of adding DSA. On Mon, Mar 23, 2015 at 4:29 AM, Eduardo Lima Mitev wrote: > Curren

Re: [Mesa-dev] [PATCH 21/22] mesa: Implement GetVertexArrayIndexed[64]iv

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 +++ > src/mesa/main/tests/dispatch_sanity.cpp| 2 + > src/mesa/main/varray.c | 117 > + > src/mesa/main/varray.h

Re: [Mesa-dev] [PATCH 20/22] mesa: Add support for quering GL_VERTEX_ATTRIB_ARRAY_LONG

You misspelled "Querying" in the commit message. On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > This parameter was added in OpenGL 4.3 and GL_ARB_direct_state_access. > --- > src/mesa/main/varray.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/main/varray.c b

Re: [Mesa-dev] [PATCH 18/22] mesa: Add a vao parameter to get_vertex_array_attrib

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > This is needed to implement glGetVertexArrayIndexediv and > glGetVertexArrayIndexed64iv. > --- > src/mesa/main/varray.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/varray.

Re: [Mesa-dev] [PATCH 10/22] mesa: Refactor VertexAttrib[I|L]Format

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > The only difference between these functions is the legal types and > sizes, so consolidate the code into a single vertex_attrib_format() > function and call it from all three entry points. > --- > src/mesa/main/varray.c | 143 > ++

Re: [Mesa-dev] [PATCH 06/22] mesa: Implement VertexArrayElementBuffer

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 > src/mesa/main/arrayobj.c | 34 > ++ > src/mesa/main/arrayobj.h | 2 ++ > src/mesa/main/tests/dispatch_s

Re: [Mesa-dev] [PATCH 02/22] mesa: Add _mesa_lookup_vao_err

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > --- > src/mesa/main/arrayobj.c | 50 > > src/mesa/main/arrayobj.h | 3 +++ > 2 files changed, 53 insertions(+) > > diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c > index

Re: [Mesa-dev] [PATCH 01/22] mesa: Implement CreateVertexArrays

On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ > src/mesa/main/arrayobj.c | 20 +++- > src/mesa/main/arrayobj.h | 2 ++ > src/mesa/main/tests/dispatch_sanity

Re: [Mesa-dev] [PATCH 00/22] Add DSA support for vertex array objects

Except for a few minor nits on patches 1 2, 6, 10, 18, 20, and 21, this looks good. With those fixed, Reviewed-by: Laura Ekstrand On Wed, Mar 18, 2015 at 4:18 PM, Fredrik Höglund wrote: > This series implements the VAO portion of GL_ARB_direct_state_access. > > I started workin

Re: [Mesa-dev] [PATCH 16/17] main: Added entry points for NamedRenderbufferStorage/Multisample

On Thu, Mar 19, 2015 at 11:13 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - get rid of a change that should not have happened in this patch > - improve the error messages > - fix alignments > - fix a capitalization in a function name in an error message > >

Re: [Mesa-dev] [PATCH v2] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

Reviewed-by: Laura Ekstrand On Thu, Mar 19, 2015 at 5:06 PM, Fredrik Höglund wrote: > Generate GL_INVALID_OPERATION and return NULL when the buffer object > hasn't been created. All callers expect this. > > v2: Use a more concise error message. > > Cc: Laura Ekstrand

Re: [Mesa-dev] [PATCH 1/2] mesa: use more descriptive error messages for glUniform errors

On Thu, Mar 19, 2015 at 7:53 AM, Brian Paul wrote: > Different errors for type mismatches, size mismatches and matrix/ > non-matrix mismatches. Use a common format of "uniformName"@location > in the messags. > --- > src/mesa/main/uniform_query.cpp | 69 > ++--

Re: [Mesa-dev] [PATCH] mesa: Make sure the buffer exists in _mesa_lookup_bufferobj_err

You are right; I missed that subtle OpenGL definition of "exist" in the lookup functions. On Thu, Mar 19, 2015 at 3:48 PM, Fredrik Höglund wrote: > Generate GL_INVALID_OPERATION and return NULL when the buffer object > hasn't been created. All callers expect this. &

Re: [Mesa-dev] [PATCH 08/16] main: Added entry point for glGetTransformFeedbacki_v

Oops, apparently I sent it to just you. Reviewed-by: Laura Ekstrand On Thu, Mar 19, 2015 at 11:15 AM, Martin Peres wrote: > Laura, can I get your R-b on this one? > > > On 16/02/15 16:13, Martin Peres wrote: > >> v2: Review from Laura Ekstrand >> - use the trans

Re: [Mesa-dev] [PATCH 17/17] docs: Update progress on ARB_direct_state_access.

Buffer object DONE >- Framebuffer object started (Laura > Ekstrand) > - - Renderbuffer objectstarted (Martin > Peres) > + - Renderbuffer object

Re: [Mesa-dev] [PATCH] main: Add TEXTURE_CUBE_MAP support in CopyTextureSubImage3D.

On Wed, Mar 18, 2015 at 3:15 PM, Anuj Phogat wrote: > On Wed, Mar 18, 2015 at 1:06 PM, Laura Ekstrand > wrote: > > So it turns out that this doesn't actually fix any bugs or add any > features, > > stictly speaking. However, it does avoid a lot of kludginess. >

[Mesa-dev] [PATCH] main: Simplify debug messages for CopyTex*SubImage*D.

--- src/mesa/main/teximage.c | 86 +--- src/mesa/main/teximage.h | 3 +- 2 files changed, 39 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8b56d5b..7f0f7b7 100644 --- a/src/mesa/main/teximage.c ++

Re: [Mesa-dev] [PATCH 10/16] main: Added entry point for glCreateQueries

Too much debugging in gdb. On Thu, Mar 19, 2015 at 9:35 AM, Martin Peres wrote: > On 27/02/15 01:20, Laura Ekstrand wrote: > >> >> >> On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres < >> martin.pe...@linux.intel.com <mailto:martin.pe...@linux.intel.com>>

[Mesa-dev] [PATCH] docs: Update progress on ARB_direct_state_access.

, nv50, nvc0, r600) GL_ARB_direct_state_access started - Transform Feedback object started (Martin Peres) - - Buffer object started (Laura Ekstrand) + - Buffer object DONE

[Mesa-dev] [PATCH] main: Add TEXTURE_CUBE_MAP support in CopyTextureSubImage3D.

So it turns out that this doesn't actually fix any bugs or add any features, stictly speaking. However, it does avoid a lot of kludginess. Previously, if you called glCopyTextureSubImage3D(texcube, 0, 0, 0, zoffset = 3, ... it would grab the texture image object for face = 0 in teximage.c instea

[Mesa-dev] Fwd: [PATCH 12/16] main: Added entry point for glCreateProgramPipelines

-- Forwarded message -- From: Laura Ekstrand Date: Thu, Feb 26, 2015 at 3:43 PM Subject: Re: [Mesa-dev] [PATCH 12/16] main: Added entry point for glCreateProgramPipelines To: Martin Peres On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > Signed-off-by: Martin Pe

[Mesa-dev] [PATCH 2/2] main: Cosmetic updates to GetBufferPointerv.

v3: Review from Fredrik Hoglund -Split cosmetic refactor of GetBufferPointerv out into a separate commit --- src/mesa/main/bufferobj.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2811604..49d6d32 100644

[Mesa-dev] [PATCH 1/2] main: Add entry point for GetNamedBufferPointerv.

v3: Review from Fredrik Hoglund -Split cosmetic refactor of GetBufferPointerv out into a separate commit --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 20 src/mesa/main/bufferobj.h | 4

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

tain these types of students. On Mon, Mar 16, 2015 at 6:23 AM, Marek Olšák wrote: > On Fri, Mar 13, 2015 at 6:24 PM, Laura Ekstrand > wrote: > > We should try to steer people away from just writing Piglit tests for > GSoC, > > unless they have a specific mentor in mind and

Re: [Mesa-dev] [PATCH 3/4 v3] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

You're welcome. On Fri, Mar 13, 2015 at 9:00 AM, Eduardo Lima Mitev wrote: > Hi, > > I just merged the 4 patches after fixing your last comments. > > Thanks a lot for your reviews and patience. > > cheers, > Eduardo > > On 03/12/2015 06:22 PM, Laura Ekstrand

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

We should try to steer people away from just writing Piglit tests for GSoC, unless they have a specific mentor in mind and have already talked to him or her. In my experience, Piglit tests are difficult to do well because each one is drastically different from the others and involves cultivating a

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

That's okay, just wanted to make sure that 10.5 was correct. On Thu, Mar 12, 2015 at 1:49 PM, Emil Velikov wrote: > On 12/03/15 16:55, Laura Ekstrand wrote: > > Emil, > > > > I spoke with Neil Roberts, and the two patches of mine you have listed > > as rejected

Re: [Mesa-dev] [PATCH] Revert "main: _mesa_cube_level_complete checks NumLayers."

It appears that our Piglit tests that hit glGenerateMipmap always create the cube map texture with Texture Storage, so Num Layers always gets set to 6. I will make a simple test this afternoon for non texture storage cube maps. On Mar 12, 2015 12:33 PM, "Laura Ekstrand" wrote: >

[Mesa-dev] [PATCH] Revert "main: _mesa_cube_level_complete checks NumLayers."

This reverts commit 1ee000a0b6737d6c140d4f07b6044908b8ebfdc7. Failures with the GLES3 conformance suite and Synmark2 OGLHdrBloom revealed that this commit might be in error. A look at the offended test in GLES3 conformance suite, NPOT gen mipmap, suggests that NumLayers may not actually always be

Re: [Mesa-dev] [PATCH 3/4 v3] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

esa/main/pbo.h > @@ -92,4 +92,18 @@ _mesa_unmap_teximage_pbo(struct gl_context *ctx, > const struct gl_pixelstore_attrib *unpack); > > > +extern bool > +_mesa_validate_pbo_source(struct gl_context *ctx, GLuint dimensions, > + const struct gl_pixelstor

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

that you would like to share > before the release, please go ahead. > > > Cheers, > Emil > > > Mesa stable queue > - > > Nominated (3) > = > > Anuj Phogat (1): > glsl: Generate link error for non-matching gl_FragCoord > redecla

Re: [Mesa-dev] [PATCH 4/4 v2] mesa: Check for valid PBO access in gl(Compressed)Tex(Sub)Image calls

On Tue, Mar 10, 2015 at 11:36 AM, Eduardo Lima Mitev wrote: > This patch adds two types of checks to the gl(Compressed)Tex(Sub)Imgage > family > of functions when a pixel buffer object is bound to GL_PIXEL_UNPACK_BUFFER: > > - That the buffer is not mapped. > - The total data size is within the b

Re: [Mesa-dev] [PATCH 3/4 v2] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

On Tue, Mar 10, 2015 at 11:34 AM, Eduardo Lima Mitev wrote: > Internal PBO functions such as _mesa_map_validate_pbo_source() and > _mesa_validate_pbo_compressed_teximage() perform validation and buffer > mapping > within the same call. > > This patch takes out the validation into separate functio

Re: [Mesa-dev] [PATCH 1/4 v2] meta: Remove error checks for texture <-> pixel-buffer transfers that don't belong in driver code

LGTM. Reviewed-by: Laura Ekstrand On Tue, Mar 10, 2015 at 11:33 AM, Eduardo Lima Mitev wrote: > The implementation of texture <-> pixel-buffer transfers in drivers common > layer > includes certain error checks and argument validation that don't belong > there, >

  1   2   3   4   >