Yes, you are right. Thanks for the catch. I will send a fix patch to the mailing list.
Laura On Mon, Mar 30, 2015 at 7:10 PM, Ilia Mirkin <[email protected]> wrote: > On Wed, Feb 11, 2015 at 9:05 PM, Laura Ekstrand <[email protected]> > wrote: > > for (i = 0; i < n; i++) { > > - _mesa_HashInsert(ctx->Shared->BufferObjects, first + i, > > - &DummyBufferObject); > > - buffer[i] = first + i; > > + buffers[i] = first + i; > > + if (dsa) { > > + ASSERT(ctx->Driver.NewBufferObject); > > + buf = ctx->Driver.NewBufferObject(ctx, buffers[i]); > > + if (!buf) { > > + _mesa_error(ctx, GL_OUT_OF_MEMORY, "%s", func); > > + return; > > Aren't you holding the shared mutex at this point? I think you need to > free it... > > > + } > > + } > > + else > > + buf = &DummyBufferObject; > > + > > + _mesa_HashInsert(ctx->Shared->BufferObjects, buffers[i], buf); > > } > > > > mtx_unlock(&ctx->Shared->Mutex); >
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
