Re: [Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

Looks good to me. Matches what ErrorMessageF is doing. Reviewed-by: Courtney Goeltzenleuchter On Tue, Aug 26, 2014 at 2:47 PM, Johannes Obermayr wrote: > From: Stefan Dirsch > > Let's handle LIBGL_DEBUG env. variable in Mesa in a consistent way. > > Fixes: https:/

Re: [Mesa-dev] [PATCH] i965: Make glGetTex to PBO path use blorp to handle swizzled formats

ip, > - texImage->Width, texImage->Height, GL_COPY)) > - return false; > + 0, 0, texImage->Width, texImage->Height, > + 0, 0, texImage->Width, texImage->Height, > + GL_NEAREST, dst_flip, false); > > intel_miptree_release(&pbo_mt); > > -- > 1.8.1.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Courtney Goeltzenleuchter -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

Wed, Jun 11, 2014 at 10:28 AM, Courtney Goeltzenleuchter > > wrote: > >> > >> On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat > wrote: > >>> > >>> Fixes many failures in gles3 Khronos CTS test: packed_pixels > >>>

[Mesa-dev] [PATCH] mesa: glx: Reduce error log level

The code that parses LIBGL_DRIVERS_PATH was printing an error for every attempted dlopen. It's not an error to have to check multiple items in the path, only an error if no suitable library is found. Reduced the load error to a warning to match behavior of dynamic linker. Signed-off-by: Cou

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

oint.com/v1/url?u=http:/ >> /lists.freedesktop.org/mailman/listinfo/mesa-dev&k= >> oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ% >> 2BTLs8wadB%2BiIj9xpBY%3D%0A&m=BQB5tezP6JJarG3K6deQKB%2FgjK% >> 2FGhKQvd8LRF8usgCs%3D%0A&s=6d587c1f9718375e59390ea001cad3 >> ee836a3597c86c77596f02292c818b3051> >> >> >> >> >> >> -- >> Cody Northrop >> Graphics Software Engineer >> LunarG, Inc.- 3D Driver Innovations >> Email: c...@lunarg.com <mailto:c...@lunarg.com> >> Website: http://www.lunarg.com >> <https://urldefense.proofpoint.com/v1/url?u=http:/ >> /www.lunarg.com/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r= >> lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m= >> BQB5tezP6JJarG3K6deQKB%2FgjK%2FGhKQvd8LRF8usgCs%3D%0A&s= >> e4c25bb2e76d3a5cbff56061766e2be646a3106ae813979beea26ede2680e7ec> >> > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] meta: Drop unnecessary early returns in _mesa_meta_BlitFramebuffer.

Looks good. Reviewed-by: Courtney Goeltzenleuchter On Mon, May 19, 2014 at 12:12 AM, Kenneth Graunke wrote: > These aren't necessary - all of the following code is predicated on mask > being non-zero, so no code will get executed anyway. > > Signed-off-by: Kenneth Gra

Re: [Mesa-dev] [Mesa-stable] Mesa 10.1.1 is imminent

Eric's patch > > was a good idea as is. > > > > So, I'd be happy to have it cherry-picked to 10.1. > > Yeah, that's my conclusion, too. > > ___ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-stable > > -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

On Tue, Apr 15, 2014 at 2:16 PM, Eric Anholt wrote: > Courtney Goeltzenleuchter writes: > > > On Tue, Apr 15, 2014 at 1:18 PM, Eric Anholt wrote: > > > >> Kenneth Graunke writes: > >> > >> > On 04/14/2014 05:33 PM, Eric Anholt wrote: > >&

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

> 384*320=115200. Which value are you thinking is the "actual usable > size"? We certainly shouldn't have been memsetting more pixels than > 115200. > Why not? I understand that it's not useful to touch pixels beyond 115200, but from the data structure, we were given 131072 bytes to work w

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix buffer overruns in MSAA MCS buffer clearing.

;pitch); > > intel_miptree_unmap_raw(brw, mt->mcs_mt); > > mt->fast_clear_state = INTEL_FAST_CLEAR_STATE_CLEAR; > > This does seem to fix the KWin problem, as well as the glxgears problem. > > I agree this is the correct amount of data to memset, and even if we

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more detail comment. Compute limit outside

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

for (j = 0; j < bh && (j+y) < height; j++) { > > uint8_t *dst = dst_row + (y + j) * dst_stride + x * comps; > > -for (i = 0; i < bw; i++) { > > +for (i = 0; i < bw && (i+x) < width; i++) { > > etc2_

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more explanatory comments v3: add bugzilla

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Thanks Emil, I've got it sorted out I think. The format of the cc: was incorrect, it shouldn't have the piece. Should look like: Cc: "9.2 10.0 10.1" I'll send out updated patch. Courtney On Mon, Apr 7, 2014 at 6:28 PM, Emil Velikov wrote: > On 08/04/14 01:18, Cou

[Mesa-dev] [PATCH 1/2] mesa: add bounds checking to eliminate buffer overrun

Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more explanatory comments v3: add bugzilla

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

il.com:587': OK. Log says: Server: smtp.gmail.com MAIL FROM: RCPT TO: From: Courtney Goeltzenleuchter To: mesa-dev@lists.freedesktop.org Subject: [PATCH] mesa: add bounds checking to eliminate buffer overrun Date: Mon, 7 Apr 2014 13:19:17 -0600 Message-Id: <1396898358-14649-1-git-send-email

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Updated patch to include reference to bug that it resolves. Since this fixes a buffer overrun in the driver (found running GLBenchmark's Manhattan test) I think it would be a good candidate for the stable branch. ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

No, I do not believe this commit has made it. Courtney On Wed, Feb 26, 2014 at 11:44 AM, Ian Romanick wrote: > On 02/17/2014 09:43 AM, Courtney Goeltzenleuchter wrote: > >> Thanks for the feedback. >> >> I've updated the patch to integrate Ian's comments.

[Mesa-dev] [PATCH] mesa: Remove unnecessary condition

Identified by Valgrind memory check. Initialized block-opaque in a different patch. This test seems unnecessary. If opaque must be true, just set to true. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texcompress_etc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

to zero out the full structure, just the flags. Courtney On Fri, Feb 14, 2014 at 1:51 PM, Ian Romanick wrote: > On 02/14/2014 08:05 AM, Courtney Goeltzenleuchter wrote: > > Initialize field to eliminate valgrind warning. > > There are a couple other fields that aren't set it a

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Thanks for the feedback. I've updated the patch to integrate Ian's comments. Courtney On Fri, Feb 14, 2014 at 2:00 PM, Ian Romanick wrote: > On 02/14/2014 07:52 AM, Courtney Goeltzenleuchter wrote: > > Decompressing ETC2 textures was causing intermitent segfault > >

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. v2: add more detail comment. Compute limit outside

[Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

Initialize field to eliminate valgrind warning. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texcompress_etc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texcompress_etc.c b/src/mesa/main/texcompress_etc.c index f9234b0..97adc86 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH] mesa: Fix valgrind uninitialized variable warning

Initialize field to eliminate valgrind warning. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texcompress_etc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texcompress_etc.c b/src/mesa/main/texcompress_etc.c index f9234b0..97adc86 100644 --- a/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Forgot to mention. This patch addresses bug #74988<https://bugs.freedesktop.org/show_bug.cgi?id=74988> . No piglit regressions. Courtney On Fri, Feb 14, 2014 at 8:52 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Decompressing ETC2 textures was causing intermiten

[Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

Decompressing ETC2 textures was causing intermitent segfault by copying resulting 4x4 texel block to the destination texture regardless of the size of the destination texture. Issue found via application crash in GLBenchmark 3.0's Manhattan test. Signed-off-by: Courtney Goeltzenleuchter ---

[Mesa-dev] [PATCH] mesa: Return after error detected.

Fix ScissorArrayv and ScissorIndexed to return after detecting parameter error. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/scissor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/scissor.c b/src/mesa/main/scissor.c index 14c8e8a..83f39e2 100644 --- a/src

Re: [Mesa-dev] [PATCH 15/15] i965/blorp: Account for nonzero MinLayer in layered clears.

> > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > -- Courtney Goeltzenleuchter LunarG From 49172888c05ffdf7058be475219142d5f0c19f4a Mon Sep 17 00:00:00 2001 From: Courtney Goeltzen

Re: [Mesa-dev] [PATCH 0/2 v3] i965: Extend fast texture upload

ted them to master. > -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

611.28 256x256 GL_RGBA 487.80 587.42 GL_RGB 376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

GB (MB/sec) GL_RGBA 489.08 487.80 GL_RGB 229.03 376.63 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subi

[Mesa-dev] [PATCH 0/2 v3] i965: Extend fast texture upload

456.35 611.53 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Includes all feedback from gurket...@googlemail.com, matts...@gmail.com, chad.vers...@linux.intel.com and e...@anholt.net. Courtney Goeltzenleuchter (2): i965: a

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

Hi Chris, How goes arb_texture_view? I'd like to see what you have. Please let me know if I can help. Thanks, Courtney On Mon, Nov 25, 2013 at 1:42 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > I've added a viewport_array-rc2 branch to my github repository

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

} [st_atom_sampler] sampler->min_lod = CLAMP(msamp->MinLod, 0.0f, (GLfloat) texobj->MaxLevel - texobj->BaseLevel); There are more. All using the values that were set in TexParam. Courtney On Thu, Dec 5, 2013 at 9:41 AM, Co

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

Okay, that makes it easier. Should this change be conditional based on the type of context created? Courtney On Thu, Dec 5, 2013 at 8:52 AM, Brian Paul wrote: > On 12/04/2013 03:46 PM, Courtney Goeltzenleuchter wrote: > >> It's come to my attention that M

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

object will likely need two BaseLevel and MaxLevel attributes. One that's clamped and used locally and the other that simply holds the set value as given by the application in the glTexParameter call. Thoughts? Courtney On Tue, Dec 3, 2013 at 4:30 PM, Courtney Goeltzenleuchter < court..

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

On Tue, Dec 3, 2013 at 4:28 PM, Brian Paul wrote: > On 12/03/2013 02:56 PM, Courtney Goeltzenleuchter wrote: > >> Hi Brian, >> >> I've made all the recommended changes. >> >> I also added one, a test that the Driver.TextureView != NULL before

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

With these changes, what needs to happen to commit these changes to master? Thanks, Courtney On Mon, Nov 25, 2013 at 6:01 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > While incorporating Brian's comments I did some refactoring to consolidate >

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

posted the updated stream, including the next_mipmap_level_size refactoring on github here: https://github.com/courtney-lunarg/mesa/tree/texture_view-rc5 Courtney -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedeskto

[Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

gned-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 540 +++- 1 file changed, 539 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c index 4a6bd62..1bfc86b 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 6/9] mesa: consolidate multiple next_mipmap_level_size

Refactor to make next_mipmap_level_size defined in mipmap.c a _mesa_ helper function that can then be used by texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/mipmap.c | 8 src/mesa/main/mipmap.h | 4 src/mesa/main/texstorage.c | 25

Re: [Mesa-dev] [v3 5/8] mesa: Add driver entry point for ARB_texture_view

On Thu, Nov 21, 2013 at 5:56 PM, Brian Paul wrote: > On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote: > >> >> Signed-off-by: Courtney Goeltzenleuchter >> --- >> src/mesa/drivers/common/driverfuncs.c | 3 +++ >> src/mesa/main/dd.h

Re: [Mesa-dev] [v3 7/8] mesa: add texture_view helper function for TexStorage

On Thu, Nov 21, 2013 at 5:56 PM, Brian Paul wrote: > On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote: > >> Add helper function to set texture_view state from TexStorage calls. >> >> Signed-off-by: Courtney Goeltzenleuchter >> --- >>

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

I've added a viewport_array-rc2 branch to my github repository with updates from the feedback so far. Also includes a commit from Ian to Add varying slot for viewport index. Courtney On Fri, Nov 22, 2013 at 3:51 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Got it

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

Got it. On Fri, Nov 22, 2013 at 2:55 PM, Chris Forbes wrote: > It's just that last block that were messed up -- rest was context. > > Sorry for any confusion. > > > On Sat, Nov 23, 2013 at 10:06 AM, Courtney Goeltzenleuchter < > court...@lunarg.com> wrote: >

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

Hi Chris, I'm using this version of the spec: http://www.opengl.org/registry/specs/ARB/viewport_array.txt On Thu, Nov 21, 2013 at 4:41 PM, Chris Forbes wrote: > I was just comparing to the list in the ARB_viewport_array spec. > > > On Fri, Nov 22, 2013 at 11:33 AM, Courtney

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

tually -- that's weird. > > > On Fri, Nov 22, 2013 at 8:55 AM, Chris Forbes wrote: > >> I mean some of the values don't match the spec :) >> >> >> On Fri, Nov 22, 2013 at 7:52 AM, Courtney Goeltzenleuchter < >> court...@lunarg.com>

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

t; These are bogus: > > > > + > > + > > + > > + > > + > What do you mean by "bogus"? I was emulating other extension xml files. Are these not needed because they are already defined in gl_ext.h? > > > > 0x8E4D > > > > + > >

Re: [Mesa-dev] [PATCH 00/15] Add ARB_viewport_array extension

On Wed, Nov 20, 2013 at 5:06 PM, Ian Romanick wrote: > On 11/20/2013 02:59 PM, Courtney Goeltzenleuchter wrote: > > This series starts by updating the driver interface for > > scissor, viewport and DepthRange. This includes removing > > unused arguments from the Scissor, Vi

[Mesa-dev] [PATCH 16/18] mesa: Remove unused arguments from driver->Scissor

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 4 +--- src/mesa/drivers/dri/i915/i830_state.c | 24 ++-- src/mesa/drivers/dri/i915/i830_vtbl.c | 3 +-- src/mesa/drivers/dri/i915/i915_state.c | 24

[Mesa-dev] [PATCH 17/18] mesa: Remove unused arguments from driver->Viewport

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 14 ++ src/mesa/drivers/dri/i965/brw_context.c | 7 +-- src/mesa/drivers/dri/r200/r200_state.c | 9 + src/mesa/drivers/dri/radeon/radeon_common.c | 4 +--- src/mesa

[Mesa-dev] [PATCH 11/18] mesa: Add ARB_viewport_array state to gl_context

Add ARB_viewport_array in extensions.c and a flag in gl_extensions. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c| 3 +++ src/mesa/main/extensions.c | 1 + src/mesa/main/get.c| 1 + src/mesa/main/mtypes.h | 10 -- 4 files changed, 13 insertions

[Mesa-dev] [PATCH 11/18] mesa: Add custom get function for SCISSOR

Now that the scissor enable state is a bitfield need a custom function to extract the correct value from gl_context. Modeled Scissor.EnableFlags after Color.BlendEnabled. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c| 3 +++ src/mesa/main/extensions.c | 1 + src/mesa

[Mesa-dev] [PATCH 18/18] mesa: Remove unused arguments from driver->DepthRange

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c

[Mesa-dev] [PATCH 04/18] mesa: Update gl_scissor_attrib to support ARB_viewport_array

bit 0 when communicating with a driver that does not support ARB_viewport_array. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 13 ++--- src/mesa/drivers/common/meta.c | 6 +++--- src/mesa/drivers/dri/i915/i830_vtbl.c | 4

[Mesa-dev] [PATCH 09/18] mesa: Add new get entrypoints for ARB_viewport_array

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/get.c | 189 src/mesa/main/get.h | 6 ++ 2 files changed, 195 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index b8929a5..9e5c04a 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 06/18] mesa: Update viewport state for viewport_array

Include DepthRange as well since it's state is lumped together with viewport state. Updates all the drivers that reference Viewport state in gl_context. Have meta driver call _mesa_Viewport as that interface is not changing. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/c

[Mesa-dev] [PATCH 08/18] mesa: Add indexed version of mesa_scissor

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/attrib.c | 17 ++--- src/mesa/main/context.c | 10 +- src/mesa/main/scissor.c | 46 ++ src/mesa/main/scissor.h | 2 +- 4 files changed, 50 insertions(+), 25 deletions

[Mesa-dev] [PATCH 10/18] mesa: Add custom get function for SCISSOR

Now that the scissor enable state is a bitfield need a custom function to extract the correct value from gl_context. Modeled Scissor.EnableFlags after Color.BlendEnabled. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/enable.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH 13/18] mesa: Add ARB_viewport_array viewport entry points

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c | 2 +- src/mesa/main/scissor.c | 2 +- src/mesa/main/viewport.c | 316 +++ src/mesa/main/viewport.h | 22 +++- 4 files changed, 287 insertions(+), 55 deletions(-) diff --git

[Mesa-dev] [PATCH 14/18] mesa: Add gl_ViewportIndex variable to GLSL

Signed-off-by: Courtney Goeltzenleuchter --- src/glsl/builtin_variables.cpp | 2 ++ src/glsl/glsl_parser_extras.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 4d44104..862d255 100644 --- a/src/glsl

[Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

Define API connections to extension entry points added in previous commits. Update entry points to use floating point arguments as required by the extension. Add get tokens for ARB_viewport_array state. Signed-off-by: Courtney Goeltzenleuchter --- src/mapi/glapi/gen/ARB_viewport_array.xml | 79

[Mesa-dev] [PATCH 12/18] mesa: Add scissor entry points for viewport_array

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/scissor.c | 113 src/mesa/main/scissor.h | 8 2 files changed, 121 insertions(+) diff --git a/src/mesa/main/scissor.c b/src/mesa/main/scissor.c index 3187ab1..580558e 100644 --- a

[Mesa-dev] [PATCH 07/18] meta: Update meta driver to use API entry point

Using Mesa's GL entry point allows the meta driver to ignore interface changes due to ARB_viewport_array Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/meta.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/m

[Mesa-dev] [PATCH 03/18] mesa: Change DepthRange dd interface

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c

[Mesa-dev] [PATCH 05/18] mesa: Update viewport driver args for ARB_viewport_array

Change the Driver viewport method arguments to be floats instead of ints. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 7 --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c | 5 +++-- src/mesa

[Mesa-dev] [PATCH 01/18] mesa: Change scissor dd interface for viewport_array

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c

[Mesa-dev] [PATCH 00/15] Add ARB_viewport_array extension

t the right index value in place of 0. Courtney Goeltzenleuchter (18): mesa: Change scissor dd interface for viewport_array mesa: Update viewport dd interface for viewport_array mesa: Change DepthRange dd interface mesa: Update gl_scissor_attrib to support ARB_viewport_array mesa: Update vie

[Mesa-dev] [PATCH 02/18] mesa: Update viewport dd interface for viewport_array

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c | 2 +- src/mesa/drivers/dri/radeon/radeon_common.c | 4 ++-- src/mesa/drivers/dri/radeon

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

it. If Driver::Viewport is about to removed, the code of st_viewport should > be moved somewhere else. > > Marek > > > > On Wed, Nov 20, 2013 at 12:53 AM, Courtney Goeltzenleuchter < > court...@lunarg.com> wrote: > >> The Gallium state tracker has a st_viewport t

Re: [Mesa-dev] [PATCH 0/1]: Preparing for ARB_viewport_array

to be array references to index 0. Shall I just post my changes for folks to poke at? Or is a fdo personal repository easier to work with? Courtney On Tue, Nov 19, 2013 at 5:54 PM, Ian Romanick wrote: > On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > > The following patch

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

My apologies, I was distracted by other maters - updated commit follows. On Mon, Nov 11, 2013 at 2:21 PM, Chad Versace wrote: > On 11/08/2013 08:13 AM, Courtney Goeltzenleuchter wrote: > >> Support all levels of a supported texture format. >> >> Using 1024x1024,

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

611.28 256x256 GL_RGBA 487.80 587.42 GL_RGB 376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

GB (MB/sec) GL_RGBA 489.08 487.80 GL_RGB 229.03 376.63 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subi

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

13 at 12:31 PM, Brian Paul wrote: > On 11/04/2013 11:43 AM, Ian Romanick wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 11/01/2013 04:12 PM, Francisco Jerez wrote: >> >>> Ian Romanick writes: >&

[Mesa-dev] [v3 8/8] mesa: Update TexStorage to support ARB_texture_view

Call TextureView helper function to set TextureView state appropriately for the TexStorage calls. Misc updates from review feedback. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/teximage.c | 6 ++ src/mesa/main/texstorage.c | 5 +++-- 2 files changed, 9 insertions(+), 2

[Mesa-dev] [v3 2/8] mesa: Tracking for ARB_texture_view extension

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..b7da884 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa

[Mesa-dev] [v3 6/8] mesa: Fill out ARB_texture_view entry points

Add Mesa TextureView logic. Incorporate feedback on ARB_texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 562 +++- 1 file changed, 561 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/textureview.c b/src/mesa

[Mesa-dev] [v3 5/8] mesa: Add driver entry point for ARB_texture_view

Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/dd.h| 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c index 5faa98a..f185688

[Mesa-dev] [v3 0/8] Add ARB_texture_view

enums that have been added as queriable texture parameters. Adds one new driver entry point for the driver to map the view specified onto the origtexture given. Includes review feedback and a bug fix in compatible_format. Passes non-rendering ARB_texture_view piglit tests. Courtney

[Mesa-dev] [v3 7/8] mesa: add texture_view helper function for TexStorage

Add helper function to set texture_view state from TexStorage calls. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 59 + src/mesa/main/textureview.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/src/mesa/main

[Mesa-dev] [v3 3/8] mesa: update texture object for ARB_texture_view

Add state needed by glTextureView to the gl_texture_object. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/mtypes.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f6ce6d0..82fcd61 100644 --- a/src/mesa/main/mtypes.h

[Mesa-dev] [v3 1/8] mesa: Add API definitions for ARB_texture_view

Stub in glTextureView API call to go with the glTextureView API xml definition. Includes dispatch test for glTextureView Signed-off-by: Courtney Goeltzenleuchter --- src/mapi/glapi/gen/ARB_texture_view.xml | 23 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen

[Mesa-dev] [v3 4/8] mesa: ARB_texture_view get parameters

Add support for ARB_texture_view get parameters: GL_TEXTURE_VIEW_MIN_LEVEL GL_TEXTURE_VIEW_NUM_LEVELS GL_TEXTURE_VIEW_MIN_LAYER GL_TEXTURE_VIEW_NUM_LAYERS Incorporate feedback regarding when to allow query of GL_TEXTURE_IMMUTABLE_LEVELS. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa

Re: [Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

: > > On 11/07/2013 01:59 PM, Courtney Goeltzenleuchter wrote: > >> > >> MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms > >> of storage on the device, so okay to use this optimized copy routine. > >> > >> This series buil

[Mesa-dev] [PATCH demos v2 1/3] Perf: Add command line capabilities to perf framework

These were entirely interactive. Adding ability to pass in command line arguments allows future tests to include automated test capabilities. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/copytex.c | 2 +- src/perf/drawoverhead.c | 2 +- src/perf/fbobind.c | 2

[Mesa-dev] [PATCH demos v2 2/3] perf: Update teximage to measure more formats

feedback. This provides a quick way to get feedback on texture upload related performance tuning. Texture image data is initialized and aligned to 64 byte bounary. Uses Mesa demos Perf library to do the measurements. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/teximage.c | 720

[Mesa-dev] [PATCH demos v2 3/3] perf: Add script to run collection of texture formats

bench_teximage.sh runs all the same formats that teximage ran. Also passes the command line arguments of the script to the benchmark to allow tester to set --csvstyle to full or data for output more easily parsed by scripts and such. Signed-off-by: Courtney Goeltzenleuchter --- src/perf

[Mesa-dev] [PATCH demos v2 0/3] Customizable texture upload benchmark

first patch adds command line argument passing to the perf infrastructure. One big commit to update teximage. Would have been similar commit using other route (new test eventually replacing teximage.) Add bash script to benchmark all the modes tested previously. Courtney Goeltzenleuchter (3):

Re: [Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

On Mon, Nov 11, 2013 at 11:15 AM, Ian Romanick wrote: > On 11/05/2013 11:36 AM, Courtney Goeltzenleuchter wrote: > > On Tue, Nov 5, 2013 at 12:22 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote: > > > > On 11/05/2013 09:44 AM, Chris Forbes wrote

Re: [Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

enh = enhanced Suggestions on something more descriptive? teximage2? bench_teximage? teximage_perf? Thanks for the feedback. On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> Needed test to measure texture upload s

Re: [Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

Hi Brian, Oops, I meant to get rid of that. Is unnecessary now that the perf framework has command line arguments. Courtney On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> texture_enh allows the user to sp

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subimage.

Re: [Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

Re-posted patches with updated commit messages. Thanks, Courtney On Thu, Nov 7, 2013 at 2:34 PM, Matt Turner wrote: > On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter > wrote: > > This series builds on work from Frank Henigman to optimize the > > process of uplo

[Mesa-dev] [PATCH 2/2 v3] i965: Enhance tiled_memcpy to support all levels

376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subimage.

[Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

440.62 611.28 256x256 GL_RGBA 489.08 487.80 587.42 GL_RGB 229.03 376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

patch. Any results to share? > > On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter > wrote: > > Support all levels of a supported texture format. > > > > Signed-off-by: Courtney Goeltzenleuchter > > --- > > src/mesa/drivers/dri/i965/intel_tex_subi

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

Support all levels of a supported texture format. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

456.35 611.53 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subim

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

  1   2   >