[Mesa-dev] [Bug 108541] Convert x86 assembly stub to PIC to fix linking with lld

https://bugs.freedesktop.org/show_bug.cgi?id=108541 --- Comment #2 from Jonathan Gray --- Your patch segfaults at runtime, an approach based on libglvnd x86 tsd changes seems to work however. https://github.com/NVIDIA/libglvnd/commit/9a17198be3622ffa00f9db36e6b55773d4dcf596#diff-ac251356bcfe8971

[Mesa-dev] [Bug 108541] Convert x86 assembly stub to PIC to fix linking with lld

https://bugs.freedesktop.org/show_bug.cgi?id=108541 --- Comment #1 from Jonathan Gray --- Created attachment 142297 --> https://bugs.freedesktop.org/attachment.cgi?id=142297&action=edit adapted libglvnd x86 tsd changes -- You are receiving this mail because: You are the QA Contact for the bug

Re: [Mesa-dev] [PATCH 12/14] mesa/vbo: Move src/mesa/vbo/vbo_exec_array.c -> src/mesa/main/draw.c

Hi Brian, On Tuesday, 30 October 2018 13:06:50 CET Brian Paul wrote: > The series looks great, Mathias. > > Reviewed-by: Brian Paul Thanks for that one! > > @@ -2072,7 +2073,7 @@ vbo_initialize_exec_dispatch(const struct gl_context > > *ctx, > > void GLAPIENTRY > > _mesa_DrawArrays(GLenum

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

On 10/31/18 12:57 AM, Timothy Arceri wrote: On 30/10/18 10:14 pm, Tapani Pälli wrote: Hi; On 10/30/18 1:28 AM, Timothy Arceri wrote: On 29/10/18 10:05 pm, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review. Piglit patch is updated with the additional out var: https://patchwork.fre

Re: [Mesa-dev] [PATCH 09/14] vbo: Make no_current_update an argument to vbo_save_NotifyBegin.

Good Morning, On Tuesday, 30 October 2018 13:24:50 CET Eric Engestrom wrote: > > @@ -1294,7 +1294,7 @@ static void GLAPIENTRY > > _save_OBE_Rectf(GLfloat x1, GLfloat y1, GLfloat x2, GLfloat y2) > > { > > GET_CURRENT_CONTEXT(ctx); > > - vbo_save_NotifyBegin(ctx, GL_QUADS); > > + vbo_save_

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #16 from Vladimir --- renderdoccmd wine game.exe crashing too? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev ma

Re: [Mesa-dev] [PATCH 1/2] radeonsi: use better DCC clear codes

Tested-by: Dieter Nützel I only have Polaris 20...;-) Am 30.10.2018 21:03, schrieb Marek Olšák: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 26 - 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.

[Mesa-dev] [PATCH] radv/xfb: don't increase offset by component mask start.

From: Dave Airlie This is incorrect, the offset is into the buffer, and it's legal to write loc 0,0 -> buffer0, offset 0 loc 0,1 -> buffer1, offset 0 This fixes a bunch of piglits running on my zink xfb code on radv. Fixes: 6c21645046 (radv: emit stream outputs for vertex and tessellation stag

Re: [Mesa-dev] [PATCH 07/31] nir/opt_if: Rework condition propagation

On 31/10/18 1:23 am, Jason Ekstrand wrote: Weird.  I didn't expect this patch to have any impact whatsoever. I thought it was just moving around the way we emit stuff. I think I've spotted the problem. Iago does patch 1 help with the regressions you are seeing. https://patchwork.freedesktop.

[Mesa-dev] [PATCH 1/2] nir: fix if condition propagation for alu use

From: Timothy Arceri We need to update the cursor before we check if the alu use is dominated by the if condition. Previously we were checking if the current location of the alu instruction was dominated by the if condition which would miss some optimisation opportunities. Fixes: a3b4cb34589e ("

[Mesa-dev] [PATCH 2/2] nir: allow propagation of if evaluation to all alu instructions

With the simplifications to this pass in a3b4cb34589e2f1a68 we can allow any alu instruction to be processed. For one this can potentially help with bcsels. No shader-db change. --- src/compiler/nir/nir_opt_if.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --g

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

śr., 31 paź 2018 o 00:23 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 7:11 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): >> > >> > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk >> > wrote: >> >> >> >> wt., 30 paź 2018, 23:01 Marek Olšák : >> >

Re: [Mesa-dev] [PATCH RFC] egl: Add a 565 pbuffer-only EGL config under X11.

Eric Anholt writes: > The CTS requires a 565-no-depth-no-stencil config for ES 3.0, but at depth > 24 of X11 we wouldn't do so. We can satisfy that bad requirement using a > pbuffer-only visual with whatever other buffers the driver happens to have > given us. Anyone? Still concerned about get

Re: [Mesa-dev] [PATCH] intel/compiler: Stop assuming the entrypoint is called "main"

On Tuesday, October 30, 2018 9:26:29 AM PDT Jason Ekstrand wrote: > This isn't true for Vulkan so we have to whack it to "main" in anv which > is silly. Instead of walking the list of functions and asserting that > everything is named "main" and hoping there's only one function named > "main", jus

Re: [Mesa-dev] [PATCH v2 3/3] i965/gen9: Add workarounds for object preemption.

On Monday, October 29, 2018 10:19:54 AM PDT Rafael Antognolli wrote: > Gen9 hardware requires some workarounds to disable preemption depending > on the type of primitive being emitted. > > We implement this by adding a new atom that tracks BRW_NEW_PRIMITIVE. > Whenever it happens, we check the cur

Re: [Mesa-dev] [PATCH v2 0/3] Add object level preemption to i965.

On Monday, October 29, 2018 10:19:51 AM PDT Rafael Antognolli wrote: > Re-sending the series, this time adding preemption support only to i965, > since We still don't have vulkan tests for this. > > The proposed piglit test for this series can be found here: > https://gitlab.freedesktop.org/rantog

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

On Tue, Oct 30, 2018 at 7:11 PM Gustaw Smolarczyk wrote: > wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): > > > > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: > >> > >> wt., 30 paź 2018, 23:01 Marek Olšák : > >>> > >>> On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer > wrote: > >

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

Am 30.10.18 um 23:55 schrieb Marek Olšák: > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: > > wt., 30 paź 2018, 23:01 Marek Olšák >: > > On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer > mailto:mic...@daen

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018, 23:01 Marek Olšák : >>> >>> On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: > pon., 17

Re: [Mesa-dev] [PATCH 1/4] radv/winsys: remove unused surface_best()

For the series: Reviewed-by: Dave Airlie On Tue, 30 Oct 2018 at 20:39, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_radeon_winsys.h| 3 --- > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 7 --- > 2 files changed, 10 deletions

Re: [Mesa-dev] [PATCH] radv: rename some parameters in Cmd{Begin, End}TransformFeedbackEXT()

Reviewed-by: Dave Airlie On Tue, 30 Oct 2018 at 19:08, Samuel Pitoiset wrote: > > To match latest spec. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_b

Re: [Mesa-dev] [PATCH] radv: use pool->stride when calling radv_query_shader()

Reviewed-by: Dave Airlie On Wed, 31 Oct 2018 at 00:19, Samuel Pitoiset wrote: > > Not needed to recompute the stride. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_query.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_query.c b

Re: [Mesa-dev] [PATCH] radv: use WAIT_REG_MEM_GREATER_OR_EQUAL instead of a magic value

Reviewed-by: Dave Airlie On Tue, 30 Oct 2018 at 21:27, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/sid.h| 1 + > src/amd/vulkan/radv_query.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/sid.h b/src/amd/com

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

On 30/10/18 10:14 pm, Tapani Pälli wrote: Hi; On 10/30/18 1:28 AM, Timothy Arceri wrote: On 29/10/18 10:05 pm, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review. Piglit patch is updated with the additional out var: https://patchwork.freedesktop.org/patch/258899/ Original reporter co

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk wrote: > wt., 30 paź 2018, 23:01 Marek Olšák : > >> On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer >> wrote: >> >>> On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: >>> > pon., 17 wrz 2018 o 18:24 Michel Dänzer >>> napisał(a): >>> >> >>> >> On

[Mesa-dev] [PATCH] st/mesa: don't do L3 thread pinning for Blender

From: Marek Olšák so that all Blender threads are not forced to be on 1 CCX. Fixes: 8d473f555a0 --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 1 + src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 2 ++ src/mesa/state_tr

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

wt., 30 paź 2018, 23:01 Marek Olšák : > On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: > >> On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: >> > pon., 17 wrz 2018 o 18:24 Michel Dänzer >> napisał(a): >> >> >> >> On 2018-09-15 3:04 a.m., Marek Olšák wrote: >> >>> On Fri, Sep 14, 2018 at

[Mesa-dev] [Bug 107870] Undefined symbols for architecture x86_64: "_util_cpu_caps"

https://bugs.freedesktop.org/show_bug.cgi?id=107870 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Bug 108530 depends on bug 107870, which changed state. Bug 107870 Summary: Undefined symbols for architecture x86_64: "_util_cpu_caps" https://bugs.freedesktop.org/show_bug.cgi?id=107870 What|Removed |Added ---

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: > On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: > > pon., 17 wrz 2018 o 18:24 Michel Dänzer napisał(a): > >> > >> On 2018-09-15 3:04 a.m., Marek Olšák wrote: > >>> On Fri, Sep 14, 2018 at 4:53 AM, Michel Dänzer > wrote: > > La

[Mesa-dev] [PATCH] android: radv: add libmesa_git_sha1 static dependency

libmesa_git_sha1 whole static dependency is added to get git_sha1.h header and avoid following building error: external/mesa/src/amd/vulkan/radv_device.c:46:10: fatal error: 'git_sha1.h' file not found ^ 1 error generated. Fixes: 9d40ec2cf6 ("radv: Add support for VK_KHR_driver_propertie

Re: [Mesa-dev] [PATCH mesa] tools/imgui: disable all warnings

Yep : Reviewed-by: Lionel Landwerlin On 30/10/2018 19:02, Eric Engestrom wrote: This is an external project we have no control over, and will not be fixing (other than by sometimes pulling the latest sources), so warnings serve no purpose here. Signed-off-by: Eric Engestrom --- src/intel/t

Re: [Mesa-dev] [PATCH 11/11] util: move u_cpu_detect to util

For the series: Reviewed-by: Marek Olšák Marek On Mon, Oct 29, 2018 at 4:52 PM Dylan Baker wrote: > Quoting Brian Paul (2018-10-29 12:24:13) > > On 10/29/2018 12:57 PM, Dylan Baker wrote: > > > CC: v...@freedesktop.org > > > CC: Roland Scheidegger > > > Bugzilla: > https://na01.safelinks.pro

Re: [Mesa-dev] [PATCH v4 2/3] mesa/st: enable EXT_sRGB_write_control for Gallium drivers that support it

On Tue, Oct 30, 2018 at 4:45 PM Marek Olšák wrote: > > On Tue, Oct 23, 2018 at 1:30 PM Gert Wollny wrote: >> >> From: Gert Wollny >> >> With this patch the extension EXT_sRGB_write_control is enabled for >> gallium drivers that support sRGB formats as render targets. >> >> Tested (and pass) on r

Re: [Mesa-dev] EXT_gpu_shader4 / GL_EXT_gpu_shader4.mbox

No, we just need to write piglit tests. Marek On Tue, Oct 23, 2018 at 11:27 PM Dieter Nützel wrote: > Hello Marek, > > better late then... > > Tested-by: Dieter Nützel > > Merged it into current git (0ff1ccca25). > Do you need any special tests? > > Dieter > > Am 08.09.2018 00:06, schrieb Mare

Re: [Mesa-dev] [PATCH v4 2/3] mesa/st: enable EXT_sRGB_write_control for Gallium drivers that support it

On Tue, Oct 23, 2018 at 1:30 PM Gert Wollny wrote: > From: Gert Wollny > > With this patch the extension EXT_sRGB_write_control is enabled for > gallium drivers that support sRGB formats as render targets. > > Tested (and pass) on r600 (evergreen) and softpipe: > > dEQP-GLES31.functional.fbo.s

Re: [Mesa-dev] [PATCH] gallium/hud: fix power sensor readings for amdgpu users

Pushed, thanks! Marek On Sat, Oct 27, 2018 at 3:46 AM Andre Heider wrote: > amdgpu doesn't use the INPUT but the AVERAGE subfeature: > > $ sensors -u > amdgpu-pci-0100 > Adapter: PCI adapter > power1: > power1_average: 17.233 > power1_cap: 180.000 > > Signed-off-by: Andre Heider > --- > s

Re: [Mesa-dev] [PATCH] st/mesa: calculate buffer size correctly for packed uniforms

Reviewed-by: Marek Olšák Marek On Mon, Oct 29, 2018 at 5:27 AM Timothy Arceri wrote: > Fixes: edded1237607 ("mesa: rework ParameterList to allow packing") > --- > src/mesa/state_tracker/st_atom_constbuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/state_

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: don't create 64-bit integer MAD/FMA

Reviewed-by: Marek Olšák Marek On Sun, Oct 21, 2018 at 12:06 PM Rhys Perry wrote: > TGSI has no I64MAD/U64MAD opcode. > > Fixes: 278580729a5 ('st/glsl_to_tgsi: add support for 64-bit integers') > Signed-off-by: Rhys Perry > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 > 1 file

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: fix next_stage gathering

Reviewed-by: Marek Olšák Marek On Sat, Oct 20, 2018 at 12:03 AM Timothy Arceri wrote: > ffs() just returns the bit that is set, we need to know what > stage that bit represents so use u_bit_scan() instead. > > Fixes: 2ca5d9548fc4 ("st/glsl_to_nir: gather next_stage in shader_info") > --- > sr

[Mesa-dev] [PATCH 2/2] radeonsi: don't set the CB clear color registers for 0/1 clear colors on Raven2

From: Marek Olšák and add has_dcc_constant_encode. --- src/gallium/drivers/radeonsi/si_clear.c | 10 -- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 2 +- 4 files changed, 11 insertions(+), 3 de

[Mesa-dev] [PATCH 1/2] radeonsi: use better DCC clear codes

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 26 - 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index 8aa3355afc8..2900c31fd21 100644 --- a/src/gallium/

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

On 2018-10-26 01:06:52, andrey simiklit wrote: > Hi, > > Could you please help me with a push. I don't have a right for it :-) > I pushed these two patches. Thanks! e4e0fd5ffe1 i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch' a9031bf9b55 i965/batch: avoid reverting batch buff

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

On Friday, October 26, 2018 1:06:52 AM PDT andrey simiklit wrote: > Hi, > > Could you please help me with a push. I don't have a right for it :-) > > Thanks, > Andrii. Thanks for fixing these up! While we're here, there are several other variables where we track the last known state of the GPU,

[Mesa-dev] [PATCH mesa] tools/imgui: disable all warnings

This is an external project we have no control over, and will not be fixing (other than by sometimes pulling the latest sources), so warnings serve no purpose here. Signed-off-by: Eric Engestrom --- src/intel/tools/imgui/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #15 from Ahmed Elsayed --- It crashes with DXVK because I use the Windows version of RenderDoc. I will use the Linux version of RenderDoc. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assi

Re: [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Tue, Oct 30, 2018 at 1:34 PM Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote: > > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov > > wrote: > > > > > > NOTE: if bisecting a build error takes you hear, try a clean build. > > > > > There are a bunch of ways things can go w

Re: [Mesa-dev] [PATCH 2/2] kmsro: Extend to include hx8357d.

Emil Velikov writes: > Hi Eric, > > On Thu, 25 Oct 2018 at 17:39, Eric Anholt wrote: >> >> This allows vc4 to initialize on the Adafruit PiTFT 3.5" touchscreen with >> the new tinydrm driver I just submitted. If this series extending the >> pl111/kmsro driver is accepted, then I'll extend kmsro

[Mesa-dev] Mesa 18.3.0 release plan

Hi all, Here is the tentative release plan for 18.3.0. As many of you are well aware, it's time to the next branch point. Although we were a bit slow on updating the calendar, it the dates have been around for weeks. Oct 31 2018 - Feature freeze/Release candidate 1 Nov 07 2018 - Release candid

Re: [Mesa-dev] [PATCH 3/4] intel/decoder: tools: Use engine for decoding batch instructions

The whole point of the patch series is that the decoder can't really be agnostic about the engine because it needs to decode the stuff differently depending on the engine the instruction is sent to. But if you feel more comfortable with the init-approach, I'll change it in v2, though to me it

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Bug 108530 depends on bug 108082, which changed state. Bug 108082 Summary: warning: unknown warning option '-Wno-format-truncation' [-Wunknown-warning-option] https://bugs.freedesktop.org/show_bug.cgi?id=108082 What|Removed

[Mesa-dev] [Bug 108082] warning: unknown warning option '-Wno-format-truncation' [-Wunknown-warning-option]

https://bugs.freedesktop.org/show_bug.cgi?id=108082 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote: > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov > wrote: > > > > NOTE: if bisecting a build error takes you hear, try a clean build. > > > > There are a bunch of ways things can go wrong if you still have > > > > libdrm_freedreno cflags. > > > > >

Re: [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov wrote: > > On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote: > > > > On Tuesday, 2018-10-23 10:49:26 -0400, > > mesa-dev-boun...@lists.freedesktop.org wrote: > > > In the pursuit of lowering driver overhead, it became clear that some > > > amount o

[Mesa-dev] [PATCH 2/5] glsl: add has_implicit_uint_to_int_conversion()-helper

This makes the code a bit easier to read, as well as reduces repetition, especially when we add support for EXT_shader_implicit_conversions. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_to_hir.cpp | 3 +-- src/compiler/glsl/glsl_parser_extras.h | 7 +++ src/compiler/glsl_typ

[Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

In GLES, we currently either need an exact match with a local function, or an exact match with a builtin. However, if we add support for implicit conversions for GLES shaders, we also need to fall back to a non-exact match in the case where there were no builtin match either. Luckily, we already

[Mesa-dev] [PATCH 4/5] mesa/glsl: add support for EXT_shader_implicit_conversions

EXT_shader_implicit_conversions adds support for implicit conversions for GLES 3.1 and above. This is essentially a subset of ARB_gpu_shader5, and augments OES_gpu_shader5. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH 5/5] glsl: do not allow implicit casts of unsized array initializers

The GLSL 4.6 specification (section 4.1.14. "Implicit Conversions") says: "There are no implicit array or structure conversions. For example, an array of int cannot be implicitly converted to an array of float." So let's add a check in place when assigning array initializers to implicitly

[Mesa-dev] [PATCH 1/5] glsl: add has_implicit_conversions()-helper

This makes the code a bit easier to read, as well as will reduce repetition when we add support for EXT_shader_implicit_conversions. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_to_hir.cpp | 2 +- src/compiler/glsl/glsl_parser_extras.h | 5 + src/compiler/glsl_types.cpp

Re: [Mesa-dev] [PATCH 3/4] intel/decoder: tools: Use engine for decoding batch instructions

Yeah, true. Maybe put a default value on init (likely render) and let the caller of gen_print_batch() set the field on the line above. I could just like to leave the decode somewhat agnostic about what type of engine it's dealing with. - Lionel On 30/10/2018 16:21, Toni Lönnberg wrote: The e

[Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems reasonable to allow for the extension. This ended up mostly as code-cleanups anyway. While e

Re: [Mesa-dev] [PATCH] intel/compiler: Stop assuming the entrypoint is called "main"

On 30/10/2018 16:26, Jason Ekstrand wrote: This isn't true for Vulkan so we have to whack it to "main" in anv which is silly. Instead of walking the list of functions and asserting that everything is named "main" and hoping there's only one function named "main", just use the nir_shader_get_entr

Re: [Mesa-dev] [PATCH 2/2] anv: Bump the advertised patch version to 90

Reviewed-by: Lionel Landwerlin On 29/10/2018 14:44, Jason Ekstrand wrote: --- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index ab9240f9fd8..e9afe06bb13 100644

[Mesa-dev] [PATCH] intel/compiler: Stop assuming the entrypoint is called "main"

This isn't true for Vulkan so we have to whack it to "main" in anv which is silly. Instead of walking the list of functions and asserting that everything is named "main" and hoping there's only one function named "main", just use the nir_shader_get_entrypoint() helper which has better assertions a

Re: [Mesa-dev] [PATCH 3/4] intel/decoder: tools: Use engine for decoding batch instructions

The engine doesn't change inside a batch but it can change between batches, right? The options are either to pass the engine around or have it in the decoder context but it would need to be updated in the there before decoding a new batch. On Tue, Oct 30, 2018 at 02:58:32PM +, Lionel Landwe

Re: [Mesa-dev] [PATCH mesa] anv: only read the env once per process

NAK. There's really no reason to do this. If you're in the lost device case, you've just done an ioctl (expensive) and got a GPU hang (5 second watchdog timer). Also, it adds complexity to something that very badly needs to "just work". --Jason On Tue, Oct 30, 2018 at 11:09 AM Eric Engestrom

Re: [Mesa-dev] [PATCH mesa] anv: only read the env once per process

On Tuesday, 2018-10-30 16:09:49 +, Eric Engestrom wrote: > Suggested-by: Emil Velikov > Signed-off-by: Eric Engestrom > --- Sent the patch for the discussion, but I'm not sure this is that important; this code is for when a device is lost, which is not very common to say the least, and shavi

[Mesa-dev] [PATCH mesa] anv: only read the env once per process

Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index ee35e013329005671391..d0e83546b1197e362874 100644 --- a/src/in

Re: [Mesa-dev] [PATCH v2 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

With the format ordering in svga_format.c as Ilia mentioned fixed Reviewed-by: Roland Scheidegger Am 30.10.18 um 11:46 schrieb Gert Wollny: > This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new > format enum, the format entries in Gallium and and svga, the mapping between >

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #14 from Ahmed Elsayed --- I tried many times to record both games with DXVK on but it failed to run. But when I opened both games with DXVK off, the textures were very dark but there were no graphic glitches. -- You are receiving

Re: [Mesa-dev] [PATCH 3/3] anv: Handle the device loss abort in anv_device_set_lost

On Tue, 30 Oct 2018 at 15:07, Jason Ekstrand wrote: > > On Tue, Oct 30, 2018 at 10:04 AM Emil Velikov > wrote: >> >> On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote: >> > >> > --- >> > src/intel/vulkan/anv_device.c | 11 +++ >> > src/intel/vulkan/anv_util.c | 4 >> > 2 files

Re: [Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

I was thinking the exact same thing earlier but I didn't feel like changing too much of what was already there, thus keeping the enum. Can change it use the definition from uapi for v2. On Tue, Oct 30, 2018 at 02:58:28PM +, Lionel Landwerlin wrote: > I think we should switch to use drm_i915_

[Mesa-dev] [Bug 108601] gen_xmlpool.py fails if LANG=C.*

https://bugs.freedesktop.org/show_bug.cgi?id=108601 Dylan Baker changed: What|Removed |Added Blocks||108530 Referenced Bugs: https://bugs.fr

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Dylan Baker changed: What|Removed |Added Depends on||108601 Referenced Bugs: https://bugs.fr

[Mesa-dev] [Bug 108601] gen_xmlpool.py fails if LANG=C.*

https://bugs.freedesktop.org/show_bug.cgi?id=108601 Bug ID: 108601 Summary: gen_xmlpool.py fails if LANG=C.* Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

Reviewed-by: Dylan Baker Quoting Sergii Romantsov (2018-10-30 02:45:14) > Building of 32bit Mesa may fail if __SSE__ is not specified. > Added missed dependency from libm. > > CC: Dylan Baker > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 > Signed-off-by: Sergii Romantsov > --

Re: [Mesa-dev] [PATCH mesa] meson: add note about intel tools build options

Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-10-30 04:28:56) > Fixes: ea83a1d304dc97d1d155a "intel: tools: import ImGui" > Signed-off-by: Eric Engestrom > --- > meson_options.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson_options.txt b/meson_options

Re: [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote: > > On Tuesday, 2018-10-23 10:49:26 -0400, mesa-dev-boun...@lists.freedesktop.org > wrote: > > In the pursuit of lowering driver overhead, it became clear that some > > amount of redesign of how libdrm_freedreno constructs the submit ioctl > > w

Re: [Mesa-dev] [PATCH 00/31] nir: Use a 1-bit data type for booleans

On Tue, Oct 30, 2018 at 2:50 AM Iago Toral wrote: > Some quick comments on this after experimenting with it: > > Intel hardware produces booleans of the same bit-size as the operations > that generates them so I am working on expanding this to add another > lowering pass that can lower them to sm

Re: [Mesa-dev] [PATCH 3/3] anv: Handle the device loss abort in anv_device_set_lost

On Tue, Oct 30, 2018 at 10:04 AM Emil Velikov wrote: > On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote: > > > > --- > > src/intel/vulkan/anv_device.c | 11 +++ > > src/intel/vulkan/anv_util.c | 4 > > 2 files changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/src/

Re: [Mesa-dev] [PATCH 3/3] anv: Handle the device loss abort in anv_device_set_lost

On Thu, 25 Oct 2018 at 17:47, Jason Ekstrand wrote: > > --- > src/intel/vulkan/anv_device.c | 11 +++ > src/intel/vulkan/anv_util.c | 4 > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 79d3f

Re: [Mesa-dev] [PATCH 0/4] Engine parameter for instructions

If you could put the branch somewhere so I could skim through the xml changes. Thanks, - Lionel On 30/10/2018 14:32, Toni Lönnberg wrote: These patches add an engine parameter to the instructions defined in the genxml files so that they can be distinguished when sending them to different engi

Re: [Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

I think we should switch to use drm_i915_gem_engine_class from include/drm-uapi/i915_drm.h and just have macro for class id -> mask. On 30/10/2018 14:32, Toni Lönnberg wrote: Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a bitmask. The enumeration needs to be define

Re: [Mesa-dev] [PATCH 3/4] intel/decoder: tools: Use engine for decoding batch instructions

Since a batch will be given to a specific engine, the engine won't change change while decoding. So I would just store the engine into gen_batch_decode_ctx and set it in the init function, that'll reduce the diff a bit. Then just introduce a local find_instruction() function that calls gen_spe

Re: [Mesa-dev] [PATCH 2/2] kmsro: Extend to include hx8357d.

Hi Eric, On Thu, 25 Oct 2018 at 17:39, Eric Anholt wrote: > > This allows vc4 to initialize on the Adafruit PiTFT 3.5" touchscreen with > the new tinydrm driver I just submitted. If this series extending the > pl111/kmsro driver is accepted, then I'll extend kmsro with the other > tinydrm driver

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Respect non-blocking AcquireNextImage

Acked-by: Jason Ekstrand On Tue, Oct 30, 2018 at 7:56 AM Daniel Stone wrote: > If the client has requested that AcquireNextImage not block at all, with > a timeout of 0, then don't make any non-blocking calls. > > This will still potentially block infinitely given a non-infinte > timeout, but t

Re: [Mesa-dev] [PATCH mesa 10/12] util: s/0/NULL/ for pointer

On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/util/u_dynarray.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h > index c1aa79c8ac6ca8fce810..9bed2b9c25c879672e22 100644 > -

Re: [Mesa-dev] [PATCH mesa 05/12] mesa: fix memset(0) of non-trivial structs

On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 07/12] i965: turn "unreachable" assert() into unreachable()

On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c > b/src/mesa/drivers/dri/i965/inte

Re: [Mesa-dev] [PATCH mesa 08/12] i965: add missing case to fix -Wswitch

On Mon, 29 Oct 2018 at 17:17, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/4] intel/decoder: Engine parameter for instructions

Preliminary work for adding handling of different pipes to gen_decoder. Each instruction needs to have a definition describing which engine it is meant for. If left undefined, by default, the instruction is defined for all engines. --- src/intel/common/gen_decoder.c | 9 + src/intel/common

[Mesa-dev] [PATCH 0/4] Engine parameter for instructions

These patches add an engine parameter to the instructions defined in the genxml files so that they can be distinguished when sending them to different engines. By default, an instruction is defined to be used by all engines and is defined for a specific engine by adding the parameter "engine" to

[Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a bitmask. The enumeration needs to be defined in a single place that can be used by the decoder and tools. --- src/intel/common/gen_decoder.h | 6 ++ src/intel/tools/aub_read.c | 1 + src/intel/tools/aub_read.h

[Mesa-dev] [PATCH 3/4] intel/decoder: tools: Use engine for decoding batch instructions

The engine to which the batch was sent to is now passed along when decoding the batch. This is needed so that we can distinguish between instructions as the render and video pipe share some of the instruction opcodes. --- src/intel/common/gen_batch_decoder.c | 21 ++- src/

Re: [Mesa-dev] [PATCH mesa 06/12] mesa: fix struct/class mismatch

On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 01/12] scons: drop unused HAVE_STDINT_H macro

On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom I'd add some commit message here. The check/macro was required in the earlier days, when MSVC did not provide the header. Since the 2013 version (or was it earlier) it's around... just 14 years after the C99 st

Re: [Mesa-dev] [PATCH mesa 12/12] egl: add messages to a few assert() and turn a couple into unreachable()

On Mon, 29 Oct 2018 at 17:16, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/31] nir/opt_if: Rework condition propagation

Weird. I didn't expect this patch to have any impact whatsoever. I thought it was just moving around the way we emit stuff. On October 30, 2018 08:40:01 Iago Toral wrote: Jason, JFYI, I have been looking into the cases where the boolean bitsize lowering pass was producing worse instruction c

[Mesa-dev] [PATCH] radv: use pool->stride when calling radv_query_shader()

Not needed to recompute the stride. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c index 5a326c9df54..318d6c7afee 100644 --- a/src/amd/vulkan/radv_que

Re: [Mesa-dev] [PATCH 07/31] nir/opt_if: Rework condition propagation

Jason, JFYI, I have been looking into the cases where the boolean bitsize lowering pass was producing worse instruction counts that the default 32-bit pass and I have tracked it down to this patch. Reverting this makes the instruction count much better for some tests, I'll check why this happens to

  1   2   >