Re: [Mesa-dev] [PATCH 04/11] gallium: Use Array._DrawVAO in st_atom_array.c.

2018-04-22 Thread Mathias Fröhlich
Hi Marek, On Tuesday, 10 April 2018 20:09:06 CEST Marek Olšák wrote: > Generally, if you have to loop over all arrays to find common vertex > buffers, it's better not to do it. The default separate path is going to > perform best, because it's straightforward and interleaved arrays are super > rar

Re: [Mesa-dev] [PATCH] mesa: rename api_validate.{c, h} -> draw_validate.{c, h}

2018-04-22 Thread Mathias Fröhlich
Good Morning, I was thinking to also basically 'move' vbo/vbo_exec_array.c to main/draw.c as drawing arrays is today largely independent of the vbo module. Its more the other way round that the vbo module utilizes the draw code path one notch below the opengl entry points (... validate, set the

[Mesa-dev] [PATCH 4/4] gallivm: dump bitcode before optimization

2018-04-22 Thread sroland
From: Roland Scheidegger If we dump the bitcode for off-line debug purposes, we really want the pre-optimized bitcode, otherwise it's useless in identifying problems with IR optimization (if you have a shader which takes an hour to do IR optimization, it's also nice you don't have to wait that ho

[Mesa-dev] [PATCH 3/4] gallivm: (trivial) do division by 1000 with int64

2018-04-22 Thread sroland
From: Roland Scheidegger Conversion to int can otherwise overflow if compile times are over ~71min. (Yes this can happen...) --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/gall

[Mesa-dev] [PATCH 2/4] gallivm: remove LICM pass

2018-04-22 Thread sroland
From: Roland Scheidegger LICM is simply too expensive, even though it presumably can help quite a bit in some cases. It was definitely cheaper in llvm 3.3, though as far as I can tell with llvm 3.3 it failed to do anything in most cases. early-cse also actually seems to cause licm to be able to m

[Mesa-dev] [PATCH 1/4] gallivm: add early cse pass

2018-04-22 Thread sroland
From: Roland Scheidegger This pass is quite cheap, and can simplify the IR quite a bit for our generated IR. In particular on a variety of shaders I've found the time saved by other passes due to the simplified IR more than makes up for the cost of this pass, and on top of that the end result is

[Mesa-dev] [Bug 76694] Inconsistent behaviour of LIBGL_DEBUG

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76694 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [PATCH] mesa: rename api_validate.{c, h} -> draw_validate.{c, h}

2018-04-22 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65422 --- src/mesa/Makefile.sources | 4 ++-- src/mesa/main/dlist.c | 2 +- src/mesa/main/{api_validate.c => draw_validate.c} | 2 +- src/mesa/main/{api_validate.h => draw_validate.h} | 0 sr

[Mesa-dev] [Bug 48837] infinite loop in swrast

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48837 Timothy Arceri changed: What|Removed |Added Component|Mesa core |Drivers/DRI/swrast -- You are receivin

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-22 Thread Chih-Wei Huang
What's the impact to drm_gralloc? 2018-04-20 5:09 GMT+08:00 Rob Herring : > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header. > > This mostly remo

Re: [Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor max simd waves into common code.

2018-04-22 Thread Bas Nieuwenhuizen
Actually as a followup you might want to deduplicate the wavefrontsPerSimd in radv_device.c too. On Mon, Apr 23, 2018 at 2:17 AM, Dave Airlie wrote: > From: Dave Airlie > > --- > src/amd/common/ac_gpu_info.h | 16 > src/amd/vulkan/radv_shader.c | 12 +---

Re: [Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

2018-04-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Apr 23, 2018 at 1:59 AM, Dave Airlie wrote: > From: Dave Airlie > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 33 ++--- > 1 file changed, 2 insertions(+), 31 deletions(-) > > diff --git a/src/gallium/drive

Re: [Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor max simd waves into common code.

2018-04-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Apr 23, 2018 at 2:17 AM, Dave Airlie wrote: > From: Dave Airlie > > --- > src/amd/common/ac_gpu_info.h | 16 > src/amd/vulkan/radv_shader.c | 12 +--- > src/gallium/drivers/radeonsi/si_shad

Re: [Mesa-dev] [PATCH] glsl/glcpp: Handle hex constants with 0X prefix

2018-04-22 Thread Timothy Arceri
On 20/04/18 06:08, Vlad Golovkin wrote: GLSL 4.6 spec describes hex constant as: hexadecimal-constant: 0x hexadecimal-digit 0X hexadecimal-digit hexadecimal-constant hexadecimal-digit Right now if you have a shader with the following structure: #if 0X1 // or any hex numbe

Re: [Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor harvest config register getters.

2018-04-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Apr 23, 2018 at 2:43 AM, Dave Airlie wrote: > From: Dave Airlie > > This refactors the code out to share it between radv and radeonsi. > --- > src/amd/common/ac_gpu_info.c| 113 > > src/amd/co

Re: [Mesa-dev] [PATCH] nir: Do not use progress for unreachable code in return lowering.

2018-04-22 Thread Bas Nieuwenhuizen
On Mon, Apr 23, 2018 at 2:20 AM, Timothy Arceri wrote: > > > On 23/04/18 03:26, Bas Nieuwenhuizen wrote: >> >> We seems to use progress for two cases: > > > seems -> seem > >> 1) When we lowered some returns. >> 2) When we remove unreachable code. >> >> If just case 2 happens we assert as state->r

[Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor harvest config register getters.

2018-04-22 Thread Dave Airlie
From: Dave Airlie This refactors the code out to share it between radv and radeonsi. --- src/amd/common/ac_gpu_info.c| 113 src/amd/common/ac_gpu_info.h| 4 ++ src/amd/vulkan/si_cmd_buffer.c | 108 ++

[Mesa-dev] [PATCH 1/2] radv: only set raster_config_1 outside the index registers.

2018-04-22 Thread Dave Airlie
From: Dave Airlie This follows what radeonsi does. Ported from radeonsi: radeonsi: emit PA_SC_RASTER_CONFIG_1 only once --- src/amd/vulkan/si_cmd_buffer.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/s

[Mesa-dev] [Bug 99179] Mesa freezez the pc when running nativ games for linux

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99179 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 99125] Log to a file all GALLIUM_HUD infos

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99125 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 92877] Add support for libglvnd

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] nir: Do not use progress for unreachable code in return lowering.

2018-04-22 Thread Timothy Arceri
On 23/04/18 03:26, Bas Nieuwenhuizen wrote: We seems to use progress for two cases: seems -> seem 1) When we lowered some returns. 2) When we remove unreachable code. If just case 2 happens we assert as state->return_flag has not been allocated yet, but we are still trying to do insert all

[Mesa-dev] [PATCH 2/2] ac/radv/radeonsi: refactor max simd waves into common code.

2018-04-22 Thread Dave Airlie
From: Dave Airlie --- src/amd/common/ac_gpu_info.h | 16 src/amd/vulkan/radv_shader.c | 12 +--- src/gallium/drivers/radeonsi/si_shader.c | 12 +--- 3 files changed, 18 insertions(+), 22 deletions(-) diff --git a/src/amd/common/ac_gpu_inf

[Mesa-dev] [PATCH 1/2] ac/radv/radeonsi: refactor raster_config default values getters.

2018-04-22 Thread Dave Airlie
From: Dave Airlie This just makes this common code between the two drivers. --- src/amd/common/ac_gpu_info.c| 93 + src/amd/common/ac_gpu_info.h| 4 +- src/amd/vulkan/si_cmd_buffer.c | 85 ++ src/galliu

[Mesa-dev] [PATCH 3/5] ac/info: move gs table depth to common code.

2018-04-22 Thread Dave Airlie
From: Dave Airlie --- src/amd/common/ac_gpu_info.c | 33 + src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 34 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index ef0364b0534..12b03c4ea29 100644 --- a/src/amd/common/a

[Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

2018-04-22 Thread Dave Airlie
From: Dave Airlie --- src/gallium/drivers/radeonsi/si_pipe.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index b3ef098b8ea..327dd7c4242 100644 --- a/src/gal

[Mesa-dev] [PATCH 4/5] radv: use common gs_table_depth code.

2018-04-22 Thread Dave Airlie
From: Dave Airlie --- src/amd/vulkan/radv_device.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index c687b23f27d..8837d6cafde 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/

[Mesa-dev] [PATCH 1/5] radv/gfx9: don't use gs_table_depth on gfx9.

2018-04-22 Thread Dave Airlie
From: Dave Airlie Missed this on initial radeonsi port, we shouldn't use this value on gfx9, but also in gfx8 only for when we have a geom shader. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 6 +++--- src/amd/vulkan/radv_pipeline.c | 5 +++-- 2 files changed, 6 insertions(+

[Mesa-dev] [PATCH 2/5] radeonsi: don't runtime check gs table info

2018-04-22 Thread Dave Airlie
From: Dave Airlie We can just unreachable here, this aligns with radv code, makes it easier to move to common code. --- src/gallium/drivers/radeonsi/si_pipe.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/

[Mesa-dev] [Bug 106176] [mesa] git master VERSION not increased when 18.1 was branched off

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106176 --- Comment #3 from LoneVVolf --- Thank you for the fast response. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing li

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 --- Comment #1 from mercuriete --- not sure if i forget to put this: x11-base/xorg-server-1.19.5-r1 x11-base/xorg-drivers-1.19 I think I am using xorg modesetting. -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 106180] [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2)

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106180 Bug ID: 106180 Summary: [bisected] radv vulkan smoke test black screen (Add support for DRI3 v1.2) Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] 16-bit comparisons in NIR

2018-04-22 Thread Iago Toral
On Fri, 2018-04-20 at 17:16 -0700, Jason Ekstrand wrote: > On Fri, Apr 20, 2018 at 5:16 AM, Nicolai Hähnle > wrote: > > On 20.04.2018 10:21, Iago Toral wrote: > > > > > Hi, > > > > > > > > > > > > while developing support for Vulkan shaderInt16 on Anvil I came > > > across > > > > > > a featu

[Mesa-dev] [Bug 106174] vulkan dota2 broken (segfaulting), found bug commit

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106174 --- Comment #2 from Sylvain BERTRAND --- On Sun, Apr 22, 2018 at 05:28:45PM +, bugzilla-dae...@freedesktop.org wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=106174 > > --- Comment #1 from Bas Nieuwenhuizen --- > Yeah, I noticed thi

[Mesa-dev] [Bug 106174] vulkan dota2 broken (segfaulting), found bug commit

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106174 --- Comment #1 from Bas Nieuwenhuizen --- Yeah, I noticed this too. https://patchwork.freedesktop.org/patch/218205/ should fix this. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug

[Mesa-dev] [PATCH] nir: Do not use progress for unreachable code in return lowering.

2018-04-22 Thread Bas Nieuwenhuizen
We seems to use progress for two cases: 1) When we lowered some returns. 2) When we remove unreachable code. If just case 2 happens we assert as state->return_flag has not been allocated yet, but we are still trying to do insert all predicates based on it. This splits the concerns. We only use pr

[Mesa-dev] [Bug 106176] [mesa] git master VERSION not increased when 18.1 was branched off

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106176 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 106176] [mesa] git master VERSION not increased when 18.1 was branched off

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106176 --- Comment #1 from LoneVVolf --- Created attachment 138989 --> https://bugs.freedesktop.org/attachment.cgi?id=138989&action=edit increase number in VERSION-file -- You are receiving this mail because: You are the assignee for the bug. You a

Re: [Mesa-dev] [PATCH] android: gallium/util: fix u_debug_stack_android build

2018-04-22 Thread Stefan Schake
On Sun, Apr 22, 2018 at 1:11 PM, Mauro Rossi wrote: > Fix for build errors in src/gallium/auxiliary/util/u_debug_stack_android.cpp > error: cast to 'void *' from smaller integer type pid_t > > Fixes: ff904978a1 ("gallium/util: Android backtrace support") > > Cc: "18.1" > --- > src/gallium/auxili

[Mesa-dev] [Bug 106176] [mesa] git master VERSION not increased when 18.1 was branched off

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106176 Bug ID: 106176 Summary: [mesa] git master VERSION not increased when 18.1 was branched off Product: Mesa Version: git Hardware: All OS: All Sta

[Mesa-dev] [PATCH] android: gallium/util: fix u_debug_stack_android build

2018-04-22 Thread Mauro Rossi
Fix for build errors in src/gallium/auxiliary/util/u_debug_stack_android.cpp error: cast to 'void *' from smaller integer type pid_t Fixes: ff904978a1 ("gallium/util: Android backtrace support") Cc: "18.1" --- src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++-- 1 file changed, 2 inse

[Mesa-dev] [Bug 106174] vulkan dota2 broken (segfaulting), found bug commit

2018-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106174 Bug ID: 106174 Summary: vulkan dota2 broken (segfaulting), found bug commit Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW