[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- Comment #7 from Adrià Cereto i Massagué --- The same behaviour can be observed on my Vega 56 when trying to run some games through DXVK. I'll try the patch to see whether it fixes it in that case too. -- You are receiving this mail becaus

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-15 Thread Francisco Jerez
Jan Vesely writes: > On Thu, 2018-02-15 at 20:36 -0800, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Thu, 2018-02-08 at 15:56 -0800, Francisco Jerez wrote: >> > > Jan Vesely writes: >> > > >> > > > On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: >> > > > > (Moving the conve

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-15 Thread Jan Vesely
On Thu, 2018-02-15 at 20:36 -0800, Francisco Jerez wrote: > Jan Vesely writes: > > > On Thu, 2018-02-08 at 15:56 -0800, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: > > > > > (Moving the conversation to its own thread.) >

Re: [Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

2018-02-15 Thread Mathias Fröhlich
Hi Brian, Thanks for the review so far! Two comments/questions below: On Friday, 16 February 2018 00:27:16 CET Brian Paul wrote: > > +/** > > + * Initialize inputs. > > + */ > > +void > > +_vbo_array_init(struct vbo_inputs *inputs); > > + > > + > > +/** > > + * Update the gl_vertex_array array in

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #48 from Alex --- Yes, the shim seems to no longer work -- I assume newer Mesa versions are no longer declaring compatibility with whatever version Divinity was hardcoded to? It's probably possible to create another workaround, but I

[Mesa-dev] [PATCH v2 2/2] radeonsi/nir: fix gl_FragCoord for pixel_center_integer

2018-02-15 Thread Timothy Arceri
Fixes piglit test glsl-arb-fragment-coord-conventions --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 5ea1b4f033..ea9f2076da 100644 --- a/src

[Mesa-dev] [PATCH v2 1/2] glsl/nir: add pixel_center_integer to shader info

2018-02-15 Thread Timothy Arceri
--- src/compiler/glsl/glsl_to_nir.cpp | 5 + src/compiler/shader_info.h| 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 1a579f41cd..7a9d15015e 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++ b/src/com

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-15 Thread Francisco Jerez
Jan Vesely writes: > On Thu, 2018-02-08 at 15:56 -0800, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: >> > > (Moving the conversation to its own thread.) >> > > >> > > > target agnostic libclc is rather difficult to do. CLC include

Re: [Mesa-dev] clover: Fix build after llvm r325155 and r325160

2018-02-15 Thread Dieter Nützel
Hello Jan, something semilar is needed fro libclc, too. LLVM-CC nvptx64--nvidiacl/lib/geometric/dot.cl.bc ./utils/prepare-builtins.cpp:108:3: error: no matching function for call to 'WriteBitcodeToFile' WriteBitcodeToFile(M, Out->os()); ^~ /usr/local/include/llvm/Bitcode/Bi

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-15 Thread Timothy Arceri
On 15/02/18 20:06, Bas Nieuwenhuizen wrote: On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri wrote: On 15/02/18 04:39, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote: Fixes

[Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop (attempt 2)

2018-02-15 Thread Dave Airlie
From: Dave Airlie A bunch of CTS tests led me to write tests/shaders/ssa/fs-while-loop-rotate-value.shader_test which r600/sb always fell over on. GCM seems to move some of the copys into other basic blocks, if we don't allow this to happen then it doesn't seem to schedule them badly. Everythin

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-15 Thread Jan Vesely
On Thu, 2018-02-08 at 15:56 -0800, Francisco Jerez wrote: > Jan Vesely writes: > > > On Thu, 2018-02-08 at 23:16 +0100, Pierre Moreau wrote: > > > (Moving the conversation to its own thread.) > > > > > > > target agnostic libclc is rather difficult to do. CLC includes 3 levels > > > > of precisi

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-15 Thread Tomasz Figa
On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring wrote: > On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: >> On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: >>> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: > Hi Rob, > >>

Re: [Mesa-dev] [PATCH 00/10] intel/anv: Prepare to add Ice Lake (ICL) support

2018-02-15 Thread Jason Ekstrand
I made a few fairly trivial comments but it all looks pretty good. Reviewed-by: Jason Ekstrand On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat wrote: > This series prepares the driver to enable Ice Lake support > in Vulkan driver. It wires up the build infrastructure and > make few ICL specific c

Re: [Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/genX_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c > index 54fb8634fd..f39508034f 100644 > -

Re: [Mesa-dev] [PATCH 10/10] anv/icl: Add render target flush after uploading binding table

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat wrote: > The PIPE_CONTROL command description says: > > "Whenever a Binding Table Index (BTI) used by a Render Taget Message > points to a different RENDER_SURFACE_STATE, SW must issue a Render > Target Cache Flush by enabling this bit. When render tar

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 --- Comment #2 from Jakub Okoński --- I ran my code on Windows using AMD's proprietary driver, I can see this message from validation layers: Attempt to reset command buffer (0x026469454060) which is in use. The spec valid usage text states

Re: [Mesa-dev] [PATCH 05/10] anv/icl: Don't use DISPATCH_MODE_SIMD4X2

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 5:44 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/genX_pipeline.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_ > pipeline.c > index 85391c93ca..290d78e608 100644

[Mesa-dev] [PATCH 04/10] anv/icl: Don't use SingleVertexDispatch

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 784559380d..85391c93ca 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline

[Mesa-dev] [PATCH 05/10] anv/icl: Don't use DISPATCH_MODE_SIMD4X2

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_pipeline.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 85391c93ca..290d78e608 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pip

[Mesa-dev] [PATCH 06/10] anv/icl: Generate gen11 entry point functions

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 1bab885180..c5a654f19b 100644 --- a/src/intel/vulkan/anv_entrypo

[Mesa-dev] [PATCH 09/10] anv/icl: Enable float blend optimization

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index 54fb8634fd..f39508034f 100644 --- a/src/intel/vulkan/genX_state.c +++ b/src/intel/vulkan/genX_state.

[Mesa-dev] [PATCH 10/10] anv/icl: Add render target flush after uploading binding table

2018-02-15 Thread Anuj Phogat
The PIPE_CONTROL command description says: "Whenever a Binding Table Index (BTI) used by a Render Taget Message points to a different RENDER_SURFACE_STATE, SW must issue a Render Target Cache Flush by enabling this bit. When render target flush is set due to new association of BTI, PS Scoreboard S

[Mesa-dev] [PATCH 01/10] anv/icl: Add gen11 mocs defines

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_private.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index d38dd9e422..009f5304f2 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_privat

[Mesa-dev] [PATCH 07/10] anv/icl: Build anv libs for gen11

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/Android.vulkan.mk | 21 + src/intel/Makefile.sources | 4 src/intel/Makefile.vulkan.am | 7 ++- src/intel/vulkan/meson.build | 2 +- 4 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/intel/Android.vulkan

[Mesa-dev] [PATCH 02/10] anv/icl: Add #define genX

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_private.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 009f5304f2..9822afb81d 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -30

[Mesa-dev] [PATCH 03/10] anv/icl: Don't set ResetGatewayTimer

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/genX_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 45ebe31de6..784559380d 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/intel/vulkan/genX_pipeline

[Mesa-dev] [PATCH 08/10] anv/icl: Use gen11 functions

2018-02-15 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_blorp.c | 3 +++ src/intel/vulkan/anv_device.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index d38b343671..d98bf8364d 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/

[Mesa-dev] [PATCH 00/10] intel/anv: Prepare to add Ice Lake (ICL) support

2018-02-15 Thread Anuj Phogat
This series prepares the driver to enable Ice Lake support in Vulkan driver. It wires up the build infrastructure and make few ICL specific changes suggested by h/w documentation. This is not everything we need to enable Vulkan on Ice Lake. Series is also available in my review branch at github. h

Re: [Mesa-dev] [PATCH] virgl: remap query types to hw support.

2018-02-15 Thread Gurchetan Singh
This also fixes: dEQP-GLES3.functional.transform_feedback.array.separate* dEQP-GLES3.functional.transform_feedback.array_element* dEQP-GLES3.functional.transform_feedback.interpolation.* Gallium's p_defines.h and virglrenderer's p_defines.h have diverged quite a bit, so not including PIPE_QUERY_O

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Alexander von Gluck IV
February 15, 2018 6:36 PM, "Dylan Baker" wrote: > Quoting Alexander von Gluck IV (2018-02-15 16:04:37) > >> I'm actually not 100% sure here. I have missing symbols at link without both >> included. More investigation needed on my part. > > That may be my fault, on Linux and the BSDs have have t

[Mesa-dev] [PATCH 2/3] radeonsi: add nir shader cache support

2018-02-15 Thread Timothy Arceri
In future we might want to try avoid calling nir_serialize() but this works for now. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/dr

[Mesa-dev] [PATCH 3/3] st/shader_cache: copy nir pointer to gl_program after deserializing

2018-02-15 Thread Timothy Arceri
This fixes a crash when running the arb_get_program_binary-api-errors piglit test twice. --- src/mesa/state_tracker/st_shader_cache.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_shader_cache.c b/src/mesa/state_tracker/st_shader_cache.c index 6ff404220a..3ca

[Mesa-dev] [PATCH 1/3] radeonsi: rename variables tgsi_binary -> ir_binary

2018-02-15 Thread Timothy Arceri
This better represents that the ir could be either tgsi or nir. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 42 - 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_sta

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Dylan Baker
Quoting Alexander von Gluck IV (2018-02-15 16:04:37) > I'm actually not 100% sure here. I have missing symbols at link without both > included. More investigation needed on my part. That may be my fault, on Linux and the BSDs have have to have shared_glapi because you need it to do GLES, but if yo

[Mesa-dev] [PATCH] meson: Add Haiku platform support v3

2018-02-15 Thread Alexander von Gluck IV
--- include/meson.build| 8 + meson.build| 18 +++ src/egl/meson.build| 34 - src/gallium/meson.build| 9 ++ src/gallium/state_trackers/hgl/meso

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Alexander von Gluck IV
February 15, 2018 5:37 PM, "Dylan Baker" wrote: > Quoting Alexander von Gluck IV (2018-02-15 13:12:40) > >> --- >> include/meson.build | 8 + >> meson.build | 18 +++--- >> src/egl/meson.build | 33 + >> src/gallium/meson.build | 9 + >> src/gallium/state_trackers/hgl/mes

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Dylan Baker
Quoting Alexander von Gluck IV (2018-02-15 13:12:40) > --- > include/meson.build| 8 + > meson.build| 18 +++--- > src/egl/meson.build| 33 + > src/gallium/meson.build

Re: [Mesa-dev] [PATCH 06/13] vbo: Use _DrawVAO for array type draw commands.

2018-02-15 Thread Brian Paul
On 02/15/2018 12:55 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Switch over to use the _DrawVAO for all the array type draws. The _DrawVAO needs to be set before we enter _mesa_update_state, so move setting the draw method in front of the first call to _mesa_update_state which i

Re: [Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

2018-02-15 Thread Brian Paul
On 02/15/2018 12:55 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Provided the _DrawVAO and the derived state that is maintained if we have the _DrawVAO set, implement a method to incrementally update the array of gl_vertex_array input pointers. Signed-off-by: Mathias Fröhlich -

Re: [Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

2018-02-15 Thread Brian Paul
On 02/15/2018 12:55 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will be used for immediate mode and dlist rendering. Signed-off-by: Mathias Fröhlich --- src/mesa/main/

Re: [Mesa-dev] [PATCH V2 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-15 Thread Kenneth Graunke
On Thursday, February 15, 2018 2:16:54 PM PST Anuj Phogat wrote: > +Ken > > On Thu, Feb 15, 2018 at 11:11 AM, Anuj Phogat wrote: > > From PIPE_CONTROL command description in gfxspecs: > > > > "Whenever a Binding Table Index (BTI) used by a Render Taget Message > > points to a different RENDER_SU

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > If PresentCompleteNotify event says the pixmap was presented > with mode PresentCompleteModeSuboptimalCopy, it means the pixmap > could possibly have been flipped instead if allocated with a > differen

Re: [Mesa-dev] [PATCH 10/11] egl/x11: Support DRI3 v1.1

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > Add support for DRI3 v1.1, which allows pixmaps to be backed by > multi-planar buffers, or those with format modifiers. This is both > for allocating render buffers, as well as EGLImage imports from a

Re: [Mesa-dev] [PATCH V2 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-15 Thread Anuj Phogat
+Ken On Thu, Feb 15, 2018 at 11:11 AM, Anuj Phogat wrote: > From PIPE_CONTROL command description in gfxspecs: > > "Whenever a Binding Table Index (BTI) used by a Render Taget Message > points to a different RENDER_SURFACE_STATE, SW must issue a Render > Target Cache Flush by enabling this bit.

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build after llvm r325155 and r325160

2018-02-15 Thread Francisco Jerez
Jan Vesely writes: > r325155 ("Pass a reference to a module to the bitcode writer.") > and > r325160 ("Pass module reference to CloneModule") > > change function interface from pointer to reference. > > Signed-off-by: Jan Vesely > --- > .../state_trackers/clover/llvm/codegen/bitcode.cpp | 2 +-

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 Jakub Okoński changed: What|Removed |Added CC||ja...@okonski.org -- You are receiving

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 --- Comment #1 from Jakub Okoński --- Created attachment 137385 --> https://bugs.freedesktop.org/attachment.cgi?id=137385&action=edit single frame render that exits cleanly -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 Bug ID: 105119 Summary: Desktop-wide input freeze when vulkan (radv) Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Sev

Re: [Mesa-dev] [PATCH] radv: Always lower indirect derefs after nir_lower_global_vars_to_local.

2018-02-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 16/02/18 07:40, Bas Nieuwenhuizen wrote: Otherwise new local variables can cause hangs on vega. CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- src/amd/vulkan/radv_pipeline.c | 11 +-- src/amd/vulkan/radv_shader.c | 74

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

2018-02-15 Thread Timothy Arceri
Here are the IVB shader-db results: instructions helped: shaders/closed/steam/dex/63.shader_test FS SIMD8: 1303 -> 1300 (-0.23%) instructions helped: shaders/closed/steam/gang-beasts/111.shader_test FS SIMD8: 1303 -> 1300 (-0.23%) instructions helped: shaders/closed/steam/rocketsrocketsroc

Re: [Mesa-dev] [PATCH 09/11] vulkan/wsi: Return VK_SUBOPTIMAL_KHR for X11

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > When it is detected that a window could have been flipped > but has been copied because of suboptimal format/modifier. > The Vulkan client should then re-create the swapchain. > > Signed-off-by: Louis-

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v2

2018-02-15 Thread Alexander von Gluck IV
February 15, 2018 3:22 PM, "Alexander von Gluck IV" wrote: > --- > include/meson.build | 8 + > meson.build | 18 +++--- > src/egl/meson.build | 35 +- > src/gallium/meson.build | 9 + > src/gallium/state_trackers/hgl/meson.build | 41 + > src/gallium/ta

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- Comment #6 from Lukas Kahnert --- My App is more or less the same than the triangle demo(I try to learn Vulkan, but this issue was definitely not normal for invalid API usage ;)). With this patch it does't hang now and works as expected. Th

Re: [Mesa-dev] [PATCH 14/16] intel/common/icl: Add has_sample_with_hiz flag in gen_device_info

2018-02-15 Thread Kenneth Graunke
On Thursday, February 15, 2018 11:09:09 AM PST Anuj Phogat wrote: > Sampling from hiz is enabled in i965 for GEN9+ but this feature has > been removed from gen11. So, this new flag will be useful to turn > the feature on/off for different gen h/w. It will be used later > in a patch adding device in

[Mesa-dev] [PATCH] meson: Add Haiku platform support v2

2018-02-15 Thread Alexander von Gluck IV
--- include/meson.build| 8 + meson.build| 18 +++--- src/egl/meson.build| 35 +- src/gallium/meson.build| 9 + src/gallium/state_trackers/hgl/meson.bui

[Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Alexander von Gluck IV
--- include/meson.build| 8 + meson.build| 18 +++--- src/egl/meson.build| 33 + src/gallium/meson.build| 9 + src/gallium/state_trackers/hgl/meson.buil

Re: [Mesa-dev] [PATCH] i965: Fix aux-surface size check

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:42 AM, Daniel Stone wrote: > The previous commit reworked the checks intel_from_planar() to check the > right individual cases for regular/planar/aux buffers, and do size > checks in all cases. > > Unfortunately, the aux size check was broken, and required the aux > surf

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105098 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Bas Ni

[Mesa-dev] [PATCH] radv: Always lower indirect derefs after nir_lower_global_vars_to_local.

2018-02-15 Thread Bas Nieuwenhuizen
Otherwise new local variables can cause hangs on vega. CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- src/amd/vulkan/radv_pipeline.c | 11 +-- src/amd/vulkan/radv_shader.c | 74 +++--- src/amd/vulkan/radv_shader.h | 4 +++ 3 fil

Re: [Mesa-dev] [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display

2018-02-15 Thread Keith Packard
Eric Engestrom writes: > Can be simplified a bit: > > _xlib_lease = get_option('xlib-lease') > if _xlib_lease == 'auto' > with_xlib_lease = with_platform_x11 and with_platform_display > else > with_xlib_lease = _xlib_lease == 'true' > endif > > (We also usually try to avoid changi

[Mesa-dev] [PATCH 1/1] clover: Fix build after llvm r325155 and r325160

2018-02-15 Thread Jan Vesely
r325155 ("Pass a reference to a module to the bitcode writer.") and r325160 ("Pass module reference to CloneModule") change function interface from pointer to reference. Signed-off-by: Jan Vesely --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 2 +- .../state_trackers/clover/llvm/code

[Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. The function will be needed later in the series. Signed-off-by: Mathias Fröhlich --- src/mesa/main/varray.c | 38

[Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Provided the _DrawVAO and the derived state that is maintained if we have the _DrawVAO set, implement a method to incrementally update the array of gl_vertex_array input pointers. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo.h | 28 + src/

[Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will be used for immediate mode and dlist rendering. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 4 src/mesa/main/attrib.c | 2 ++ src/

[Mesa-dev] [PATCH 06/13] vbo: Use _DrawVAO for array type draw commands.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the _DrawVAO for all the array type draws. The _DrawVAO needs to be set before we enter _mesa_update_state, so move setting the draw method in front of the first call to _mesa_update_state which is in turn called from the *validate*Draw* calls. Using the

[Mesa-dev] [PATCH 07/13] mesa: Add flush_vertices to _mesa_{enable, disable}_vertex_array_attrib.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/main/enable.c | 4 ++-- src/mesa/main/varray.c | 30 +++--- src/me

[Mesa-dev] [PATCH 00/13] Switch over to use VAOs for drawing.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, The following series moves over to draw via a VAO in all draw paths. At the current stage this introduces an additional indirection for the immediate mode and display list draws. But in the mid term using a VAO should enable drivers to make use of the binding informati

[Mesa-dev] [PATCH 13/13] vbo: Make use of _DrawVAO from the dlist code.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Finally use an internal VAO to execute display list draws. Avoid duplicate state validation for display list draws. Remove client arrays previously used exclusively for display lists. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.c | 37 ++-- sr

[Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for those and only those VAO objects. Signed-off-by: Mathias Fröhlich --- src/mesa/main/

[Mesa-dev] [PATCH 09/13] mesa: Add flush_vertices to _mesa_bind_vertex_buffer.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 16 +--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/varray.c | 15 --- src/mesa/main/varray.h

[Mesa-dev] [PATCH 10/13] vbo: Implement tool functions for vbo specific VAO setup.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Correct VBO_MATERIAL_SHIFT value. The functions will be used next in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_attrib.h | 4 ++-- src/mesa/vbo/vbo_private.h | 53 ++ 2 files changed, 55 insertions(+),

[Mesa-dev] [PATCH 02/13] vbo: Use _VPMode instead of get_vp_mode().

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich At those places where we used get_vp_mode() use gl_vertex_program_state::_VPMode instead. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.c | 4 ++-- src/mesa/vbo/vbo_exec_array.c | 11 ++- src/mesa/vbo/vbo_exec_draw.c | 5 +++-- src/mesa/vbo/v

[Mesa-dev] [PATCH 11/13] vbo: Make use of _DrawVAO from immediate mode draw

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Finally use an internal VAO to execute immediate mode draws. Avoid duplicate state validation for immediate mode draws. Remove client arrays previously used exclusively for immediate mode draws. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c | 8 +++

[Mesa-dev] [PATCH 03/13] vbo: Remove get_vp_mode() and enum vp_mode.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Is now unused. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_private.h | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/vbo/vbo_private.h b/src/mesa/vbo/vbo_private.h index e44a521b11..49922892e5 100644 --- a/src/mesa/vbo/vb

[Mesa-dev] [PATCH 01/13] mesa: Provide an alternative to get_vp_mode()

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich To get equivalent information than get_vp_mode(), track the vertex processing mode in a per context variable at gl_vertex_program_state::_VPMode. This aims to replace get_vp_mode() as seen in the vbo module. But instead of the get_vp_mode() implementation which only gives c

Re: [Mesa-dev] [PATCH 03/11] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Jason Ekstrand > > This involves extending our fake extension a bit to allow for additional > querying and passing of modifier information. The added bits are > intended to look a lot like the draft of VK_EXT_image_drm_format_modifier

Re: [Mesa-dev] [PATCH 06/11] meson: Move Wayland dmabuf to wayland-drm

2018-02-15 Thread Dylan Baker
Quoting Daniel Stone (2018-02-15 07:57:36) > As the comment notes: linux-dmabuf has nothing to do with wayland-drm, > but we need a single place to build these files we can use from both EGL > and Vulkan, which is guaranteed to be included before both EGL and > Vulkan WSI. > > Signed-off-by: Danie

Re: [Mesa-dev] [PATCH 07/11] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer > modifiers. > > Signed-off-by: Daniel Stone > --- > src/vulkan/Makefile.am | 10 +++ > src/vulkan/Makefile.sources | 4 +- > src/vulkan/wsi/meson.build

[Mesa-dev] [PATCH V2 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-15 Thread Anuj Phogat
From PIPE_CONTROL command description in gfxspecs: "Whenever a Binding Table Index (BTI) used by a Render Taget Message points to a different RENDER_SURFACE_STATE, SW must issue a Render Target Cache Flush by enabling this bit. When render target flush is set due to new association of BTI, PS S

[Mesa-dev] [PATCH 14/16] intel/common/icl: Add has_sample_with_hiz flag in gen_device_info

2018-02-15 Thread Anuj Phogat
Sampling from hiz is enabled in i965 for GEN9+ but this feature has been removed from gen11. So, this new flag will be useful to turn the feature on/off for different gen h/w. It will be used later in a patch adding device info for gen11. Suggested-by: Kenneth Graunke Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-15 Thread Anuj Phogat
On Thu, Feb 15, 2018 at 9:49 AM, Emil Velikov wrote: > On 13 February 2018 at 19:15, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/intel/Android.genxml.mk | 5 + >> src/intel/Makefile.sources| 3 ++- >> src/intel/genxml/genX_pack.h | 2 ++ >> src/intel/genxml/gen_mac

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

2018-02-15 Thread Dylan Baker
Quoting Emil Velikov (2018-02-15 09:37:01) > On 12 February 2018 at 19:27, Dylan Baker wrote: > > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > > Signed-off-by: Dylan Baker > > --- > > src/gallium/targets/d3dadapter9/meson.build | 13 +++-- > > 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH 07/15] util/bitset: Add C++ wrapper for static-size bitsets.

2018-02-15 Thread Francisco Jerez
Eric Engestrom writes: > On Wednesday, 2018-02-14 13:18:29 -0800, Francisco Jerez wrote: >> --- >> src/util/bitset.h | 114 >> ++ >> 1 file changed, 114 insertions(+) >> >> diff --git a/src/util/bitset.h b/src/util/bitset.h >> index 2404ce7f6

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

2018-02-15 Thread Marek Olšák
FYI, these GLSL 1.40 tests pass: https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=eeccd7b98e74e7dfefd02611563b0edbf2358327 glslparsertest dependency: https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=e3f6d5fc68b61c23c7327083bed6c90333119d75 I plan to send out those piglit

Re: [Mesa-dev] [PATCH 01/29] blorp: Handle the RGB workaround more like other workarounds

2018-02-15 Thread Pohjolainen, Topi
On Fri, Jan 26, 2018 at 05:59:30PM -0800, Jason Ekstrand wrote: > The previous version was sort-of strapped on in that it just adjusted > the blit rectangle and trusted in the fact that we would use texelFetch > and round to the nearest integer to ensure that the component positions > matched. Thi

Re: [Mesa-dev] [PATCH 06/11] meson: Move Wayland dmabuf to wayland-drm

2018-02-15 Thread Emil Velikov
On 15 February 2018 at 15:57, Daniel Stone wrote: > As the comment notes: linux-dmabuf has nothing to do with wayland-drm, > but we need a single place to build these files we can use from both EGL > and Vulkan, which is guaranteed to be included before both EGL and > Vulkan WSI. > > Signed-off-by

Re: [Mesa-dev] [PATCH 05/16] intel/isl/icl: Build and use gen11 surface state emit functions

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 19:15, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.isl.mk | 20 > src/intel/Makefile.isl.am | 4 > src/intel/Makefile.sources | 4 > src/intel/isl/isl.c| 3 +++ > src/intel/isl/isl_priv.h | 3 +++

Re: [Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 19:15, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.genxml.mk | 5 + > src/intel/Makefile.sources| 3 ++- > src/intel/genxml/genX_pack.h | 2 ++ > src/intel/genxml/gen_macros.h | 3 +++ > 4 files changed, 12 insertions(+), 1 deletion

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-15 Thread Keith Packard
Jason Ekstrand writes: > It seems a little odd to me to default to opening the master node and then > fall back to the render node if it doesn't work. I suppose that's probably > ok so long as we ensure that vkGetPhysicalDeviceDisplayPropertiesKHR > returns no displays if we're on the render nod

Re: [Mesa-dev] [PATCH 01/16] intel/genxml/icl: Add gen11.xml

2018-02-15 Thread Emil Velikov
Hi Anuj, On 13 February 2018 at 22:41, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > This patch adds a big xml file. So I couldn't send the patch > to the list. Clamping down the patch so that reviewers can > actually see what i'm doing in [PATCH 01/16 ]. The whole > patch can be found

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

2018-02-15 Thread Emil Velikov
On 12 February 2018 at 19:27, Dylan Baker wrote: > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > Signed-off-by: Dylan Baker > --- > src/gallium/targets/d3dadapter9/meson.build | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH] loader_dri3/glx/egl: Reinstate the loader_dri3_vtable get_dri_screen callback

2018-02-15 Thread Brian Paul
I'm not too familiar with this code, but your changes look OK to me. Reviewed-by: Brian Paul On 02/09/2018 01:37 AM, Thomas Hellstrom wrote: Removing this callback caused rendering corruption in some multi-screen cases, so it is reinstated but without the drawable argument which was never used

Re: [Mesa-dev] [PATCH] svga: replace gotos with else clauses

2018-02-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 15, 2018 8:31:12 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: replace gotos with else clauses Simple clean-up. --- src/galli

[Mesa-dev] [PATCH] svga: replace gotos with else clauses

2018-02-15 Thread Brian Paul
Simple clean-up. --- src/gallium/drivers/svga/svga_state_fs.c | 19 +-- src/gallium/drivers/svga/svga_state_gs.c | 9 - src/gallium/drivers/svga/svga_state_vs.c | 15 +++ 3 files changed, 20 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/svga/

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Michel Dänzer
On 2018-02-15 05:17 PM, Daniel Stone wrote: > Hi Michel, > > On 15 February 2018 at 16:14, Michel Dänzer wrote: >> On 2018-02-15 04:57 PM, Daniel Stone wrote: >>> @@ -885,6 +901,11 @@ loader_dri3_swap_buffers_msc(struct >>> loader_dri3_drawable *draw, >>>if (!loader_dri3_have_image_blit(

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Daniel Stone
Hi Michel, On 15 February 2018 at 16:14, Michel Dänzer wrote: > On 2018-02-15 04:57 PM, Daniel Stone wrote: >> @@ -885,6 +901,11 @@ loader_dri3_swap_buffers_msc(struct >> loader_dri3_drawable *draw, >>if (!loader_dri3_have_image_blit(draw) && draw->cur_blit_source != -1) >> opt

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Michel Dänzer
On 2018-02-15 04:57 PM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > If PresentCompleteNotify event says the pixmap was presented > with mode PresentCompleteModeSuboptimalCopy, it means the pixmap > could possibly have been flipped instead if allocated with a > different format/m

Re: [Mesa-dev] [PATCH] svga: call tgsi_scan_shader() for dummy shaders

2018-02-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, February 14, 2018 6:57:21 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: call tgsi_scan_shader() for dummy shaders If we fail to compi

  1   2   >